Iku-turso
b93bea359b
Simplify overriding of platform in a unit test
...
Also make typing of platforms more strict, and remove some magic strings.
Also add a TODO for further OCP-ification.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-26 11:34:55 +03:00
Iku-turso
b4f48a30cc
Make non-shown application menu items not break composite structure
...
This was made apparent by adding related unit tests for all known environments.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-24 14:39:32 +03:00
Janne Savolainen
1eb45ac1a4
Consolidate output of get-composite-path to match find-composite's input
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-24 09:28:46 +03:00
Janne Savolainen
95767e9d95
Move utility functions to common
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-21 08:23:21 +03:00
Janne Savolainen
f212c2a86d
Consolidate directory structure of composite
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-21 08:23:21 +03:00
Janne Savolainen
a8cc1cd17c
Simplify hierarchy of application menu items using "single-root" composite
...
Also solve composed typing of application menu by using Discriminated Unions of TypeScript, see: https://www.typescriptlang.org/docs/handbook/2/narrowing.html#discriminated-unions
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-20 08:39:16 +03:00
Iku-turso
3add4255cf
Simplify a test
...
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-20 08:37:58 +03:00
Iku-turso
88ea157352
Migrate some application menu items to injectables
...
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-20 08:36:19 +03:00
