mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
* Renderer file logging through IPC Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com> * Remove pagehide event listener as it may cause UI to freeze Pagehide was needed in cluster frame to better handle main frame close/reload situation. But even empty pagehide listener in cluster frame seems to freeze the UI at least on some situations (multiple clusters open). Beforeunload is not always executed in cluster frame when main frame is reloaded/closed, leaving log files open. To fix that, `stopIpcLoggingInjectable` is introduced to close all log files. Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com> * Remove unnecessary formatting changes Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com> * Lint fix Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com> * Winston logger override Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com> * Remove usage of doGeneralOverrides as it has been removed Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com> * Update imports to match the new base Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com> * Remove unnecessary id Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com> * Review improvements Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com> * Extract beforeunload listener to injectable Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com> * Typo fix Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com> --------- Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
161 lines
4.5 KiB
TypeScript
161 lines
4.5 KiB
TypeScript
/**
|
|
* Copyright (c) OpenLens Authors. All rights reserved.
|
|
* Licensed under MIT License. See LICENSE in root directory for more information.
|
|
*/
|
|
import { getDiForUnitTesting } from "../getDiForUnitTesting";
|
|
import createIpcFileLoggerTransportInjectable from "./create-ipc-file-transport.injectable";
|
|
import type { IpcFileLogger } from "./ipc-file-logger.injectable";
|
|
import ipcFileLoggerInjectable from "./ipc-file-logger.injectable";
|
|
|
|
describe("ipc file logger in main", () => {
|
|
let logMock: jest.Mock;
|
|
let closeMock: jest.Mock;
|
|
let createFileTransportMock: jest.Mock;
|
|
let logger: IpcFileLogger;
|
|
|
|
beforeEach(() => {
|
|
logMock = jest.fn();
|
|
closeMock = jest.fn();
|
|
createFileTransportMock = jest.fn(() => ({
|
|
log: logMock,
|
|
close: closeMock,
|
|
}));
|
|
|
|
const di = getDiForUnitTesting();
|
|
|
|
di.override(createIpcFileLoggerTransportInjectable, () => createFileTransportMock);
|
|
logger = di.inject(ipcFileLoggerInjectable);
|
|
});
|
|
|
|
it("creates a transport for new log file", () => {
|
|
logger.log({
|
|
fileId: "some-log-file",
|
|
entry: { level: "irrelevant", message: "irrelevant" },
|
|
});
|
|
|
|
expect(createFileTransportMock).toHaveBeenCalledWith("some-log-file");
|
|
});
|
|
|
|
it("uses existing transport for log file", () => {
|
|
logger.log({
|
|
fileId: "some-log-file",
|
|
entry: { level: "irrelevant", message: "irrelevant" },
|
|
});
|
|
|
|
logger.log({
|
|
fileId: "some-log-file",
|
|
entry: { level: "irrelevant", message: "irrelevant" },
|
|
});
|
|
|
|
logger.log({
|
|
fileId: "some-log-file",
|
|
entry: { level: "irrelevant", message: "irrelevant" },
|
|
});
|
|
|
|
expect(createFileTransportMock).toHaveBeenCalledTimes(1);
|
|
|
|
expect(createFileTransportMock).toHaveBeenCalledWith("some-log-file");
|
|
});
|
|
|
|
it("creates separate transport for each log file", () => {
|
|
logger.log({
|
|
fileId: "some-log-file",
|
|
entry: { level: "irrelevant", message: "irrelevant" },
|
|
});
|
|
|
|
logger.log({
|
|
fileId: "some-other-log-file",
|
|
entry: { level: "irrelevant", message: "irrelevant" },
|
|
});
|
|
|
|
logger.log({
|
|
fileId: "some-yet-another-log-file",
|
|
entry: { level: "irrelevant", message: "irrelevant" },
|
|
});
|
|
|
|
expect(createFileTransportMock).toHaveBeenCalledTimes(3);
|
|
|
|
expect(createFileTransportMock).toHaveBeenCalledWith("some-log-file");
|
|
|
|
expect(createFileTransportMock).toHaveBeenCalledWith("some-other-log-file");
|
|
|
|
expect(createFileTransportMock).toHaveBeenCalledWith("some-yet-another-log-file");
|
|
});
|
|
|
|
it("logs using file transport", () => {
|
|
logger.log({
|
|
fileId: "some-log-file",
|
|
entry: { level: "irrelevant", message: "some-log-message" },
|
|
});
|
|
expect(logMock.mock.calls[0][0]).toEqual({
|
|
level: "irrelevant",
|
|
message: "some-log-message",
|
|
});
|
|
});
|
|
|
|
it("logs to correct files", () => {
|
|
const someLogMock = jest.fn();
|
|
const someOthertLogMock = jest.fn();
|
|
|
|
createFileTransportMock.mockImplementation((fileId: string) => {
|
|
if (fileId === "some-log-file") {
|
|
return { log: someLogMock };
|
|
}
|
|
|
|
if (fileId === "some-other-log-file") {
|
|
return { log: someOthertLogMock };
|
|
}
|
|
|
|
return null;
|
|
});
|
|
|
|
logger.log({
|
|
fileId: "some-log-file",
|
|
entry: { level: "irrelevant", message: "some-log-message" },
|
|
});
|
|
logger.log({
|
|
fileId: "some-other-log-file",
|
|
entry: { level: "irrelevant", message: "some-other-log-message" },
|
|
});
|
|
|
|
expect(someLogMock).toHaveBeenCalledTimes(1);
|
|
expect(someLogMock.mock.calls[0][0]).toEqual({
|
|
level: "irrelevant",
|
|
message: "some-log-message",
|
|
});
|
|
expect(someOthertLogMock).toHaveBeenCalledTimes(1);
|
|
expect(someOthertLogMock.mock.calls[0][0]).toEqual({
|
|
level: "irrelevant",
|
|
message: "some-other-log-message",
|
|
});
|
|
});
|
|
|
|
it("closes transport (to ensure no file handles are left open)", () => {
|
|
logger.log({
|
|
fileId: "some-log-file",
|
|
entry: { level: "irrelevant", message: "irrelevant" },
|
|
});
|
|
|
|
logger.close("some-log-file");
|
|
|
|
expect(closeMock).toHaveBeenCalled();
|
|
});
|
|
|
|
it("creates a new transport once needed after closing previous", () => {
|
|
logger.log({
|
|
fileId: "some-log-file",
|
|
entry: { level: "irrelevant", message: "irrelevant" },
|
|
});
|
|
|
|
logger.close("some-log-file");
|
|
|
|
logger.log({
|
|
fileId: "some-log-file",
|
|
entry: { level: "irrelevant", message: "irrelevant" },
|
|
});
|
|
|
|
expect(createFileTransportMock).toHaveBeenCalledTimes(2);
|
|
expect(logMock).toHaveBeenCalledTimes(2);
|
|
});
|
|
});
|