mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
* Ignore clusters with invalid kubeconfig Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com> * Improve error message Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com> * Mark cluster as dead if kubeconfig loading fails Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com> * Fix tests Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com> * Validate cluster object in kubeconfig when constructing cluster Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com> * Add unit tests for validateKubeConfig Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com> * Refactor validateKubeconfig unit tests Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com> * Extract ValidationOpts type Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com> * Add default value to validationOpts param Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com> * Change isDead to property Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com> * Fix lint issues Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com> * Add missing new line Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com> * Update validateKubeConfig in-code documentation Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com> * Remove isDead property Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com> * Display warning notification if invalid kubeconfig detected (#2233) * Display warning notification if invalid kubeconfig detected Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
568 lines
16 KiB
TypeScript
568 lines
16 KiB
TypeScript
import fs from "fs";
|
|
import mockFs from "mock-fs";
|
|
import yaml from "js-yaml";
|
|
import { Cluster } from "../../main/cluster";
|
|
import { ClusterStore, getClusterIdFromHost } from "../cluster-store";
|
|
import { workspaceStore } from "../workspace-store";
|
|
|
|
const testDataIcon = fs.readFileSync("test-data/cluster-store-migration-icon.png");
|
|
const kubeconfig = `
|
|
apiVersion: v1
|
|
clusters:
|
|
- cluster:
|
|
server: https://localhost
|
|
name: test
|
|
contexts:
|
|
- context:
|
|
cluster: test
|
|
user: test
|
|
name: foo
|
|
- context:
|
|
cluster: test
|
|
user: test
|
|
name: foo2
|
|
current-context: test
|
|
kind: Config
|
|
preferences: {}
|
|
users:
|
|
- name: test
|
|
user:
|
|
token: kubeconfig-user-q4lm4:xxxyyyy
|
|
`;
|
|
|
|
jest.mock("electron", () => {
|
|
return {
|
|
app: {
|
|
getVersion: () => "99.99.99",
|
|
getPath: () => "tmp",
|
|
getLocale: () => "en"
|
|
},
|
|
ipcMain: {
|
|
handle: jest.fn(),
|
|
on: jest.fn()
|
|
}
|
|
};
|
|
});
|
|
|
|
let clusterStore: ClusterStore;
|
|
|
|
describe("empty config", () => {
|
|
beforeEach(() => {
|
|
ClusterStore.resetInstance();
|
|
const mockOpts = {
|
|
"tmp": {
|
|
"lens-cluster-store.json": JSON.stringify({})
|
|
}
|
|
};
|
|
|
|
mockFs(mockOpts);
|
|
clusterStore = ClusterStore.getInstance<ClusterStore>();
|
|
|
|
return clusterStore.load();
|
|
});
|
|
|
|
afterEach(() => {
|
|
mockFs.restore();
|
|
});
|
|
|
|
describe("with foo cluster added", () => {
|
|
beforeEach(() => {
|
|
clusterStore.addCluster(
|
|
new Cluster({
|
|
id: "foo",
|
|
contextName: "foo",
|
|
preferences: {
|
|
terminalCWD: "/tmp",
|
|
icon: "data:image/jpeg;base64, iVBORw0KGgoAAAANSUhEUgAAA1wAAAKoCAYAAABjkf5",
|
|
clusterName: "minikube"
|
|
},
|
|
kubeConfigPath: ClusterStore.embedCustomKubeConfig("foo", kubeconfig),
|
|
workspace: workspaceStore.currentWorkspaceId
|
|
})
|
|
);
|
|
});
|
|
|
|
it("adds new cluster to store", async () => {
|
|
const storedCluster = clusterStore.getById("foo");
|
|
|
|
expect(storedCluster.id).toBe("foo");
|
|
expect(storedCluster.preferences.terminalCWD).toBe("/tmp");
|
|
expect(storedCluster.preferences.icon).toBe("data:image/jpeg;base64, iVBORw0KGgoAAAANSUhEUgAAA1wAAAKoCAYAAABjkf5");
|
|
expect(storedCluster.enabled).toBe(true);
|
|
});
|
|
|
|
it("adds cluster to default workspace", () => {
|
|
const storedCluster = clusterStore.getById("foo");
|
|
|
|
expect(storedCluster.workspace).toBe("default");
|
|
});
|
|
|
|
it("removes cluster from store", async () => {
|
|
await clusterStore.removeById("foo");
|
|
expect(clusterStore.getById("foo")).toBeUndefined();
|
|
});
|
|
|
|
it("sets active cluster", () => {
|
|
clusterStore.setActive("foo");
|
|
expect(clusterStore.active.id).toBe("foo");
|
|
expect(workspaceStore.currentWorkspace.lastActiveClusterId).toBe("foo");
|
|
});
|
|
});
|
|
|
|
describe("with prod and dev clusters added", () => {
|
|
beforeEach(() => {
|
|
clusterStore.addClusters(
|
|
new Cluster({
|
|
id: "prod",
|
|
contextName: "foo",
|
|
preferences: {
|
|
clusterName: "prod"
|
|
},
|
|
kubeConfigPath: ClusterStore.embedCustomKubeConfig("prod", kubeconfig),
|
|
workspace: "workstation"
|
|
}),
|
|
new Cluster({
|
|
id: "dev",
|
|
contextName: "foo2",
|
|
preferences: {
|
|
clusterName: "dev"
|
|
},
|
|
kubeConfigPath: ClusterStore.embedCustomKubeConfig("dev", kubeconfig),
|
|
workspace: "workstation"
|
|
})
|
|
);
|
|
});
|
|
|
|
it("check if store can contain multiple clusters", () => {
|
|
expect(clusterStore.hasClusters()).toBeTruthy();
|
|
expect(clusterStore.clusters.size).toBe(2);
|
|
});
|
|
|
|
it("gets clusters by workspaces", () => {
|
|
const wsClusters = clusterStore.getByWorkspaceId("workstation");
|
|
const defaultClusters = clusterStore.getByWorkspaceId("default");
|
|
|
|
expect(defaultClusters.length).toBe(0);
|
|
expect(wsClusters.length).toBe(2);
|
|
expect(wsClusters[0].id).toBe("prod");
|
|
expect(wsClusters[1].id).toBe("dev");
|
|
});
|
|
|
|
it("check if cluster's kubeconfig file saved", () => {
|
|
const file = ClusterStore.embedCustomKubeConfig("boo", "kubeconfig");
|
|
|
|
expect(fs.readFileSync(file, "utf8")).toBe("kubeconfig");
|
|
});
|
|
|
|
it("check if reorderring works for same from and to", () => {
|
|
clusterStore.swapIconOrders("workstation", 1, 1);
|
|
|
|
const clusters = clusterStore.getByWorkspaceId("workstation");
|
|
|
|
expect(clusters[0].id).toBe("prod");
|
|
expect(clusters[0].preferences.iconOrder).toBe(0);
|
|
expect(clusters[1].id).toBe("dev");
|
|
expect(clusters[1].preferences.iconOrder).toBe(1);
|
|
});
|
|
|
|
it("check if reorderring works for different from and to", () => {
|
|
clusterStore.swapIconOrders("workstation", 0, 1);
|
|
|
|
const clusters = clusterStore.getByWorkspaceId("workstation");
|
|
|
|
expect(clusters[0].id).toBe("dev");
|
|
expect(clusters[0].preferences.iconOrder).toBe(0);
|
|
expect(clusters[1].id).toBe("prod");
|
|
expect(clusters[1].preferences.iconOrder).toBe(1);
|
|
});
|
|
|
|
it("check if after icon reordering, changing workspaces still works", () => {
|
|
clusterStore.swapIconOrders("workstation", 1, 1);
|
|
clusterStore.getById("prod").workspace = "default";
|
|
|
|
expect(clusterStore.getByWorkspaceId("workstation").length).toBe(1);
|
|
expect(clusterStore.getByWorkspaceId("default").length).toBe(1);
|
|
});
|
|
});
|
|
});
|
|
|
|
describe("config with existing clusters", () => {
|
|
beforeEach(() => {
|
|
ClusterStore.resetInstance();
|
|
const mockOpts = {
|
|
"tmp": {
|
|
"lens-cluster-store.json": JSON.stringify({
|
|
__internal__: {
|
|
migrations: {
|
|
version: "99.99.99"
|
|
}
|
|
},
|
|
clusters: [
|
|
{
|
|
id: "cluster1",
|
|
kubeConfigPath: kubeconfig,
|
|
contextName: "foo",
|
|
preferences: { terminalCWD: "/foo" },
|
|
workspace: "default"
|
|
},
|
|
{
|
|
id: "cluster2",
|
|
kubeConfigPath: kubeconfig,
|
|
contextName: "foo2",
|
|
preferences: { terminalCWD: "/foo2" }
|
|
},
|
|
{
|
|
id: "cluster3",
|
|
kubeConfigPath: kubeconfig,
|
|
contextName: "foo",
|
|
preferences: { terminalCWD: "/foo" },
|
|
workspace: "foo",
|
|
ownerRef: "foo"
|
|
},
|
|
]
|
|
})
|
|
}
|
|
};
|
|
|
|
mockFs(mockOpts);
|
|
clusterStore = ClusterStore.getInstance<ClusterStore>();
|
|
|
|
return clusterStore.load();
|
|
});
|
|
|
|
afterEach(() => {
|
|
mockFs.restore();
|
|
});
|
|
|
|
it("allows to retrieve a cluster", () => {
|
|
const storedCluster = clusterStore.getById("cluster1");
|
|
|
|
expect(storedCluster.id).toBe("cluster1");
|
|
expect(storedCluster.preferences.terminalCWD).toBe("/foo");
|
|
});
|
|
|
|
it("allows to delete a cluster", () => {
|
|
clusterStore.removeById("cluster2");
|
|
const storedCluster = clusterStore.getById("cluster1");
|
|
|
|
expect(storedCluster).toBeTruthy();
|
|
const storedCluster2 = clusterStore.getById("cluster2");
|
|
|
|
expect(storedCluster2).toBeUndefined();
|
|
});
|
|
|
|
it("allows getting all of the clusters", async () => {
|
|
const storedClusters = clusterStore.clustersList;
|
|
|
|
expect(storedClusters.length).toBe(3);
|
|
expect(storedClusters[0].id).toBe("cluster1");
|
|
expect(storedClusters[0].preferences.terminalCWD).toBe("/foo");
|
|
expect(storedClusters[1].id).toBe("cluster2");
|
|
expect(storedClusters[1].preferences.terminalCWD).toBe("/foo2");
|
|
expect(storedClusters[2].id).toBe("cluster3");
|
|
});
|
|
|
|
it("marks owned cluster disabled by default", () => {
|
|
const storedClusters = clusterStore.clustersList;
|
|
|
|
expect(storedClusters[0].enabled).toBe(true);
|
|
expect(storedClusters[2].enabled).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("config with invalid cluster kubeconfig", () => {
|
|
beforeEach(() => {
|
|
const invalidKubeconfig = `
|
|
apiVersion: v1
|
|
clusters:
|
|
- cluster:
|
|
server: https://localhost
|
|
name: test2
|
|
contexts:
|
|
- context:
|
|
cluster: test
|
|
user: test
|
|
name: test
|
|
current-context: test
|
|
kind: Config
|
|
preferences: {}
|
|
users:
|
|
- name: test
|
|
user:
|
|
token: kubeconfig-user-q4lm4:xxxyyyy
|
|
`;
|
|
|
|
ClusterStore.resetInstance();
|
|
const mockOpts = {
|
|
"tmp": {
|
|
"lens-cluster-store.json": JSON.stringify({
|
|
__internal__: {
|
|
migrations: {
|
|
version: "99.99.99"
|
|
}
|
|
},
|
|
clusters: [
|
|
{
|
|
id: "cluster1",
|
|
kubeConfigPath: invalidKubeconfig,
|
|
contextName: "test",
|
|
preferences: { terminalCWD: "/foo" },
|
|
workspace: "foo",
|
|
},
|
|
{
|
|
id: "cluster2",
|
|
kubeConfigPath: kubeconfig,
|
|
contextName: "foo",
|
|
preferences: { terminalCWD: "/foo" },
|
|
workspace: "default"
|
|
},
|
|
|
|
]
|
|
})
|
|
}
|
|
};
|
|
|
|
mockFs(mockOpts);
|
|
clusterStore = ClusterStore.getInstance<ClusterStore>();
|
|
|
|
return clusterStore.load();
|
|
});
|
|
|
|
afterEach(() => {
|
|
mockFs.restore();
|
|
});
|
|
|
|
it("does not enable clusters with invalid kubeconfig", () => {
|
|
const storedClusters = clusterStore.clustersList;
|
|
|
|
expect(storedClusters.length).toBe(2);
|
|
expect(storedClusters[0].enabled).toBeFalsy;
|
|
expect(storedClusters[1].id).toBe("cluster2");
|
|
expect(storedClusters[1].enabled).toBeTruthy;
|
|
});
|
|
});
|
|
|
|
describe("pre 2.0 config with an existing cluster", () => {
|
|
beforeEach(() => {
|
|
ClusterStore.resetInstance();
|
|
const mockOpts = {
|
|
"tmp": {
|
|
"lens-cluster-store.json": JSON.stringify({
|
|
__internal__: {
|
|
migrations: {
|
|
version: "1.0.0"
|
|
}
|
|
},
|
|
cluster1: "kubeconfig content"
|
|
})
|
|
}
|
|
};
|
|
|
|
mockFs(mockOpts);
|
|
clusterStore = ClusterStore.getInstance<ClusterStore>();
|
|
|
|
return clusterStore.load();
|
|
});
|
|
|
|
afterEach(() => {
|
|
mockFs.restore();
|
|
});
|
|
|
|
it("migrates to modern format with kubeconfig in a file", async () => {
|
|
const config = clusterStore.clustersList[0].kubeConfigPath;
|
|
|
|
expect(fs.readFileSync(config, "utf8")).toBe("kubeconfig content");
|
|
});
|
|
});
|
|
|
|
describe("pre 2.6.0 config with a cluster that has arrays in auth config", () => {
|
|
beforeEach(() => {
|
|
ClusterStore.resetInstance();
|
|
const mockOpts = {
|
|
"tmp": {
|
|
"lens-cluster-store.json": JSON.stringify({
|
|
__internal__: {
|
|
migrations: {
|
|
version: "2.4.1"
|
|
}
|
|
},
|
|
cluster1: {
|
|
kubeConfig: "apiVersion: v1\nclusters:\n- cluster:\n server: https://10.211.55.6:8443\n name: minikube\ncontexts:\n- context:\n cluster: minikube\n user: minikube\n name: minikube\ncurrent-context: minikube\nkind: Config\npreferences: {}\nusers:\n- name: minikube\n user:\n client-certificate: /Users/kimmo/.minikube/client.crt\n client-key: /Users/kimmo/.minikube/client.key\n auth-provider:\n config:\n access-token:\n - should be string\n expiry:\n - should be string\n"
|
|
},
|
|
})
|
|
}
|
|
};
|
|
|
|
mockFs(mockOpts);
|
|
clusterStore = ClusterStore.getInstance<ClusterStore>();
|
|
|
|
return clusterStore.load();
|
|
});
|
|
|
|
afterEach(() => {
|
|
mockFs.restore();
|
|
});
|
|
|
|
it("replaces array format access token and expiry into string", async () => {
|
|
const file = clusterStore.clustersList[0].kubeConfigPath;
|
|
const config = fs.readFileSync(file, "utf8");
|
|
const kc = yaml.safeLoad(config);
|
|
|
|
expect(kc.users[0].user["auth-provider"].config["access-token"]).toBe("should be string");
|
|
expect(kc.users[0].user["auth-provider"].config["expiry"]).toBe("should be string");
|
|
});
|
|
});
|
|
|
|
describe("pre 2.6.0 config with a cluster icon", () => {
|
|
beforeEach(() => {
|
|
ClusterStore.resetInstance();
|
|
const mockOpts = {
|
|
"tmp": {
|
|
"lens-cluster-store.json": JSON.stringify({
|
|
__internal__: {
|
|
migrations: {
|
|
version: "2.4.1"
|
|
}
|
|
},
|
|
cluster1: {
|
|
kubeConfig: "foo",
|
|
icon: "icon_path",
|
|
preferences: {
|
|
terminalCWD: "/tmp"
|
|
}
|
|
},
|
|
}),
|
|
"icon_path": testDataIcon,
|
|
}
|
|
};
|
|
|
|
mockFs(mockOpts);
|
|
clusterStore = ClusterStore.getInstance<ClusterStore>();
|
|
|
|
return clusterStore.load();
|
|
});
|
|
|
|
afterEach(() => {
|
|
mockFs.restore();
|
|
});
|
|
|
|
it("moves the icon into preferences", async () => {
|
|
const storedClusterData = clusterStore.clustersList[0];
|
|
|
|
expect(storedClusterData.hasOwnProperty("icon")).toBe(false);
|
|
expect(storedClusterData.preferences.hasOwnProperty("icon")).toBe(true);
|
|
expect(storedClusterData.preferences.icon.startsWith("data:;base64,")).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe("for a pre 2.7.0-beta.0 config without a workspace", () => {
|
|
beforeEach(() => {
|
|
ClusterStore.resetInstance();
|
|
const mockOpts = {
|
|
"tmp": {
|
|
"lens-cluster-store.json": JSON.stringify({
|
|
__internal__: {
|
|
migrations: {
|
|
version: "2.6.6"
|
|
}
|
|
},
|
|
cluster1: {
|
|
kubeConfig: "foo",
|
|
preferences: {
|
|
terminalCWD: "/tmp"
|
|
}
|
|
},
|
|
})
|
|
}
|
|
};
|
|
|
|
mockFs(mockOpts);
|
|
clusterStore = ClusterStore.getInstance<ClusterStore>();
|
|
|
|
return clusterStore.load();
|
|
});
|
|
|
|
afterEach(() => {
|
|
mockFs.restore();
|
|
});
|
|
|
|
it("adds cluster to default workspace", async () => {
|
|
const storedClusterData = clusterStore.clustersList[0];
|
|
|
|
expect(storedClusterData.workspace).toBe("default");
|
|
});
|
|
});
|
|
|
|
describe("pre 3.6.0-beta.1 config with an existing cluster", () => {
|
|
beforeEach(() => {
|
|
ClusterStore.resetInstance();
|
|
const mockOpts = {
|
|
"tmp": {
|
|
"lens-cluster-store.json": JSON.stringify({
|
|
__internal__: {
|
|
migrations: {
|
|
version: "3.5.0"
|
|
}
|
|
},
|
|
clusters: [
|
|
{
|
|
id: "cluster1",
|
|
kubeConfig: "kubeconfig content",
|
|
contextName: "cluster",
|
|
preferences: {
|
|
icon: "store://icon_path",
|
|
}
|
|
}
|
|
]
|
|
}),
|
|
"icon_path": testDataIcon,
|
|
}
|
|
};
|
|
|
|
mockFs(mockOpts);
|
|
clusterStore = ClusterStore.getInstance<ClusterStore>();
|
|
|
|
return clusterStore.load();
|
|
});
|
|
|
|
afterEach(() => {
|
|
mockFs.restore();
|
|
});
|
|
|
|
it("migrates to modern format with kubeconfig in a file", async () => {
|
|
const config = clusterStore.clustersList[0].kubeConfigPath;
|
|
|
|
expect(fs.readFileSync(config, "utf8")).toBe("kubeconfig content");
|
|
});
|
|
|
|
it("migrates to modern format with icon not in file", async () => {
|
|
const { icon } = clusterStore.clustersList[0].preferences;
|
|
|
|
expect(icon.startsWith("data:;base64,")).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe("getClusterIdFromHost", () => {
|
|
const clusterFakeId = "fe540901-0bd6-4f6c-b472-bce1559d7c4a";
|
|
|
|
it("should return undefined for non cluster frame hosts", () => {
|
|
expect(getClusterIdFromHost("localhost:45345")).toBeUndefined();
|
|
});
|
|
|
|
it("should return ClusterId for cluster frame hosts", () => {
|
|
expect(getClusterIdFromHost(`${clusterFakeId}.localhost:59110`)).toBe(clusterFakeId);
|
|
});
|
|
|
|
it("should return ClusterId for cluster frame hosts with additional subdomains", () => {
|
|
expect(getClusterIdFromHost(`abc.${clusterFakeId}.localhost:59110`)).toBe(clusterFakeId);
|
|
expect(getClusterIdFromHost(`abc.def.${clusterFakeId}.localhost:59110`)).toBe(clusterFakeId);
|
|
expect(getClusterIdFromHost(`abc.def.ghi.${clusterFakeId}.localhost:59110`)).toBe(clusterFakeId);
|
|
expect(getClusterIdFromHost(`abc.def.ghi.jkl.${clusterFakeId}.localhost:59110`)).toBe(clusterFakeId);
|
|
expect(getClusterIdFromHost(`abc.def.ghi.jkl.mno.${clusterFakeId}.localhost:59110`)).toBe(clusterFakeId);
|
|
expect(getClusterIdFromHost(`abc.def.ghi.jkl.mno.pqr.${clusterFakeId}.localhost:59110`)).toBe(clusterFakeId);
|
|
expect(getClusterIdFromHost(`abc.def.ghi.jkl.mno.pqr.stu.${clusterFakeId}.localhost:59110`)).toBe(clusterFakeId);
|
|
expect(getClusterIdFromHost(`abc.def.ghi.jkl.mno.pqr.stu.vwx.${clusterFakeId}.localhost:59110`)).toBe(clusterFakeId);
|
|
expect(getClusterIdFromHost(`abc.def.ghi.jkl.mno.pqr.stu.vwx.yz.${clusterFakeId}.localhost:59110`)).toBe(clusterFakeId);
|
|
});
|
|
});
|