mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
* Making apiBase injectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Convert all of Helm functions to be DI Signed-off-by: Sebastian Malton <sebastian@malton.name> * Make PortForward's use of apiBase fully injectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Convert all metric requests to be injectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Replace resource applier with injectables Signed-off-by: Sebastian Malton <sebastian@malton.name> * Switch KubeJsonApi.forCluster to be injectable but do not use Signed-off-by: Sebastian Malton <sebastian@malton.name> * Convert the rest of shell sessions to be DI-ed - This is a prerequesit for using the new createKubeJsonApiForClusterInjectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Use new createKubeJsonApiForClusterInjectable for openNodeShellSession Signed-off-by: Sebastian Malton <sebastian@malton.name> * Make KubeconfigDialog injectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove jest-fetch-mock and make fetch injectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix tests with new global override Signed-off-by: Sebastian Malton <sebastian@malton.name> * Add new injectable for create KubeJsonApi and JsonApi instances Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix showing-details-for-helm-release behavioural tests - Remove HelmChartStore in favour of all injectables - Create a model for UpgradeChartDockTab Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix show details and updating helm releases tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix residual typing issues related to metrics Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix crash on load due to circular dependency Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix create resource tab not working Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove legacy apiBase global Signed-off-by: Sebastian Malton <sebastian@malton.name> * Introduce and use isDebuggingInjectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Introduce and use windowLocationInjectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove global legacy apiKube Signed-off-by: Sebastian Malton <sebastian@malton.name> * Improve injectable filenames compared to the injectables inside Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove modifying input in requestActivePortForwardInjectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Introduce and use get(Milli)SecondsFromUnixEpochInjectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Switch to non-reactive way of gettting possible helm release versions Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix typo Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix bug in KubeApi constructor Signed-off-by: Sebastian Malton <sebastian@malton.name> * Convert all KubeApi related tests to use asyncFn Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix unit tests after introducing new injectables that have side effects Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix bad rebase causing tests to fail Signed-off-by: Sebastian Malton <sebastian@malton.name> * Improve expects for multiple field values Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix crash will looking up api refs Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix breaking change on KubeApi.list Signed-off-by: Sebastian Malton <sebastian@malton.name> * Better fix for formatting urls Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove injectable for time since we should just use useMockTime Signed-off-by: Sebastian Malton <sebastian@malton.name> * Add happy path behavioural tests for upgrade chart tab Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove debug message Signed-off-by: Sebastian Malton <sebastian@malton.name> * Update snapshots Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix showing-details-for-helm-release tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix installing-helm-chart-from-new-tab tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix tests relating to hosted cluster id Signed-off-by: Sebastian Malton <sebastian@malton.name> * Update snapshots to recent changes in master Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Reupdated upgrade chart new tab test snapshots Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix flakiness in unit test when using <Animated> Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix flakiness and improve tests for DeleteClusterDialog Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix kubeconfig-sync tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix <Extensions> tests by removing mockFs and making everything injectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix build issues Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix getElectronAppPathInjectable override not returning absolute paths - Also fixes the listing-active-helm-repos-in-prefs tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Replace all uses of getAbsolutePath with joinPaths as it is more correct and less confusing Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix opening application window tests by making override properly absolute Signed-off-by: Sebastian Malton <sebastian@malton.name> * Update snapshots relating no longer using getAbsolutePath Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix and add behavioural tests for RenderDelay Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix extension discovery tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix test flakiness because of path side effects, propagate uses to as many places Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix extension-discovery tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Add global override to fix some tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Rewrite and fix implementation of KubeconfigManager and its tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix tests by global override pathExists Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix unit tests failing on windows by using injectable verions of path functions Signed-off-by: Sebastian Malton <sebastian@malton.name> * Attempt to fix test timeout by using runInAction Signed-off-by: Sebastian Malton <sebastian@malton.name> * Update snapshots after rebase Signed-off-by: Sebastian Malton <sebastian@malton.name> * Update snapshots after rebase Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix tests after rebase Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix setupIpcMainHandlers usage Signed-off-by: Sebastian Malton <sebastian@malton.name> * Update snapshots Signed-off-by: Sebastian Malton <sebastian@malton.name> Signed-off-by: Sebastian Malton <sebastian@malton.name> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> Co-authored-by: Iku-turso <mikko.aspiala@gmail.com>
357 lines
12 KiB
TypeScript
357 lines
12 KiB
TypeScript
/**
|
|
* Copyright (c) OpenLens Authors. All rights reserved.
|
|
* Licensed under MIT License. See LICENSE in root directory for more information.
|
|
*/
|
|
import type { DiContainer } from "@ogre-tools/injectable";
|
|
import { getInjectable } from "@ogre-tools/injectable";
|
|
import React from "react";
|
|
import type { RenderResult } from "@testing-library/react";
|
|
import { fireEvent } from "@testing-library/react";
|
|
import directoryForLensLocalStorageInjectable from "../../common/directory-for-lens-local-storage/directory-for-lens-local-storage.injectable";
|
|
import { routeSpecificComponentInjectionToken } from "../../renderer/routes/route-specific-component-injection-token";
|
|
import type { SidebarItemRegistration } from "../../renderer/components/layout/sidebar-items.injectable";
|
|
import { sidebarItemsInjectionToken } from "../../renderer/components/layout/sidebar-items.injectable";
|
|
import { computed, runInAction } from "mobx";
|
|
import { noop } from "lodash/fp";
|
|
import routeIsActiveInjectable from "../../renderer/routes/route-is-active.injectable";
|
|
import { frontEndRouteInjectionToken } from "../../common/front-end-routing/front-end-route-injection-token";
|
|
import type { ApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder";
|
|
import { getApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder";
|
|
import writeJsonFileInjectable from "../../common/fs/write-json-file.injectable";
|
|
import pathExistsInjectable from "../../common/fs/path-exists.injectable";
|
|
import readJsonFileInjectable from "../../common/fs/read-json-file.injectable";
|
|
import { navigateToRouteInjectionToken } from "../../common/front-end-routing/navigate-to-route-injection-token";
|
|
import sidebarStorageInjectable from "../../renderer/components/layout/sidebar-storage/sidebar-storage.injectable";
|
|
import { advanceFakeTime, useFakeTime } from "../../common/test-utils/use-fake-time";
|
|
import storageSaveDelayInjectable from "../../renderer/utils/create-storage/storage-save-delay.injectable";
|
|
|
|
describe("cluster - sidebar and tab navigation for core", () => {
|
|
let builder: ApplicationBuilder;
|
|
let rendered: RenderResult;
|
|
|
|
beforeEach(() => {
|
|
useFakeTime("2015-10-21T07:28:00Z");
|
|
|
|
builder = getApplicationBuilder();
|
|
|
|
builder.setEnvironmentToClusterFrame();
|
|
|
|
builder.beforeWindowStart((windowDi) => {
|
|
windowDi.override(storageSaveDelayInjectable, () => 250);
|
|
|
|
windowDi.override(
|
|
directoryForLensLocalStorageInjectable,
|
|
() => "/some-directory-for-lens-local-storage",
|
|
);
|
|
});
|
|
});
|
|
|
|
describe("given core registrations", () => {
|
|
beforeEach(() => {
|
|
builder.beforeWindowStart((windowDi) => {
|
|
runInAction(() => {
|
|
windowDi.register(testRouteInjectable);
|
|
windowDi.register(testRouteComponentInjectable);
|
|
windowDi.register(testSidebarItemsInjectable);
|
|
});
|
|
});
|
|
});
|
|
|
|
describe("given no state for expanded sidebar items exists, and navigated to child sidebar item, when rendered", () => {
|
|
beforeEach(async () => {
|
|
rendered = await builder.render();
|
|
|
|
const windowDi = builder.applicationWindow.only.di;
|
|
|
|
const route = windowDi.inject(testRouteInjectable);
|
|
const navigateToRoute = windowDi.inject(navigateToRouteInjectionToken);
|
|
|
|
navigateToRoute(route);
|
|
});
|
|
|
|
it("renders", () => {
|
|
expect(rendered.container).toMatchSnapshot();
|
|
});
|
|
|
|
it("parent is highlighted", () => {
|
|
const parent = rendered.queryByTestId("sidebar-item-some-parent-id");
|
|
|
|
expect(parent?.dataset.isActiveTest).toBe("true");
|
|
});
|
|
|
|
it("parent sidebar item is not expanded", () => {
|
|
const child = rendered.queryByTestId("sidebar-item-some-child-id");
|
|
|
|
expect(child).toBeNull();
|
|
});
|
|
|
|
it("child page is shown", () => {
|
|
expect(rendered.getByTestId("some-child-page")).not.toBeNull();
|
|
});
|
|
});
|
|
|
|
describe("given state for expanded sidebar items already exists, when rendered", () => {
|
|
beforeEach(async () => {
|
|
builder.beforeWindowStart(async (windowDi) => {
|
|
const writeJsonFileFake = windowDi.inject(writeJsonFileInjectable);
|
|
|
|
await writeJsonFileFake(
|
|
"/some-directory-for-lens-local-storage/some-cluster-id.json",
|
|
{
|
|
sidebar: {
|
|
expanded: { "some-parent-id": true },
|
|
width: 200,
|
|
},
|
|
},
|
|
);
|
|
|
|
const sidebarStorage = windowDi.inject(sidebarStorageInjectable);
|
|
|
|
await sidebarStorage.whenReady;
|
|
});
|
|
|
|
rendered = await builder.render();
|
|
});
|
|
|
|
it("renders", () => {
|
|
expect(rendered.container).toMatchSnapshot();
|
|
});
|
|
|
|
it("parent sidebar item is not highlighted", () => {
|
|
const parent = rendered.queryByTestId("sidebar-item-some-parent-id");
|
|
|
|
expect(parent?.dataset.isActiveTest).toBe("false");
|
|
});
|
|
|
|
it("parent sidebar item is expanded", () => {
|
|
const child = rendered.queryByTestId("sidebar-item-some-child-id");
|
|
|
|
expect(child).not.toBeNull();
|
|
});
|
|
});
|
|
|
|
describe("given state for expanded unknown sidebar items already exists, when rendered", () => {
|
|
beforeEach(async () => {
|
|
builder.beforeWindowStart(async (windowDi) => {
|
|
const writeJsonFileFake = windowDi.inject(writeJsonFileInjectable);
|
|
|
|
await writeJsonFileFake(
|
|
"/some-directory-for-lens-local-storage/some-hosted-cluster-id.json",
|
|
{
|
|
sidebar: {
|
|
expanded: { "some-unknown-parent-id": true },
|
|
width: 200,
|
|
},
|
|
},
|
|
);
|
|
});
|
|
|
|
rendered = await builder.render();
|
|
});
|
|
|
|
it("renders without errors", () => {
|
|
expect(rendered.container).toMatchSnapshot();
|
|
});
|
|
|
|
it("parent sidebar item is not expanded", () => {
|
|
const child = rendered.queryByTestId("sidebar-item-some-child-id");
|
|
|
|
expect(child).toBeNull();
|
|
});
|
|
});
|
|
|
|
describe("given empty state for expanded sidebar items already exists, when rendered", () => {
|
|
beforeEach(async () => {
|
|
builder.beforeWindowStart(async (windowDi) => {
|
|
const writeJsonFileFake = windowDi.inject(writeJsonFileInjectable);
|
|
|
|
await writeJsonFileFake(
|
|
"/some-directory-for-lens-local-storage/some-hosted-cluster-id.json",
|
|
{
|
|
someThingButSidebar: {},
|
|
},
|
|
);
|
|
});
|
|
|
|
rendered = await builder.render();
|
|
});
|
|
|
|
it("renders without errors", () => {
|
|
expect(rendered.container).toMatchSnapshot();
|
|
});
|
|
|
|
it("parent sidebar item is not expanded", () => {
|
|
const child = rendered.queryByTestId("sidebar-item-some-child-id");
|
|
|
|
expect(child).toBeNull();
|
|
});
|
|
});
|
|
|
|
describe("given no initially persisted state for sidebar items, when rendered", () => {
|
|
let windowDi: DiContainer;
|
|
|
|
beforeEach(async () => {
|
|
rendered = await builder.render();
|
|
|
|
windowDi = builder.applicationWindow.only.di;
|
|
});
|
|
|
|
it("renders", () => {
|
|
expect(rendered.container).toMatchSnapshot();
|
|
});
|
|
|
|
it("parent sidebar item is not highlighted", () => {
|
|
const parent = rendered.queryByTestId("sidebar-item-some-parent-id");
|
|
|
|
expect(parent?.dataset.isActiveTest).toBe("false");
|
|
});
|
|
|
|
it("parent sidebar item is not expanded", () => {
|
|
const child = rendered.queryByTestId("sidebar-item-some-child-id");
|
|
|
|
expect(child).toBeNull();
|
|
});
|
|
|
|
describe("when a parent sidebar item is expanded", () => {
|
|
beforeEach(() => {
|
|
const parentLink = rendered.getByTestId(
|
|
"sidebar-item-link-for-some-parent-id",
|
|
);
|
|
|
|
fireEvent.click(parentLink);
|
|
});
|
|
|
|
it("renders", () => {
|
|
expect(rendered.container).toMatchSnapshot();
|
|
});
|
|
|
|
it("parent sidebar item is not highlighted", () => {
|
|
const parent = rendered.queryByTestId("sidebar-item-some-parent-id");
|
|
|
|
expect(parent?.dataset.isActiveTest).toBe("false");
|
|
});
|
|
|
|
it("parent sidebar item is expanded", () => {
|
|
const child = rendered.queryByTestId("sidebar-item-some-child-id");
|
|
|
|
expect(child).not.toBeNull();
|
|
});
|
|
|
|
describe("when a child of the parent is selected", () => {
|
|
beforeEach(() => {
|
|
const childLink = rendered.getByTestId(
|
|
"sidebar-item-link-for-some-child-id",
|
|
);
|
|
|
|
fireEvent.click(childLink);
|
|
});
|
|
|
|
it("renders", () => {
|
|
expect(rendered.container).toMatchSnapshot();
|
|
});
|
|
|
|
it("parent is highlighted", () => {
|
|
const parent = rendered.queryByTestId("sidebar-item-some-parent-id");
|
|
|
|
expect(parent?.dataset.isActiveTest).toBe("true");
|
|
});
|
|
|
|
it("child is highlighted", () => {
|
|
const child = rendered.queryByTestId("sidebar-item-some-child-id");
|
|
|
|
expect(child?.dataset.isActiveTest).toBe("true");
|
|
});
|
|
|
|
it("child page is shown", () => {
|
|
expect(rendered.getByTestId("some-child-page")).not.toBeNull();
|
|
});
|
|
|
|
it("when not enough time passes, does not store state for expanded sidebar items to file system yet", async () => {
|
|
advanceFakeTime(250 - 1);
|
|
|
|
const pathExistsFake = windowDi.inject(pathExistsInjectable);
|
|
|
|
const actual = await pathExistsFake(
|
|
"/some-directory-for-lens-local-storage/some-hosted-cluster-id.json",
|
|
);
|
|
|
|
expect(actual).toBe(false);
|
|
});
|
|
|
|
it("when enough time passes, stores state for expanded sidebar items to file system", async () => {
|
|
advanceFakeTime(250);
|
|
|
|
const readJsonFileFake = windowDi.inject(readJsonFileInjectable);
|
|
|
|
const actual = await readJsonFileFake(
|
|
"/some-directory-for-lens-local-storage/some-cluster-id.json",
|
|
);
|
|
|
|
expect(actual).toEqual({
|
|
sidebar: {
|
|
expanded: { "some-parent-id": true },
|
|
width: 200,
|
|
},
|
|
});
|
|
});
|
|
});
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
const testSidebarItemsInjectable = getInjectable({
|
|
id: "some-sidebar-items-injectable",
|
|
|
|
instantiate: (di) => {
|
|
const route = di.inject(testRouteInjectable);
|
|
const navigateToRoute = di.inject(navigateToRouteInjectionToken);
|
|
const routeIsActive = di.inject(routeIsActiveInjectable, route);
|
|
|
|
return computed((): SidebarItemRegistration[] => [
|
|
{
|
|
id: "some-parent-id",
|
|
parentId: null,
|
|
title: "Some parent",
|
|
onClick: noop,
|
|
getIcon: () => <div data-testid="some-icon-for-parent" />,
|
|
orderNumber: 42,
|
|
},
|
|
|
|
{
|
|
id: "some-child-id",
|
|
parentId: "some-parent-id",
|
|
title: "Some child",
|
|
onClick: () => navigateToRoute(route),
|
|
isActive: routeIsActive,
|
|
orderNumber: 42,
|
|
},
|
|
]);
|
|
},
|
|
|
|
injectionToken: sidebarItemsInjectionToken,
|
|
});
|
|
|
|
const testRouteInjectable = getInjectable({
|
|
id: "some-route-injectable-id",
|
|
|
|
instantiate: () => ({
|
|
path: "/some-child-page",
|
|
clusterFrame: true,
|
|
isEnabled: computed(() => true),
|
|
}),
|
|
|
|
injectionToken: frontEndRouteInjectionToken,
|
|
});
|
|
|
|
const testRouteComponentInjectable = getInjectable({
|
|
id: "some-child-page-route-component-injectable",
|
|
|
|
instantiate: (di) => ({
|
|
route: di.inject(testRouteInjectable),
|
|
Component: () => <div data-testid="some-child-page" />,
|
|
}),
|
|
|
|
injectionToken: routeSpecificComponentInjectionToken,
|
|
});
|