mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
* Implement a lot of technical requirements for behavioural unit tests Note: the crux of this was to make routing env-agnostic, and not based on URLs as magic strings, but instead something type-enforced. Note: extension-based routes comply to same exact interface by "late-registering" their routes when installed. Routes are just injectables. Note: another chunk of global shared state is no more. Note: a lot of explicit side effects have been cornered to injectables. Note: a lot of stuff has become reactive as part if this. Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make a directory commonly available Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Require id for <Select /> to prevent non-deterministic renders This was caused by global state in a 3rd party lib: "react-select". Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Specify id for all <Select /> to satisfy previous commit Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Prevent explicit side effect in component by using existing dependency instead Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Extract instantiation of "conf" as injectables for causing side effects Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Introduce a legacy-helper to make gradual refactoring of inheritors of Singleton easier Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Make legacy unit tests for hotbar green and more simple by using the new legacy helper Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Temporarily kludge all unit tests green with a disclaimer about allowing side-effects Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Remove kludge in previous commit by explicitly permitting specific side effects where old unit tests require it Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Prevent old unit test with side effects from accessing file system Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Migrate to actual typing for di.permitSideEffects Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Prevent unit tests from failing because of non-standard method of HTML-element not present in js-dom Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Adapt integration tests to recent changes Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Fix code style Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Fix artifact from bad rebase Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Add a deprecation from a review comment Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Remove change that is not required Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove redundant comment Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix code style Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove redundant file Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix bad merge Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Improve variable name Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Tweak logger interface to be more descriptive Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make injecting legacy singleton always provide new instance Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove conditional typing when not needed Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Improve naming of variable Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove unnecessary code style changes Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove flag for causing side effects from too broad scope Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Override side-effects in unit test using injectable instead of monkey patching Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Flag some side-effects and add general overrides Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Fix unit tests in CI by removing explicit side-effect Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Remove explicit side-effect from getting default shell Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Introduce abstraction for getting absolute paths Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using abstraction for getting absolute path to control explicit side effect Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Introduce abstraction for joining paths Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using abstraction for joining paths to control explicit side effect Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix fake implementation for join paths Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix test after removing explicit side effect Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove explicit side effects from kubeconfig-syncs Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix arguments after removing explicit side effect Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make registrators not async for not being needed anymore Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make generalCatalogEntities non-observable, as there is no requirement Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Remove redundant code Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Simplify logic for registering general catalog entity sources Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Add TODO Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Replace function for getting application menu items with reactive solution Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix typo in interface name Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove global shared state usages of hot bar store Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove redundant enum Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
218 lines
5.7 KiB
TypeScript
218 lines
5.7 KiB
TypeScript
/**
|
|
* Copyright (c) OpenLens Authors. All rights reserved.
|
|
* Licensed under MIT License. See LICENSE in root directory for more information.
|
|
*/
|
|
import { withInjectables } from "@ogre-tools/injectable-react";
|
|
import fse from "fs-extra";
|
|
import { computed, makeObservable, observable, reaction } from "mobx";
|
|
import { disposeOnUnmount, observer } from "mobx-react";
|
|
import React from "react";
|
|
import { Notice } from "../+extensions/notice";
|
|
import type { KubeconfigSyncEntry, KubeconfigSyncValue, UserStore } from "../../../common/user-store";
|
|
import { iter, tuple } from "../../utils";
|
|
import { SubTitle } from "../layout/sub-title";
|
|
import { PathPicker } from "../path-picker/path-picker";
|
|
import { Spinner } from "../spinner";
|
|
import { RemovableItem } from "./removable-item";
|
|
import userStoreInjectable from "../../../common/user-store/user-store.injectable";
|
|
import isWindowsInjectable from "../../../common/vars/is-windows.injectable";
|
|
import loggerInjectable from "../../../common/logger.injectable";
|
|
import type { Logger } from "../../../common/logger";
|
|
|
|
interface SyncInfo {
|
|
type: "file" | "folder" | "unknown";
|
|
}
|
|
|
|
interface Entry extends Value {
|
|
filePath: string;
|
|
}
|
|
|
|
interface Value {
|
|
data: KubeconfigSyncValue;
|
|
info: SyncInfo;
|
|
}
|
|
|
|
async function getMapEntry({ filePath, ...data }: KubeconfigSyncEntry, logger: Logger): Promise<[string, Value]> {
|
|
try {
|
|
// stat follows the stat(2) linux syscall spec, namely it follows symlinks
|
|
const stats = await fse.stat(filePath);
|
|
|
|
if (stats.isFile()) {
|
|
return [filePath, { info: { type: "file" }, data }];
|
|
}
|
|
|
|
if (stats.isDirectory()) {
|
|
return [filePath, { info: { type: "folder" }, data }];
|
|
}
|
|
|
|
logger.warn("[KubeconfigSyncs]: unknown stat entry", { stats });
|
|
|
|
return [filePath, { info: { type: "unknown" }, data }];
|
|
} catch (error) {
|
|
logger.warn(`[KubeconfigSyncs]: failed to stat entry: ${error}`, { error });
|
|
|
|
return [filePath, { info: { type: "unknown" }, data }];
|
|
}
|
|
}
|
|
|
|
export async function getAllEntries(filePaths: string[], logger: Logger): Promise<[string, Value][]> {
|
|
return Promise.all(filePaths.map(filePath => getMapEntry({ filePath }, logger)));
|
|
}
|
|
|
|
interface Dependencies {
|
|
userStore: UserStore;
|
|
isWindows: boolean;
|
|
logger: Logger;
|
|
}
|
|
|
|
@observer
|
|
class NonInjectedKubeconfigSyncs extends React.Component<Dependencies> {
|
|
syncs = observable.map<string, Value>();
|
|
@observable loaded = false;
|
|
|
|
constructor(props: Dependencies) {
|
|
super(props);
|
|
makeObservable(this);
|
|
}
|
|
|
|
async componentDidMount() {
|
|
const mapEntries = await Promise.all(
|
|
iter.map(
|
|
this.props.userStore.syncKubeconfigEntries,
|
|
([filePath, ...value]) => getMapEntry({ filePath, ...value }, this.props.logger),
|
|
),
|
|
);
|
|
|
|
this.syncs.replace(mapEntries);
|
|
this.loaded = true;
|
|
|
|
disposeOnUnmount(this, [
|
|
reaction(
|
|
() => Array.from(this.syncs.entries(), ([filePath, { data }]) => tuple.from(filePath, data)),
|
|
syncs => {
|
|
this.props.userStore.syncKubeconfigEntries.replace(syncs);
|
|
},
|
|
),
|
|
]);
|
|
}
|
|
|
|
@computed get syncsList(): Entry[] | undefined {
|
|
if (!this.loaded) {
|
|
return undefined;
|
|
}
|
|
|
|
return Array.from(this.syncs.entries(), ([filePath, value]) => ({ filePath, ...value }));
|
|
}
|
|
|
|
onPick = async (filePaths: string[]) => {
|
|
this.syncs.merge(await getAllEntries(filePaths, this.props.logger));
|
|
};
|
|
|
|
getIconName(entry: Entry) {
|
|
switch (entry.info.type) {
|
|
case "file":
|
|
return "description";
|
|
case "folder":
|
|
return "folder";
|
|
case "unknown":
|
|
return "help_outline";
|
|
}
|
|
}
|
|
|
|
renderEntry = (entry: Entry) => {
|
|
return (
|
|
<RemovableItem
|
|
key={entry.filePath}
|
|
onRemove={() => this.syncs.delete(entry.filePath)}
|
|
className="mt-3"
|
|
icon={this.getIconName(entry)}
|
|
>
|
|
<div className="flex-grow break-all">
|
|
{entry.filePath}
|
|
</div>
|
|
</RemovableItem>
|
|
);
|
|
};
|
|
|
|
renderEntries() {
|
|
const entries = this.syncsList;
|
|
|
|
if (!entries) {
|
|
return (
|
|
<div className="loading-spinner">
|
|
<Spinner />
|
|
</div>
|
|
);
|
|
}
|
|
|
|
if (!entries.length) {
|
|
return (
|
|
<Notice className="mt-3">
|
|
<div className="flex-grow text-center">No files and folders have been synced yet</div>
|
|
</Notice>
|
|
);
|
|
}
|
|
|
|
return (
|
|
<div>
|
|
{entries.map(this.renderEntry)}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
renderSyncButtons() {
|
|
if (this.props.isWindows) {
|
|
return (
|
|
<div className="flex gaps align-center mb-5">
|
|
<PathPicker
|
|
label="Sync file(s)"
|
|
onPick={this.onPick}
|
|
buttonLabel="Sync"
|
|
properties={["showHiddenFiles", "multiSelections", "openFile"]}
|
|
/>
|
|
<span>or</span>
|
|
<PathPicker
|
|
label="Sync folder(s)"
|
|
onPick={this.onPick}
|
|
buttonLabel="Sync"
|
|
properties={["showHiddenFiles", "multiSelections", "openDirectory"]}
|
|
/>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
return (
|
|
<div className="self-start mb-5">
|
|
<PathPicker
|
|
label="Sync Files and Folders"
|
|
onPick={this.onPick}
|
|
buttonLabel="Sync"
|
|
properties={["showHiddenFiles", "multiSelections", "openFile", "openDirectory"]}
|
|
/>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
render() {
|
|
return (
|
|
<>
|
|
{this.renderSyncButtons()}
|
|
<SubTitle title="Synced Items" className="pt-5"/>
|
|
{this.renderEntries()}
|
|
</>
|
|
);
|
|
}
|
|
}
|
|
|
|
export const KubeconfigSyncs = withInjectables<Dependencies>(
|
|
NonInjectedKubeconfigSyncs,
|
|
|
|
{
|
|
getProps: (di) => ({
|
|
userStore: di.inject(userStoreInjectable),
|
|
isWindows: di.inject(isWindowsInjectable),
|
|
logger: di.inject(loggerInjectable),
|
|
}),
|
|
},
|
|
);
|