mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
8db9251718
- Correctly handle the case where `undefined` is returned by the fetch because of a 403: Unauthorized being returned from the Kube Api due to only having list permissions in some of the namespaces - Fix rendering of Pod Secrets in the details view to handle correctly the case where the user doesn't have list or get secrets permissions - Remove CancelablePromise<T> as it was only used in one place and the return types where wrong causing a crash while debugging the above. - Move HelmChartDetails to create its own AbortController for cancelling its request itself as that was the only instance of the cancel() method being called - Significantly improve the typing of `isJsonApiData` and `isJsonApiDataList` so that they actually make sure that the form of the data matches the assertion they make. This also removes a crash from incorrectly assuming that `any` could not be `undefined`. - Add tests for the above two functions - Significantly improve the readability of the isKubeJson* functions - add doc comments for `ItemStore.prototype.sortItems` - add many more helper functions for type narrowing - Add some more handling of error cases with RBAC - Add notifications when errors occur (which leave lists in the loading state) - properly set response codes when an error occurs for listing helm releases - support kube API 1.20 with now optional selfLink - fix KubeObjectStore.subscribe not waiting for the corisponding load to occur Signed-off-by: Sebastian Malton <sebastian@malton.name>
229 lines
11 KiB
TypeScript
229 lines
11 KiB
TypeScript
import { KubeObject } from "../kube-object";
|
|
|
|
describe("KubeObject", () => {
|
|
describe("isJsonApiData", () => {
|
|
{
|
|
type TestCase = [any];
|
|
const tests: TestCase[] = [
|
|
[false],
|
|
[true],
|
|
[null],
|
|
[undefined],
|
|
[""],
|
|
[1],
|
|
[(): unknown => void 0],
|
|
[Symbol("hello")],
|
|
[{}],
|
|
];
|
|
|
|
it.each(tests)("should reject invalid value: %p", (input) => {
|
|
expect(KubeObject.isJsonApiData(input)).toBe(false);
|
|
});
|
|
}
|
|
|
|
{
|
|
type TestCase = [string, any];
|
|
const tests: TestCase[] = [
|
|
["kind", { apiVersion: "", metadata: {uid: "", name: "", resourceVersion: "", selfLink: ""} }],
|
|
["apiVersion", { kind: "", metadata: {uid: "", name: "", resourceVersion: "", selfLink: ""} }],
|
|
["metadata", { kind: "", apiVersion: "" }],
|
|
["metadata.uid", { kind: "", apiVersion: "", metadata: { name: "", resourceVersion: "", selfLink: ""} }],
|
|
["metadata.name", { kind: "", apiVersion: "", metadata: { uid: "", resourceVersion: "", selfLink: "" } }],
|
|
["metadata.resourceVersion", { kind: "", apiVersion: "", metadata: { uid: "", name: "", selfLink: "" } }],
|
|
];
|
|
|
|
it.each(tests)("should reject with missing: %s", (missingField, input) => {
|
|
expect(KubeObject.isJsonApiData(input)).toBe(false);
|
|
});
|
|
}
|
|
|
|
{
|
|
type TestCase = [string, any];
|
|
const tests: TestCase[] = [
|
|
["kind", { kind: 1, apiVersion: "", metadata: {} }],
|
|
["apiVersion", { apiVersion: 1, kind: "", metadata: {} }],
|
|
["metadata", { kind: "", apiVersion: "", metadata: "" }],
|
|
["metadata.uid", { kind: "", apiVersion: "", metadata: { uid: 1 } }],
|
|
["metadata.name", { kind: "", apiVersion: "", metadata: { uid: "", name: 1 } }],
|
|
["metadata.resourceVersion", { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: 1 } }],
|
|
["metadata.selfLink", { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: 1 } }],
|
|
["metadata.namespace", { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "", namespace: 1 } }],
|
|
["metadata.creationTimestamp", { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "", creationTimestamp: 1 } }],
|
|
["metadata.continue", { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "", continue: 1 } }],
|
|
["metadata.finalizers", { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "", finalizers: 1 } }],
|
|
["metadata.finalizers", { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "", finalizers: [1] } }],
|
|
["metadata.finalizers", { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "", finalizers: {} } }],
|
|
["metadata.labels", { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "", labels: 1 } }],
|
|
["metadata.labels", { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "", labels: { food: 1 } } }],
|
|
["metadata.annotations", { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "", annotations: 1 } }],
|
|
["metadata.annotations", { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "", annotations: { food: 1 } } }],
|
|
];
|
|
|
|
it.each(tests)("should reject with wrong type for field: %s", (missingField, input) => {
|
|
expect(KubeObject.isJsonApiData(input)).toBe(false);
|
|
});
|
|
}
|
|
|
|
it("should accept valid KubeJsonApiData (ignoring other fields)", () => {
|
|
const valid = { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "", annotations: { food: "" } } };
|
|
|
|
expect(KubeObject.isJsonApiData(valid)).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe("isPartialJsonApiData", () => {
|
|
{
|
|
type TestCase = [any];
|
|
const tests: TestCase[] = [
|
|
[false],
|
|
[true],
|
|
[null],
|
|
[undefined],
|
|
[""],
|
|
[1],
|
|
[(): unknown => void 0],
|
|
[Symbol("hello")],
|
|
];
|
|
|
|
it.each(tests)("should reject invalid value: %p", (input) => {
|
|
expect(KubeObject.isPartialJsonApiData(input)).toBe(false);
|
|
});
|
|
}
|
|
|
|
it("should accept {}", () => {
|
|
expect(KubeObject.isPartialJsonApiData({})).toBe(true);
|
|
});
|
|
|
|
{
|
|
type TestCase = [string, any];
|
|
const tests: TestCase[] = [
|
|
["kind", { apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "" } }],
|
|
["apiVersion", { kind: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "" } }],
|
|
["metadata", { kind: "", apiVersion: "" }],
|
|
];
|
|
|
|
it.each(tests)("should not reject with missing top level field: %s", (missingField, input) => {
|
|
expect(KubeObject.isPartialJsonApiData(input)).toBe(true);
|
|
});
|
|
}
|
|
|
|
{
|
|
type TestCase = [string, any];
|
|
const tests: TestCase[] = [
|
|
["metadata.uid", { kind: "", apiVersion: "", metadata: { name: "", resourceVersion: "", selfLink: ""} }],
|
|
["metadata.name", { kind: "", apiVersion: "", metadata: { uid: "", resourceVersion: "", selfLink: "" } }],
|
|
["metadata.resourceVersion", { kind: "", apiVersion: "", metadata: { uid: "", name: "", selfLink: "" } }],
|
|
];
|
|
|
|
it.each(tests)("should reject with missing non-top level field: %s", (missingField, input) => {
|
|
expect(KubeObject.isPartialJsonApiData(input)).toBe(false);
|
|
});
|
|
}
|
|
|
|
{
|
|
type TestCase = [string, any];
|
|
const tests: TestCase[] = [
|
|
["kind", { kind: 1, apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "" } }],
|
|
["apiVersion", { apiVersion: 1, kind: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "" } }],
|
|
["metadata", { kind: "", apiVersion: "", metadata: "" }],
|
|
["metadata.uid", { kind: "", apiVersion: "", metadata: { uid: 1, name: "", resourceVersion: "", selfLink: "" } }],
|
|
["metadata.name", { kind: "", apiVersion: "", metadata: { uid: "", name: 1, resourceVersion: "", selfLink: "" } }],
|
|
["metadata.resourceVersion", { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: 1, selfLink: "" } }],
|
|
["metadata.selfLink", { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: 1 } }],
|
|
["metadata.namespace", { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "", namespace: 1 } }],
|
|
["metadata.creationTimestamp", { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "", creationTimestamp: 1 } }],
|
|
["metadata.continue", { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "", continue: 1 } }],
|
|
["metadata.finalizers", { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "", finalizers: 1 } }],
|
|
["metadata.finalizers", { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "", finalizers: [1] } }],
|
|
["metadata.finalizers", { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "", finalizers: {} } }],
|
|
["metadata.labels", { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "", labels: 1 } }],
|
|
["metadata.labels", { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "", labels: { food: 1 } } }],
|
|
["metadata.annotations", { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "", annotations: 1 } }],
|
|
["metadata.annotations", { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "", annotations: { food: 1 } } }],
|
|
];
|
|
|
|
it.each(tests)("should reject with wrong type for field: %s", (missingField, input) => {
|
|
expect(KubeObject.isPartialJsonApiData(input)).toBe(false);
|
|
});
|
|
}
|
|
|
|
it("should accept valid Partial<KubeJsonApiData> (ignoring other fields)", () => {
|
|
const valid = { kind: "", apiVersion: "", metadata: { uid: "", name: "", resourceVersion: "", selfLink: "", annotations: { food: "" } } };
|
|
|
|
expect(KubeObject.isPartialJsonApiData(valid)).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe("isJsonApiDataList", () => {
|
|
function isAny(val: unknown): val is any {
|
|
return !Boolean(void val);
|
|
}
|
|
|
|
function isNotAny(val: unknown): val is any {
|
|
return Boolean(void val);
|
|
}
|
|
|
|
function isBoolean(val: unknown): val is Boolean {
|
|
return typeof val === "boolean";
|
|
}
|
|
|
|
{
|
|
type TestCase = [any];
|
|
const tests: TestCase[] = [
|
|
[false],
|
|
[true],
|
|
[null],
|
|
[undefined],
|
|
[""],
|
|
[1],
|
|
[(): unknown => void 0],
|
|
[Symbol("hello")],
|
|
[{}],
|
|
];
|
|
|
|
it.each(tests)("should reject invalid value: %p", (input) => {
|
|
expect(KubeObject.isJsonApiDataList(input, isAny)).toBe(false);
|
|
});
|
|
}
|
|
|
|
{
|
|
type TestCase = [string, any];
|
|
const tests: TestCase[] = [
|
|
["kind", { apiVersion: "", items: [], metadata: { resourceVersion: "", selfLink: "" } }],
|
|
["apiVersion", { kind: "", items: [], metadata: { resourceVersion: "", selfLink: "" } }],
|
|
["metadata", { kind: "", items: [], apiVersion: "" }],
|
|
["metadata.resourceVersion", { kind: "", items: [], apiVersion: "", metadata: { selfLink: "" } }],
|
|
];
|
|
|
|
it.each(tests)("should reject with missing: %s", (missingField, input) => {
|
|
expect(KubeObject.isJsonApiDataList(input, isAny)).toBe(false);
|
|
});
|
|
}
|
|
|
|
{
|
|
type TestCase = [string, any];
|
|
const tests: TestCase[] = [
|
|
["kind", { kind: 1, items: [], apiVersion: "", metadata: { resourceVersion: "", selfLink: "" } }],
|
|
["apiVersion", { kind: "", items: [], apiVersion: 1, metadata: { resourceVersion: "", selfLink: "" } }],
|
|
["metadata", { kind: "", items: [], apiVersion: "", metadata: 1 }],
|
|
["metadata.resourceVersion", { kind: "", items: [], apiVersion: "", metadata: { resourceVersion: 1, selfLink: "" } }],
|
|
["metadata.selfLink", { kind: "", items: [], apiVersion: "", metadata: { resourceVersion: "", selfLink: 1 } }],
|
|
["items", { kind: "", items: 1, apiVersion: "", metadata: { resourceVersion: "", selfLink: "" } }],
|
|
["items", { kind: "", items: "", apiVersion: "", metadata: { resourceVersion: "", selfLink: "" } }],
|
|
["items", { kind: "", items: {}, apiVersion: "", metadata: { resourceVersion: "", selfLink: "" } }],
|
|
["items[0]", { kind: "", items: [""], apiVersion: "", metadata: { resourceVersion: "", selfLink: "" } }],
|
|
];
|
|
|
|
it.each(tests)("should reject with wrong type for field: %s", (missingField, input) => {
|
|
expect(KubeObject.isJsonApiDataList(input, isNotAny)).toBe(false);
|
|
});
|
|
}
|
|
|
|
it("should accept valid KubeJsonApiDataList (ignoring other fields)", () => {
|
|
const valid = { kind: "", items: [false], apiVersion: "", metadata: { resourceVersion: "", selfLink: "" } };
|
|
|
|
expect(KubeObject.isJsonApiDataList(valid, isBoolean)).toBe(true);
|
|
});
|
|
});
|
|
});
|