mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
* Implement a lot of technical requirements for behavioural unit tests Note: the crux of this was to make routing env-agnostic, and not based on URLs as magic strings, but instead something type-enforced. Note: extension-based routes comply to same exact interface by "late-registering" their routes when installed. Routes are just injectables. Note: another chunk of global shared state is no more. Note: a lot of explicit side effects have been cornered to injectables. Note: a lot of stuff has become reactive as part if this. Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make a directory commonly available Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Require id for <Select /> to prevent non-deterministic renders This was caused by global state in a 3rd party lib: "react-select". Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Specify id for all <Select /> to satisfy previous commit Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Prevent explicit side effect in component by using existing dependency instead Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Extract instantiation of "conf" as injectables for causing side effects Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Introduce a legacy-helper to make gradual refactoring of inheritors of Singleton easier Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Make legacy unit tests for hotbar green and more simple by using the new legacy helper Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Temporarily kludge all unit tests green with a disclaimer about allowing side-effects Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Remove kludge in previous commit by explicitly permitting specific side effects where old unit tests require it Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Prevent old unit test with side effects from accessing file system Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Migrate to actual typing for di.permitSideEffects Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Prevent unit tests from failing because of non-standard method of HTML-element not present in js-dom Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Adapt integration tests to recent changes Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Fix code style Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Fix artifact from bad rebase Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Add a deprecation from a review comment Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Remove change that is not required Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove redundant comment Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix code style Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove redundant file Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix bad merge Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Improve variable name Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Tweak logger interface to be more descriptive Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make injecting legacy singleton always provide new instance Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove conditional typing when not needed Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Improve naming of variable Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove unnecessary code style changes Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove flag for causing side effects from too broad scope Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Override side-effects in unit test using injectable instead of monkey patching Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Flag some side-effects and add general overrides Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Fix unit tests in CI by removing explicit side-effect Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Remove explicit side-effect from getting default shell Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Introduce abstraction for getting absolute paths Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using abstraction for getting absolute path to control explicit side effect Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Introduce abstraction for joining paths Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using abstraction for joining paths to control explicit side effect Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix fake implementation for join paths Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix test after removing explicit side effect Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove explicit side effects from kubeconfig-syncs Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix arguments after removing explicit side effect Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make registrators not async for not being needed anymore Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make generalCatalogEntities non-observable, as there is no requirement Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Remove redundant code Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Simplify logic for registering general catalog entity sources Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Add TODO Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Replace function for getting application menu items with reactive solution Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix typo in interface name Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove global shared state usages of hot bar store Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove redundant enum Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
133 lines
3.5 KiB
TypeScript
133 lines
3.5 KiB
TypeScript
/**
|
|
* Copyright (c) OpenLens Authors. All rights reserved.
|
|
* Licensed under MIT License. See LICENSE in root directory for more information.
|
|
*/
|
|
|
|
import path from "path";
|
|
import packageInfo from "../../../package.json";
|
|
import { Menu, Tray } from "electron";
|
|
import { autorun, IComputedValue } from "mobx";
|
|
import { showAbout } from "../menu/menu";
|
|
import { checkForUpdates, isAutoUpdateEnabled } from "../app-updater";
|
|
import type { WindowManager } from "../window-manager";
|
|
import logger from "../logger";
|
|
import { isDevelopment, isWindows, productName } from "../../common/vars";
|
|
import { exitApp } from "../exit-app";
|
|
import { toJS } from "../../common/utils";
|
|
import type { TrayMenuRegistration } from "./tray-menu-registration";
|
|
|
|
|
|
const TRAY_LOG_PREFIX = "[TRAY]";
|
|
|
|
// note: instance of Tray should be saved somewhere, otherwise it disappears
|
|
export let tray: Tray;
|
|
|
|
export function getTrayIcon(): string {
|
|
return path.resolve(
|
|
__static,
|
|
isDevelopment ? "../build/tray" : "icons", // copied within electron-builder extras
|
|
"trayIconTemplate.png",
|
|
);
|
|
}
|
|
|
|
export function initTray(
|
|
windowManager: WindowManager,
|
|
trayMenuItems: IComputedValue<TrayMenuRegistration[]>,
|
|
navigateToPreferences: () => void,
|
|
) {
|
|
const icon = getTrayIcon();
|
|
|
|
tray = new Tray(icon);
|
|
tray.setToolTip(packageInfo.description);
|
|
tray.setIgnoreDoubleClickEvents(true);
|
|
|
|
if (isWindows) {
|
|
tray.on("click", () => {
|
|
windowManager
|
|
.ensureMainWindow()
|
|
.catch(error => logger.error(`${TRAY_LOG_PREFIX}: Failed to open lens`, { error }));
|
|
});
|
|
}
|
|
|
|
const disposers = [
|
|
autorun(() => {
|
|
try {
|
|
const menu = createTrayMenu(windowManager, toJS(trayMenuItems.get()), navigateToPreferences);
|
|
|
|
tray.setContextMenu(menu);
|
|
} catch (error) {
|
|
logger.error(`${TRAY_LOG_PREFIX}: building failed`, { error });
|
|
}
|
|
}),
|
|
];
|
|
|
|
return () => {
|
|
disposers.forEach(disposer => disposer());
|
|
tray?.destroy();
|
|
tray = null;
|
|
};
|
|
}
|
|
|
|
function getMenuItemConstructorOptions(trayItem: TrayMenuRegistration): Electron.MenuItemConstructorOptions {
|
|
return {
|
|
...trayItem,
|
|
submenu: trayItem.submenu ? trayItem.submenu.map(getMenuItemConstructorOptions) : undefined,
|
|
click: trayItem.click ? () => {
|
|
trayItem.click(trayItem);
|
|
} : undefined,
|
|
};
|
|
}
|
|
|
|
function createTrayMenu(
|
|
windowManager: WindowManager,
|
|
extensionTrayItems: TrayMenuRegistration[],
|
|
navigateToPreferences: () => void,
|
|
): Menu {
|
|
let template: Electron.MenuItemConstructorOptions[] = [
|
|
{
|
|
label: `Open ${productName}`,
|
|
click() {
|
|
windowManager
|
|
.ensureMainWindow()
|
|
.catch(error => logger.error(`${TRAY_LOG_PREFIX}: Failed to open lens`, { error }));
|
|
},
|
|
},
|
|
{
|
|
label: "Preferences",
|
|
click() {
|
|
navigateToPreferences();
|
|
},
|
|
},
|
|
];
|
|
|
|
if (isAutoUpdateEnabled()) {
|
|
template.push({
|
|
label: "Check for updates",
|
|
click() {
|
|
checkForUpdates()
|
|
.then(() => windowManager.ensureMainWindow());
|
|
},
|
|
});
|
|
}
|
|
|
|
template = template.concat(extensionTrayItems.map(getMenuItemConstructorOptions));
|
|
|
|
return Menu.buildFromTemplate(template.concat([
|
|
{
|
|
label: `About ${productName}`,
|
|
click() {
|
|
windowManager.ensureMainWindow()
|
|
.then(showAbout)
|
|
.catch(error => logger.error(`${TRAY_LOG_PREFIX}: Failed to show Lens About view`, { error }));
|
|
},
|
|
},
|
|
{ type: "separator" },
|
|
{
|
|
label: "Quit App",
|
|
click() {
|
|
exitApp();
|
|
},
|
|
},
|
|
]));
|
|
}
|