mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
* Implement a lot of technical requirements for behavioural unit tests Note: the crux of this was to make routing env-agnostic, and not based on URLs as magic strings, but instead something type-enforced. Note: extension-based routes comply to same exact interface by "late-registering" their routes when installed. Routes are just injectables. Note: another chunk of global shared state is no more. Note: a lot of explicit side effects have been cornered to injectables. Note: a lot of stuff has become reactive as part if this. Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make a directory commonly available Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Require id for <Select /> to prevent non-deterministic renders This was caused by global state in a 3rd party lib: "react-select". Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Specify id for all <Select /> to satisfy previous commit Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Prevent explicit side effect in component by using existing dependency instead Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Extract instantiation of "conf" as injectables for causing side effects Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Introduce a legacy-helper to make gradual refactoring of inheritors of Singleton easier Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Make legacy unit tests for hotbar green and more simple by using the new legacy helper Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Temporarily kludge all unit tests green with a disclaimer about allowing side-effects Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Remove kludge in previous commit by explicitly permitting specific side effects where old unit tests require it Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Prevent old unit test with side effects from accessing file system Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Migrate to actual typing for di.permitSideEffects Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Prevent unit tests from failing because of non-standard method of HTML-element not present in js-dom Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Adapt integration tests to recent changes Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Fix code style Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Fix artifact from bad rebase Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Add a deprecation from a review comment Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Remove change that is not required Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove redundant comment Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix code style Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove redundant file Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix bad merge Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Improve variable name Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Tweak logger interface to be more descriptive Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make injecting legacy singleton always provide new instance Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove conditional typing when not needed Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Improve naming of variable Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove unnecessary code style changes Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove flag for causing side effects from too broad scope Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Override side-effects in unit test using injectable instead of monkey patching Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Flag some side-effects and add general overrides Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Fix unit tests in CI by removing explicit side-effect Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Remove explicit side-effect from getting default shell Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Introduce abstraction for getting absolute paths Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using abstraction for getting absolute path to control explicit side effect Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Introduce abstraction for joining paths Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using abstraction for joining paths to control explicit side effect Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix fake implementation for join paths Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix test after removing explicit side effect Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove explicit side effects from kubeconfig-syncs Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix arguments after removing explicit side effect Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make registrators not async for not being needed anymore Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make generalCatalogEntities non-observable, as there is no requirement Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Remove redundant code Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Simplify logic for registering general catalog entity sources Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Add TODO Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Replace function for getting application menu items with reactive solution Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix typo in interface name Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove global shared state usages of hot bar store Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove redundant enum Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
223 lines
7.0 KiB
TypeScript
223 lines
7.0 KiB
TypeScript
/**
|
|
* Copyright (c) OpenLens Authors. All rights reserved.
|
|
* Licensed under MIT License. See LICENSE in root directory for more information.
|
|
*/
|
|
|
|
import "./events.scss";
|
|
|
|
import React, { Fragment } from "react";
|
|
import { computed, observable, makeObservable } from "mobx";
|
|
import { observer } from "mobx-react";
|
|
import { orderBy } from "lodash";
|
|
import { TabLayout } from "../layout/tab-layout-2";
|
|
import { EventStore, eventStore } from "./event.store";
|
|
import { KubeObjectListLayout, KubeObjectListLayoutProps } from "../kube-object-list-layout";
|
|
import type { KubeEvent } from "../../../common/k8s-api/endpoints/events.api";
|
|
import type { TableSortCallbacks, TableSortParams } from "../table";
|
|
import type { HeaderCustomizer } from "../item-object-list";
|
|
import { Tooltip } from "../tooltip";
|
|
import { Link } from "react-router-dom";
|
|
import { cssNames, IClassName, stopPropagation } from "../../utils";
|
|
import { Icon } from "../icon";
|
|
import { getDetailsUrl } from "../kube-detail-params";
|
|
import { apiManager } from "../../../common/k8s-api/api-manager";
|
|
import { withInjectables } from "@ogre-tools/injectable-react";
|
|
import navigateToEventsInjectable from "../../../common/front-end-routing/routes/cluster/events/navigate-to-events.injectable";
|
|
import { KubeObjectAge } from "../kube-object/age";
|
|
import { ReactiveDuration } from "../duration/reactive-duration";
|
|
|
|
enum columnId {
|
|
message = "message",
|
|
namespace = "namespace",
|
|
object = "object",
|
|
type = "type",
|
|
count = "count",
|
|
source = "source",
|
|
age = "age",
|
|
lastSeen = "last-seen",
|
|
}
|
|
|
|
export interface EventsProps extends Partial<KubeObjectListLayoutProps<KubeEvent>> {
|
|
className?: IClassName;
|
|
compact?: boolean;
|
|
compactLimit?: number;
|
|
}
|
|
|
|
const defaultProps: Partial<EventsProps> = {
|
|
compactLimit: 10,
|
|
};
|
|
|
|
interface Dependencies {
|
|
navigateToEvents: () => void;
|
|
}
|
|
|
|
@observer
|
|
class NonInjectedEvents extends React.Component<Dependencies & EventsProps> {
|
|
static defaultProps = defaultProps as object;
|
|
|
|
@observable sorting: TableSortParams = {
|
|
sortBy: columnId.age,
|
|
orderBy: "asc",
|
|
};
|
|
|
|
private sortingCallbacks: TableSortCallbacks<KubeEvent> = {
|
|
[columnId.namespace]: event => event.getNs(),
|
|
[columnId.type]: event => event.type,
|
|
[columnId.object]: event => event.involvedObject.name,
|
|
[columnId.count]: event => event.count,
|
|
[columnId.age]: event => -event.getCreationTimestamp(),
|
|
[columnId.lastSeen]: event => -new Date(event.lastTimestamp).getTime(),
|
|
};
|
|
|
|
constructor(props: Dependencies & EventsProps) {
|
|
super(props);
|
|
makeObservable(this);
|
|
}
|
|
|
|
get store(): EventStore {
|
|
return eventStore;
|
|
}
|
|
|
|
@computed get items(): KubeEvent[] {
|
|
const items = this.store.contextItems;
|
|
const { sortBy, orderBy: order } = this.sorting;
|
|
|
|
// we must sort items before passing to "KubeObjectListLayout -> Table"
|
|
// to make it work with "compact=true" (proper table sorting actions + initial items)
|
|
return orderBy(items, this.sortingCallbacks[sortBy], order as any);
|
|
}
|
|
|
|
@computed get visibleItems(): KubeEvent[] {
|
|
const { compact, compactLimit } = this.props;
|
|
|
|
if (compact) {
|
|
return this.items.slice(0, compactLimit);
|
|
}
|
|
|
|
return this.items;
|
|
}
|
|
|
|
customizeHeader: HeaderCustomizer = ({ info, title, ...headerPlaceholders }) => {
|
|
const { compact } = this.props;
|
|
const { store, items, visibleItems } = this;
|
|
const allEventsAreShown = visibleItems.length === items.length;
|
|
|
|
// handle "compact"-mode header
|
|
if (compact) {
|
|
if (allEventsAreShown) {
|
|
return { title };
|
|
}
|
|
|
|
return {
|
|
title,
|
|
info: <span> ({visibleItems.length} of <a onClick={this.props.navigateToEvents}>{items.length}</a>)</span>,
|
|
};
|
|
}
|
|
|
|
return {
|
|
info: <>
|
|
{info}
|
|
<Icon
|
|
small
|
|
material="help_outline"
|
|
className="help-icon"
|
|
tooltip={`Limited to ${store.limit}`}
|
|
/>
|
|
</>,
|
|
title,
|
|
...headerPlaceholders,
|
|
};
|
|
};
|
|
|
|
render() {
|
|
const { store } = this;
|
|
const { compact, compactLimit, className, ...layoutProps } = this.props;
|
|
|
|
const events = (
|
|
<KubeObjectListLayout
|
|
{...layoutProps}
|
|
isConfigurable
|
|
tableId="events"
|
|
store={store}
|
|
className={cssNames("Events", className, { compact })}
|
|
renderHeaderTitle="Events"
|
|
customizeHeader={this.customizeHeader}
|
|
isSelectable={false}
|
|
getItems={() => this.visibleItems}
|
|
virtual={!compact}
|
|
tableProps={{
|
|
sortSyncWithUrl: false,
|
|
sortByDefault: this.sorting,
|
|
onSort: params => this.sorting = params,
|
|
}}
|
|
sortingCallbacks={this.sortingCallbacks}
|
|
searchFilters={[
|
|
event => event.getSearchFields(),
|
|
event => event.message,
|
|
event => event.getSource(),
|
|
event => event.involvedObject.name,
|
|
]}
|
|
renderTableHeader={[
|
|
{ title: "Type", className: "type", sortBy: columnId.type, id: columnId.type },
|
|
{ title: "Message", className: "message", id: columnId.message },
|
|
{ title: "Namespace", className: "namespace", sortBy: columnId.namespace, id: columnId.namespace },
|
|
{ title: "Involved Object", className: "object", sortBy: columnId.object, id: columnId.object },
|
|
{ title: "Source", className: "source", id: columnId.source },
|
|
{ title: "Count", className: "count", sortBy: columnId.count, id: columnId.count },
|
|
{ title: "Age", className: "age", sortBy: columnId.age, id: columnId.age },
|
|
{ title: "Last Seen", className: "last-seen", sortBy: columnId.lastSeen, id: columnId.lastSeen },
|
|
]}
|
|
renderTableContents={event => {
|
|
const { involvedObject, type, message } = event;
|
|
const tooltipId = `message-${event.getId()}`;
|
|
const isWarning = event.isWarning();
|
|
|
|
return [
|
|
type, // type of event: "Normal" or "Warning"
|
|
{
|
|
className: { warning: isWarning },
|
|
title: (
|
|
<Fragment>
|
|
<span id={tooltipId}>{message}</span>
|
|
<Tooltip targetId={tooltipId} formatters={{ narrow: true, warning: isWarning }}>
|
|
{message}
|
|
</Tooltip>
|
|
</Fragment>
|
|
),
|
|
},
|
|
event.getNs(),
|
|
<Link key="link" to={getDetailsUrl(apiManager.lookupApiLink(involvedObject, event))} onClick={stopPropagation}>
|
|
{involvedObject.kind}: {involvedObject.name}
|
|
</Link>,
|
|
event.getSource(),
|
|
event.count,
|
|
<KubeObjectAge key="age" object={event} />,
|
|
<ReactiveDuration key="last-seen" timestamp={event.lastTimestamp} />,
|
|
];
|
|
}}
|
|
/>
|
|
);
|
|
|
|
if (compact) {
|
|
return events;
|
|
}
|
|
|
|
return (
|
|
<TabLayout>
|
|
{events}
|
|
</TabLayout>
|
|
);
|
|
}
|
|
}
|
|
|
|
export const Events = withInjectables<Dependencies, EventsProps>(
|
|
NonInjectedEvents,
|
|
|
|
{
|
|
getProps: (di, props) => ({
|
|
navigateToEvents: di.inject(navigateToEventsInjectable),
|
|
...props,
|
|
}),
|
|
},
|
|
);
|