mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
* Implement a lot of technical requirements for behavioural unit tests Note: the crux of this was to make routing env-agnostic, and not based on URLs as magic strings, but instead something type-enforced. Note: extension-based routes comply to same exact interface by "late-registering" their routes when installed. Routes are just injectables. Note: another chunk of global shared state is no more. Note: a lot of explicit side effects have been cornered to injectables. Note: a lot of stuff has become reactive as part if this. Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make a directory commonly available Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Require id for <Select /> to prevent non-deterministic renders This was caused by global state in a 3rd party lib: "react-select". Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Specify id for all <Select /> to satisfy previous commit Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Prevent explicit side effect in component by using existing dependency instead Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Extract instantiation of "conf" as injectables for causing side effects Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Introduce a legacy-helper to make gradual refactoring of inheritors of Singleton easier Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Make legacy unit tests for hotbar green and more simple by using the new legacy helper Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Temporarily kludge all unit tests green with a disclaimer about allowing side-effects Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Remove kludge in previous commit by explicitly permitting specific side effects where old unit tests require it Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Prevent old unit test with side effects from accessing file system Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Migrate to actual typing for di.permitSideEffects Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Prevent unit tests from failing because of non-standard method of HTML-element not present in js-dom Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Adapt integration tests to recent changes Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Fix code style Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Fix artifact from bad rebase Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Add a deprecation from a review comment Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Remove change that is not required Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove redundant comment Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix code style Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove redundant file Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix bad merge Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Improve variable name Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Tweak logger interface to be more descriptive Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make injecting legacy singleton always provide new instance Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove conditional typing when not needed Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Improve naming of variable Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove unnecessary code style changes Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove flag for causing side effects from too broad scope Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Override side-effects in unit test using injectable instead of monkey patching Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Flag some side-effects and add general overrides Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Fix unit tests in CI by removing explicit side-effect Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Remove explicit side-effect from getting default shell Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Introduce abstraction for getting absolute paths Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using abstraction for getting absolute path to control explicit side effect Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Introduce abstraction for joining paths Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using abstraction for joining paths to control explicit side effect Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix fake implementation for join paths Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix test after removing explicit side effect Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove explicit side effects from kubeconfig-syncs Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix arguments after removing explicit side effect Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make registrators not async for not being needed anymore Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make generalCatalogEntities non-observable, as there is no requirement Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Remove redundant code Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Simplify logic for registering general catalog entity sources Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Add TODO Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Replace function for getting application menu items with reactive solution Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix typo in interface name Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove global shared state usages of hot bar store Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove redundant enum Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
155 lines
5.3 KiB
TypeScript
155 lines
5.3 KiB
TypeScript
/**
|
|
* Copyright (c) OpenLens Authors. All rights reserved.
|
|
* Licensed under MIT License. See LICENSE in root directory for more information.
|
|
*/
|
|
|
|
import "./kube-object-list-layout.scss";
|
|
|
|
import React from "react";
|
|
import { computed, makeObservable, observable, reaction } from "mobx";
|
|
import { disposeOnUnmount, observer } from "mobx-react";
|
|
import { cssNames, Disposer } from "../../utils";
|
|
import type { KubeObject } from "../../../common/k8s-api/kube-object";
|
|
import { ItemListLayout, ItemListLayoutProps } from "../item-object-list/list-layout";
|
|
import type { KubeObjectStore } from "../../../common/k8s-api/kube-object.store";
|
|
import { KubeObjectMenu } from "../kube-object-menu";
|
|
import { NamespaceSelectFilter } from "../+namespaces/namespace-select-filter";
|
|
import { ResourceKindMap, ResourceNames } from "../../utils/rbac";
|
|
import { kubeSelectedUrlParam, toggleDetails } from "../kube-detail-params";
|
|
import { Icon } from "../icon";
|
|
import { TooltipPosition } from "../tooltip";
|
|
import { withInjectables } from "@ogre-tools/injectable-react";
|
|
import type { ClusterFrameContext } from "../../cluster-frame-context/cluster-frame-context";
|
|
import clusterFrameContextInjectable from "../../cluster-frame-context/cluster-frame-context.injectable";
|
|
import kubeWatchApiInjectable from "../../kube-watch-api/kube-watch-api.injectable";
|
|
import type { KubeWatchSubscribeStoreOptions } from "../../kube-watch-api/kube-watch-api";
|
|
|
|
type ItemListLayoutPropsWithoutGetItems<K extends KubeObject> = Omit<ItemListLayoutProps<K>, "getItems">;
|
|
|
|
export interface KubeObjectListLayoutProps<K extends KubeObject> extends ItemListLayoutPropsWithoutGetItems<K> {
|
|
items?: K[];
|
|
getItems?: () => K[];
|
|
store: KubeObjectStore<K>;
|
|
dependentStores?: KubeObjectStore<KubeObject>[];
|
|
subscribeStores?: boolean;
|
|
}
|
|
|
|
const defaultProps: Partial<KubeObjectListLayoutProps<KubeObject>> = {
|
|
onDetails: (item: KubeObject) => toggleDetails(item.selfLink),
|
|
subscribeStores: true,
|
|
};
|
|
|
|
interface Dependencies {
|
|
clusterFrameContext: ClusterFrameContext;
|
|
subscribeToStores: (stores: KubeObjectStore<KubeObject>[], options: KubeWatchSubscribeStoreOptions) => Disposer;
|
|
}
|
|
|
|
@observer
|
|
class NonInjectedKubeObjectListLayout<K extends KubeObject> extends React.Component<KubeObjectListLayoutProps<K> & Dependencies> {
|
|
static defaultProps = defaultProps as object;
|
|
|
|
constructor(props: KubeObjectListLayoutProps<K> & Dependencies) {
|
|
super(props);
|
|
makeObservable(this);
|
|
}
|
|
|
|
@observable loadErrors: string[] = [];
|
|
|
|
@computed get selectedItem() {
|
|
return this.props.store.getByPath(kubeSelectedUrlParam.get());
|
|
}
|
|
|
|
componentDidMount() {
|
|
const { store, dependentStores = [], subscribeStores } = this.props;
|
|
const stores = Array.from(new Set([store, ...dependentStores]));
|
|
const reactions: Disposer[] = [
|
|
reaction(() => this.props.clusterFrameContext.contextNamespaces.slice(), () => {
|
|
// clear load errors
|
|
this.loadErrors.length = 0;
|
|
}),
|
|
];
|
|
|
|
if (subscribeStores) {
|
|
reactions.push(
|
|
this.props.subscribeToStores(stores, {
|
|
onLoadFailure: error => this.loadErrors.push(String(error)),
|
|
}),
|
|
);
|
|
}
|
|
|
|
disposeOnUnmount(this, reactions);
|
|
}
|
|
|
|
renderLoadErrors() {
|
|
if (this.loadErrors.length === 0) {
|
|
return null;
|
|
}
|
|
|
|
return (
|
|
<Icon
|
|
material="warning"
|
|
className="load-error"
|
|
tooltip={{
|
|
children: (
|
|
<>
|
|
{this.loadErrors.map((error, index) => <p key={index}>{error}</p>)}
|
|
</>
|
|
),
|
|
preferredPositions: TooltipPosition.BOTTOM,
|
|
}}
|
|
/>
|
|
);
|
|
}
|
|
|
|
render() {
|
|
const { className, customizeHeader, store, items, ...layoutProps } = this.props;
|
|
const placeholderString = ResourceNames[ResourceKindMap[store.api.kind]] || store.api.kind;
|
|
|
|
return (
|
|
<ItemListLayout
|
|
className={cssNames("KubeObjectListLayout", className)}
|
|
store={store}
|
|
getItems={() => this.props.items || store.contextItems}
|
|
preloadStores={false} // loading handled in kubeWatchApi.subscribeStores()
|
|
detailsItem={this.selectedItem}
|
|
customizeHeader={[
|
|
({ filters, searchProps, info, ...headerPlaceHolders }) => ({
|
|
filters: (
|
|
<>
|
|
{filters}
|
|
{store.api.isNamespaced && <NamespaceSelectFilter id="kube-object-list-layout-namespace-select-input" />}
|
|
</>
|
|
),
|
|
searchProps: {
|
|
...searchProps,
|
|
placeholder: `Search ${placeholderString}...`,
|
|
},
|
|
info: (
|
|
<>
|
|
{info}
|
|
{this.renderLoadErrors()}
|
|
</>
|
|
),
|
|
...headerPlaceHolders,
|
|
}),
|
|
...[customizeHeader].flat(),
|
|
]}
|
|
renderItemMenu={item => <KubeObjectMenu object={item} />}
|
|
{...layoutProps}
|
|
/>
|
|
);
|
|
}
|
|
}
|
|
|
|
const InjectedKubeObjectListLayout = withInjectables<Dependencies, KubeObjectListLayoutProps<KubeObject>>(NonInjectedKubeObjectListLayout, {
|
|
getProps: (di, props) => ({
|
|
clusterFrameContext: di.inject(clusterFrameContextInjectable),
|
|
subscribeToStores: di.inject(kubeWatchApiInjectable).subscribeStores,
|
|
...props,
|
|
}),
|
|
});
|
|
|
|
export function KubeObjectListLayout<K extends KubeObject>(props: KubeObjectListLayoutProps<K>) {
|
|
return <InjectedKubeObjectListLayout {...props} />;
|
|
}
|