mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
* Making apiBase injectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Convert all of Helm functions to be DI Signed-off-by: Sebastian Malton <sebastian@malton.name> * Make PortForward's use of apiBase fully injectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Convert all metric requests to be injectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Replace resource applier with injectables Signed-off-by: Sebastian Malton <sebastian@malton.name> * Switch KubeJsonApi.forCluster to be injectable but do not use Signed-off-by: Sebastian Malton <sebastian@malton.name> * Convert the rest of shell sessions to be DI-ed - This is a prerequesit for using the new createKubeJsonApiForClusterInjectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Use new createKubeJsonApiForClusterInjectable for openNodeShellSession Signed-off-by: Sebastian Malton <sebastian@malton.name> * Make KubeconfigDialog injectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove jest-fetch-mock and make fetch injectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix tests with new global override Signed-off-by: Sebastian Malton <sebastian@malton.name> * Add new injectable for create KubeJsonApi and JsonApi instances Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix showing-details-for-helm-release behavioural tests - Remove HelmChartStore in favour of all injectables - Create a model for UpgradeChartDockTab Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix show details and updating helm releases tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix residual typing issues related to metrics Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix crash on load due to circular dependency Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix create resource tab not working Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove legacy apiBase global Signed-off-by: Sebastian Malton <sebastian@malton.name> * Introduce and use isDebuggingInjectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Introduce and use windowLocationInjectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove global legacy apiKube Signed-off-by: Sebastian Malton <sebastian@malton.name> * Improve injectable filenames compared to the injectables inside Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove modifying input in requestActivePortForwardInjectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Introduce and use get(Milli)SecondsFromUnixEpochInjectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Switch to non-reactive way of gettting possible helm release versions Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix typo Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix bug in KubeApi constructor Signed-off-by: Sebastian Malton <sebastian@malton.name> * Convert all KubeApi related tests to use asyncFn Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix unit tests after introducing new injectables that have side effects Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix bad rebase causing tests to fail Signed-off-by: Sebastian Malton <sebastian@malton.name> * Improve expects for multiple field values Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix crash will looking up api refs Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix breaking change on KubeApi.list Signed-off-by: Sebastian Malton <sebastian@malton.name> * Better fix for formatting urls Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove injectable for time since we should just use useMockTime Signed-off-by: Sebastian Malton <sebastian@malton.name> * Add happy path behavioural tests for upgrade chart tab Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove debug message Signed-off-by: Sebastian Malton <sebastian@malton.name> * Update snapshots Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix showing-details-for-helm-release tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix installing-helm-chart-from-new-tab tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix tests relating to hosted cluster id Signed-off-by: Sebastian Malton <sebastian@malton.name> * Update snapshots to recent changes in master Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Reupdated upgrade chart new tab test snapshots Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix flakiness in unit test when using <Animated> Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix flakiness and improve tests for DeleteClusterDialog Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix kubeconfig-sync tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix <Extensions> tests by removing mockFs and making everything injectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix build issues Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix getElectronAppPathInjectable override not returning absolute paths - Also fixes the listing-active-helm-repos-in-prefs tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Replace all uses of getAbsolutePath with joinPaths as it is more correct and less confusing Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix opening application window tests by making override properly absolute Signed-off-by: Sebastian Malton <sebastian@malton.name> * Update snapshots relating no longer using getAbsolutePath Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix and add behavioural tests for RenderDelay Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix extension discovery tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix test flakiness because of path side effects, propagate uses to as many places Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix extension-discovery tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Add global override to fix some tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Rewrite and fix implementation of KubeconfigManager and its tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix tests by global override pathExists Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix unit tests failing on windows by using injectable verions of path functions Signed-off-by: Sebastian Malton <sebastian@malton.name> * Attempt to fix test timeout by using runInAction Signed-off-by: Sebastian Malton <sebastian@malton.name> * Update snapshots after rebase Signed-off-by: Sebastian Malton <sebastian@malton.name> * Update snapshots after rebase Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix tests after rebase Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix setupIpcMainHandlers usage Signed-off-by: Sebastian Malton <sebastian@malton.name> * Update snapshots Signed-off-by: Sebastian Malton <sebastian@malton.name> Signed-off-by: Sebastian Malton <sebastian@malton.name> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> Co-authored-by: Iku-turso <mikko.aspiala@gmail.com>
252 lines
9.0 KiB
TypeScript
252 lines
9.0 KiB
TypeScript
/**
|
|
* Copyright (c) OpenLens Authors. All rights reserved.
|
|
* Licensed under MIT License. See LICENSE in root directory for more information.
|
|
*/
|
|
|
|
import type { ApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder";
|
|
import { getApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder";
|
|
import type { AsyncFnMock } from "@async-fn/jest";
|
|
import asyncFn from "@async-fn/jest";
|
|
import type { LensWindow } from "../../main/start-main-application/lens-window/application-window/create-lens-window.injectable";
|
|
import lensResourcesDirInjectable from "../../common/vars/lens-resources-dir.injectable";
|
|
import focusApplicationInjectable from "../../main/electron-app/features/focus-application.injectable";
|
|
import type { CreateElectronWindow } from "../../main/start-main-application/lens-window/application-window/create-electron-window.injectable";
|
|
import createElectronWindowInjectable from "../../main/start-main-application/lens-window/application-window/create-electron-window.injectable";
|
|
import splashWindowInjectable from "../../main/start-main-application/lens-window/splash-window/splash-window.injectable";
|
|
import { runInAction } from "mobx";
|
|
|
|
describe("opening application window using tray", () => {
|
|
describe("given application has started", () => {
|
|
let builder: ApplicationBuilder;
|
|
let createElectronWindowMock: jest.Mock;
|
|
let expectWindowsToBeOpen: (windowIds: string[]) => void;
|
|
let callForSplashWindowHtmlMock: AsyncFnMock<() => Promise<void>>;
|
|
let callForApplicationWindowHtmlMock: AsyncFnMock<() => Promise<void>>;
|
|
let focusApplicationMock: jest.Mock;
|
|
|
|
beforeEach(async () => {
|
|
callForSplashWindowHtmlMock = asyncFn();
|
|
callForApplicationWindowHtmlMock = asyncFn();
|
|
|
|
focusApplicationMock = jest.fn();
|
|
|
|
builder = getApplicationBuilder();
|
|
|
|
builder.beforeApplicationStart((mainDi) => {
|
|
mainDi.override(focusApplicationInjectable, () => focusApplicationMock);
|
|
|
|
mainDi.override(
|
|
lensResourcesDirInjectable,
|
|
() => "/some-lens-resources-directory",
|
|
);
|
|
|
|
const loadFileMock = jest
|
|
.fn(callForSplashWindowHtmlMock)
|
|
.mockImplementationOnce(() => Promise.resolve());
|
|
|
|
const loadUrlMock = jest
|
|
.fn(callForApplicationWindowHtmlMock)
|
|
.mockImplementationOnce(() => Promise.resolve());
|
|
|
|
createElectronWindowMock = jest.fn((toBeDecorated): CreateElectronWindow => (configuration) => {
|
|
const browserWindow = toBeDecorated(configuration);
|
|
|
|
if (configuration.id === "splash") {
|
|
return { ...browserWindow, loadFile: loadFileMock };
|
|
}
|
|
|
|
if (configuration.id === "first-application-window") {
|
|
return { ...browserWindow, loadUrl: loadUrlMock };
|
|
}
|
|
|
|
return browserWindow;
|
|
});
|
|
|
|
runInAction(() => {
|
|
(mainDi as any).decorateFunction(
|
|
createElectronWindowInjectable,
|
|
createElectronWindowMock,
|
|
);
|
|
});
|
|
|
|
expectWindowsToBeOpen = expectWindowsToBeOpenFor(builder);
|
|
});
|
|
|
|
await builder.render();
|
|
});
|
|
|
|
it("only the first application window is open", () => {
|
|
expectWindowsToBeOpen(["first-application-window"]);
|
|
});
|
|
|
|
describe("when an attempt to reopen the already started application is made using tray", () => {
|
|
beforeEach(() => {
|
|
builder.tray.click("open-app");
|
|
});
|
|
|
|
it("still shows only the application window", () => {
|
|
expectWindowsToBeOpen(["first-application-window"]);
|
|
});
|
|
});
|
|
|
|
describe("when the first application window is closed", () => {
|
|
beforeEach(() => {
|
|
const applicationWindow = builder.applicationWindow.only;
|
|
|
|
applicationWindow.close();
|
|
});
|
|
|
|
it("no windows are open", () => {
|
|
expectWindowsToBeOpen([]);
|
|
});
|
|
|
|
describe("when an application window is reopened using tray", () => {
|
|
beforeEach(() => {
|
|
focusApplicationMock.mockClear();
|
|
|
|
callForSplashWindowHtmlMock.mockClear();
|
|
callForApplicationWindowHtmlMock.mockClear();
|
|
|
|
builder.tray.click("open-app");
|
|
});
|
|
|
|
it("focuses the application", () => {
|
|
expect(focusApplicationMock).toHaveBeenCalled();
|
|
});
|
|
|
|
it("still no windows are open", () => {
|
|
expectWindowsToBeOpen([]);
|
|
});
|
|
|
|
it("starts loading static HTML of splash window", () => {
|
|
expect(callForSplashWindowHtmlMock).toHaveBeenCalledWith("/some-lens-resources-directory/static/splash.html");
|
|
});
|
|
|
|
describe("when loading of splash window HTML resolves", () => {
|
|
beforeEach(async () => {
|
|
await callForSplashWindowHtmlMock.resolve();
|
|
});
|
|
|
|
it("shows just the splash window", () => {
|
|
expectWindowsToBeOpen(["splash"]);
|
|
});
|
|
|
|
it("starts loading of content for the application window", () => {
|
|
expect(callForApplicationWindowHtmlMock).toHaveBeenCalledWith("http://localhost:42");
|
|
});
|
|
|
|
describe("given static HTML of application window has not resolved yet, when opening from tray again", () => {
|
|
beforeEach(() => {
|
|
callForApplicationWindowHtmlMock.mockClear();
|
|
callForSplashWindowHtmlMock.mockClear();
|
|
|
|
builder.tray.click("open-app");
|
|
});
|
|
|
|
it("does not load contents of splash window again", () => {
|
|
expect(callForSplashWindowHtmlMock).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("does not load contents of application window again", () => {
|
|
expect(callForApplicationWindowHtmlMock).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("shows just the blank application window to permit developer tool access", () => {
|
|
expectWindowsToBeOpen(["first-application-window"]);
|
|
});
|
|
});
|
|
|
|
describe("when static HTML of application window resolves", () => {
|
|
beforeEach(async () => {
|
|
await callForApplicationWindowHtmlMock.resolve();
|
|
});
|
|
|
|
it("shows just the application window", () => {
|
|
expectWindowsToBeOpen(["first-application-window"]);
|
|
});
|
|
|
|
describe("when reopening the application using tray", () => {
|
|
beforeEach(() => {
|
|
callForSplashWindowHtmlMock.mockClear();
|
|
callForApplicationWindowHtmlMock.mockClear();
|
|
|
|
builder.tray.click("open-app");
|
|
});
|
|
|
|
it("still shows just the application window", () => {
|
|
expectWindowsToBeOpen(["first-application-window"]);
|
|
});
|
|
|
|
it("does not load HTML for splash window again", () => {
|
|
expect(callForSplashWindowHtmlMock).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("does not load HTML for application window again", () => {
|
|
expect(callForApplicationWindowHtmlMock).not.toHaveBeenCalled();
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
describe("given opening of splash window has not finished yet, but another attempt to open the application is made", () => {
|
|
beforeEach(() => {
|
|
createElectronWindowMock.mockClear();
|
|
|
|
builder.tray.click("open-app");
|
|
});
|
|
|
|
it("does not open any new windows", () => {
|
|
expect(createElectronWindowMock).not.toHaveBeenCalled();
|
|
});
|
|
});
|
|
|
|
describe("when opening of splash window resolves", () => {
|
|
beforeEach(async () => {
|
|
await callForSplashWindowHtmlMock.resolve();
|
|
});
|
|
|
|
it("still only splash window is open", () => {
|
|
expectWindowsToBeOpen(["splash"]);
|
|
});
|
|
|
|
it("when opening of application window finishes, only an application window is open", async () => {
|
|
await callForApplicationWindowHtmlMock.resolve();
|
|
|
|
expectWindowsToBeOpen(["first-application-window"]);
|
|
});
|
|
|
|
describe("given opening of application window has not finished yet, but another attempt to open the application is made", () => {
|
|
beforeEach(() => {
|
|
createElectronWindowMock.mockClear();
|
|
|
|
builder.tray.click("open-app");
|
|
});
|
|
|
|
it("does not open any new windows", () => {
|
|
expect(createElectronWindowMock).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("when opening finishes, only an application window is open", async () => {
|
|
await callForApplicationWindowHtmlMock.resolve();
|
|
|
|
expectWindowsToBeOpen(["first-application-window"]);
|
|
});
|
|
});
|
|
});
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
const expectWindowsToBeOpenFor =
|
|
(builder: ApplicationBuilder) => (windowIds: string[]) => {
|
|
const windows: LensWindow[] = [
|
|
builder.mainDi.inject(splashWindowInjectable),
|
|
...builder.applicationWindow.getAll(),
|
|
];
|
|
|
|
expect(
|
|
windows.filter((window) => window.isVisible).map((window) => window.id),
|
|
).toEqual(windowIds);
|
|
};
|