hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

address review comments

Browse Source 
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
This commit is contained in:
Jim Ehrismann 2021-10-22 17:38:57 -04:00
parent 264045cd37
commit 005b993933
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/main/routes/port-forward-route.ts
View File

@ -134,12 +134,10 @@ export class PortForwardRoute {
if (!portForward) { if (!portForward) {
logger.info(`Creating a new port-forward ${namespace}/${resourceType}/${resourceName}:${port}`); logger.info(`Creating a new port-forward ${namespace}/${resourceType}/${resourceName}:${port}`);
let thePort = 0; const thePort = 0 < forwardPort && forwardPort < 65536
? forwardPort
if (forwardPort > 0 && forwardPort < 65536) { : 0;
thePort = forwardPort;
}
portForward = new PortForward(await cluster.getProxyKubeconfigPath(), { portForward = new PortForward(await cluster.getProxyKubeconfigPath(), {
clusterId: cluster.id, clusterId: cluster.id,
kind: resourceType, kind: resourceType,

2
src/renderer/port-forward/port-forward-dialog.tsx
View File

@ -61,7 +61,7 @@ export class PortForwardDialog extends Component<Props> {
static open(portForward: ForwardedPort, options: PortForwardDialogOpenOptions = { openInBrowser: false }) { static open(portForward: ForwardedPort, options: PortForwardDialogOpenOptions = { openInBrowser: false }) {
dialogState.isOpen = true; dialogState.isOpen = true;
dialogState.data = portForward; dialogState.data = portForward;
dialogState.useHttps = Boolean(portForward.protocol === "https"); dialogState.useHttps = portForward.protocol === "https";
dialogState.openInBrowser = options.openInBrowser; dialogState.openInBrowser = options.openInBrowser;
} }