Remove kludge in previous commit by explicitly permitting specific side effects where old unit tests require it

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
This commit is contained in:
Iku-turso authored and Janne Savolainen committed 2022-03-31 15:13:29 +03:00
1 parent 333ef65441
commit 03cd6aac87
14 files changed
+125 -21

No files matched your search

+9 -1
View File
@@ -52,6 +52,8 @@ import createKubeAuthProxyInjectable from "../kube-auth-proxy/create-kube-auth-p
import { createClusterInjectionToken } from "../../common/cluster/create-cluster-injection-token";
import path from "path";
import spawnInjectable from "../child-process/spawn.injectable";
import getConfigurationFileModelInjectable from "../../common/get-configuration-file-model/get-configuration-file-model.injectable";
import appVersionInjectable from "../../common/get-configuration-file-model/app-version/app-version.injectable";
console = new Console(stdout, stderr);
@@ -96,6 +98,12 @@ describe("kube auth proxy tests", () => {
di.override(spawnInjectable, () => mockSpawn);
// @ts-ignore
di.permitSideEffects(getConfigurationFileModelInjectable);
// @ts-ignore
di.permitSideEffects(appVersionInjectable);
mockFs(mockMinikubeConfig);
await di.runSetups();
@@ -134,7 +142,7 @@ describe("kube auth proxy tests", () => {
beforeEach(async () => {
mockedCP = mock<ChildProcess>();
listeners = new EventEmitter();
jest.spyOn(Kubectl.prototype, "checkBinary").mockReturnValueOnce(Promise.resolve(true));
jest.spyOn(Kubectl.prototype, "ensureKubectl").mockReturnValueOnce(Promise.resolve(false));
mockedCP.on.mockImplementation((event: string, listener: (message: any, sendHandle: any) => void): ChildProcess => {
@@ -16,6 +16,10 @@ import { getDiForUnitTesting } from "../../getDiForUnitTesting";
import { createClusterInjectionToken } from "../../../common/cluster/create-cluster-injection-token";
import directoryForKubeConfigsInjectable from "../../../common/app-paths/directory-for-kube-configs/directory-for-kube-configs.injectable";
import { ClusterStore } from "../../../common/cluster-store/cluster-store";
import getConfigurationFileModelInjectable
from "../../../common/get-configuration-file-model/get-configuration-file-model.injectable";
import appVersionInjectable
from "../../../common/get-configuration-file-model/app-version/app-version.injectable";
jest.mock("electron", () => ({
app: {
@@ -52,6 +56,12 @@ describe("kubeconfig-sync.source tests", () => {
ClusterStore.createInstance({ createCluster: () => null }),
);
// @ts-ignore
di.permitSideEffects(getConfigurationFileModelInjectable);
// @ts-ignore
di.permitSideEffects(appVersionInjectable);
di.inject(clusterStoreInjectable);
ClusterManager.createInstance();
@@ -19,6 +19,10 @@ import lensProtocolRouterMainInjectable
from "../lens-protocol-router-main/lens-protocol-router-main.injectable";
import extensionsStoreInjectable
from "../../../extensions/extensions-store/extensions-store.injectable";
import getConfigurationFileModelInjectable
from "../../../common/get-configuration-file-model/get-configuration-file-model.injectable";
import appVersionInjectable
from "../../../common/get-configuration-file-model/app-version/app-version.injectable";
jest.mock("../../../common/ipc");
@@ -44,6 +48,12 @@ describe("protocol router tests", () => {
di.override(extensionsStoreInjectable, () => ExtensionsStore.createInstance());
// @ts-ignore
di.permitSideEffects(getConfigurationFileModelInjectable);
// @ts-ignore
di.permitSideEffects(appVersionInjectable);
await di.runSetups();
extensionLoader = di.inject(extensionLoaderInjectable);