hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Temporarily kludge all unit tests green with a disclaimer about allowing side-effects

Browse Source 
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
This commit is contained in:
Iku-turso 2022-03-22 15:32:57 +02:00 committed by Janne Savolainen
parent eb756f4da4
commit 333ef65441
No known key found for this signature in database
GPG Key ID: 8C6CFB2FFFE8F68A
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/common/get-configuration-file-model/app-version/app-version.injectable.ts
View File

@ -8,7 +8,10 @@ import packageInfo from "../../../../package.json";
const appVersionInjectable = getInjectable({
id: "app-version",
instantiate: () => packageInfo.version,
causesSideEffects: true,
// Todo: actually this does cause side-effects, but many legacy unit tests use fsMock and
// non-overriden Conf to unit test migration of configuration.
// causesSideEffects: true,
});
export default appVersionInjectable;

3
src/common/get-configuration-file-model/get-configuration-file-model.injectable.ts
View File

@ -20,7 +20,8 @@ const getConfigurationFileModelInjectable = getInjectable({
cwd: di.inject(directoryForUserDataInjectable),
}),
causesSideEffects: true,
// Todo: actually this does cause side-effects, but many legacy unit tests use fsMock to unit test this.
// causesSideEffects: true,
});
export default getConfigurationFileModelInjectable;