hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Remove hyperlink of Helm Maintainers (#6579)

Browse Source 
- Instead just show the name and email

Signed-off-by: Sebastian Malton <sebastian@malton.name>

Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2022-11-16 04:34:34 -08:00 committed by GitHub
parent 3ad841bc15
commit 05ab0a3f55
3 changed files with 40 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/features/helm-charts/installing-chart/__snapshots__/opening-dock-tab-for-installing-helm-chart.test.ts.snap
View File

@ -2773,7 +2773,11 @@ exports[`opening dock tab for installing helm chart given application is started
</span> </span>
<span <span
class="value" class="value"
/> >
<li>
Some Foo&lt;some@foo.com&gt;
</li>
</span>
</div> </div>
</div> </div>
</div> </div>
@ -3676,7 +3680,11 @@ exports[`opening dock tab for installing helm chart given application is started
</span> </span>
<span <span
class="value" class="value"
/> >
<li>
Some Foo&lt;some@foo.com&gt;
</li>
</span>
</div> </div>
</div> </div>
</div> </div>
@ -4589,7 +4597,11 @@ exports[`opening dock tab for installing helm chart given application is started
</span> </span>
<span <span
class="value" class="value"
/> >
<li>
Some Foo&lt;some@foo.com&gt;
</li>
</span>
</div> </div>
</div> </div>
</div> </div>
@ -5492,7 +5504,11 @@ exports[`opening dock tab for installing helm chart given application is started
</span> </span>
<span <span
class="value" class="value"
/> >
<li>
Some Foo&lt;some@foo.com&gt;
</li>
</span>
</div> </div>
</div> </div>
</div> </div>

20
src/features/helm-charts/installing-chart/opening-dock-tab-for-installing-helm-chart.test.ts
View File

@ -95,7 +95,10 @@ describe("opening dock tab for installing helm chart", () => {
urls: [], urls: [],
annotations: {}, annotations: {},
dependencies: [], dependencies: [],
maintainers: [], maintainers: [{
email: "some@foo.com",
name: "Some Foo",
}],
deprecated: false, deprecated: false,
}), }),
@ -111,7 +114,10 @@ describe("opening dock tab for installing helm chart", () => {
urls: [], urls: [],
annotations: {}, annotations: {},
dependencies: [], dependencies: [],
maintainers: [], maintainers: [{
email: "other@bar.com",
name: "Other Bar",
}],
deprecated: false, deprecated: false,
}), }),
]); ]);
@ -162,7 +168,10 @@ describe("opening dock tab for installing helm chart", () => {
urls: [], urls: [],
annotations: {}, annotations: {},
dependencies: [], dependencies: [],
maintainers: [], maintainers: [{
email: "some@foo.com",
name: "Some Foo",
}],
deprecated: false, deprecated: false,
}), }),
@ -178,7 +187,10 @@ describe("opening dock tab for installing helm chart", () => {
urls: [], urls: [],
annotations: {}, annotations: {},
dependencies: [], dependencies: [],
maintainers: [], maintainers: [{
email: "other@bar.com",
name: "Other Bar",
}],
deprecated: false, deprecated: false,
}), }),
]); ]);

12
src/renderer/components/+helm-charts/helm-chart-details.tsx
View File

@ -117,15 +117,9 @@ class NonInjectedHelmChartDetails extends Component<HelmChartDetailsProps & Depe
</a> </a>
</DrawerItem> </DrawerItem>
<DrawerItem name="Maintainers" className="maintainers"> <DrawerItem name="Maintainers" className="maintainers">
{selectedChart.getMaintainers().map(({ name, email, url }) => ( {selectedChart.getMaintainers()
<a .map(({ name, email }) => (
key={name} <li key={name}>{`${name}<${email}>`}</li>
href={url || `mailto:${email}`}
target="_blank"
rel="noreferrer"
>
{name}
</a>
))} ))}
</DrawerItem> </DrawerItem>
{selectedChart.getKeywords().length > 0 && ( {selectedChart.getKeywords().length > 0 && (