Add comment, fix tests

Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton committed 2021-07-16 12:05:12 -04:00
1 parent 163974f013
commit 09a0750a2d
2 files changed
+5 -4

No files matched your search

@@ -39,7 +39,7 @@ describe("extension compatibility", () => {
it("has no extension comparator", () => {
const manifest = { name: "extensionName", version: "0.0.1"};
expect(isCompatibleExtension(manifest,)).toBe(false);
expect(isCompatibleExtension(manifest, false)).toBe(false);
});
it.each([
@@ -78,7 +78,7 @@ describe("extension compatibility", () => {
])("extension comparator test: %p", ({ comparator, expected }) => {
const manifest: LensExtensionManifest = { name: "extensionName", version: "0.0.1", engines: { lens: comparator}};
expect(isCompatibleExtension(manifest,)).toBe(expected);
expect(isCompatibleExtension(manifest, false)).toBe(expected);
});
});
@@ -93,7 +93,7 @@ describe("extension compatibility", () => {
it("has no extension comparator", () => {
const manifest = { name: "extensionName", version: "0.0.1"};
expect(isCompatibleExtension(manifest,)).toBe(false);
expect(isCompatibleExtension(manifest, false)).toBe(false);
});
it.each([
@@ -132,7 +132,7 @@ describe("extension compatibility", () => {
])("extension comparator test: %p", ({ comparator, expected }) => {
const manifest: LensExtensionManifest = { name: "extensionName", version: "0.0.1", engines: { lens: comparator}};
expect(isCompatibleExtension(manifest,)).toBe(expected);
expect(isCompatibleExtension(manifest, false)).toBe(expected);
});
});
});
@@ -25,6 +25,7 @@ import type { LensExtensionManifest } from "./lens-extension";
export function isCompatibleExtension(manifest: LensExtensionManifest, isBundled: boolean): boolean {
if (manifest.engines?.lens) {
// We only started having bundled extensions specify the engine in v5
if (isBundled) {
return true;
}