mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
fixes / responding to comments -- part 1
Signed-off-by: Roman <ixrock@gmail.com>
This commit is contained in:
parent
0c517b14d0
commit
1b680ee5a2
@ -319,5 +319,4 @@ export const DESCRIPTORS = {
|
||||
|
||||
export const CONSTANTS = {
|
||||
updateChannels,
|
||||
defaultEditorConfig,
|
||||
};
|
||||
|
||||
@ -29,7 +29,7 @@ import { kubeConfigDefaultPath } from "../kube-helpers";
|
||||
import { appEventBus } from "../event-bus";
|
||||
import path from "path";
|
||||
import { ObservableToggleSet, toJS } from "../../renderer/utils";
|
||||
import { CONSTANTS, DESCRIPTORS, KubeconfigSyncValue, UserPreferencesModel, EditorConfiguration } from "./preferences-helpers";
|
||||
import { DESCRIPTORS, EditorConfiguration, KubeconfigSyncValue, UserPreferencesModel } from "./preferences-helpers";
|
||||
import logger from "../../main/logger";
|
||||
import { getPath } from "../utils/getPath";
|
||||
|
||||
@ -90,7 +90,7 @@ export class UserStore extends BaseStore<UserStoreModel> /* implements UserStore
|
||||
/**
|
||||
* Monaco editor configs
|
||||
*/
|
||||
@observable editorConfiguration: EditorConfiguration = CONSTANTS.defaultEditorConfig;
|
||||
@observable editorConfiguration: EditorConfiguration;
|
||||
|
||||
/**
|
||||
* The set of file/folder paths to be synced
|
||||
|
||||
@ -58,7 +58,7 @@ export class ReleaseDetails extends Component<Props> {
|
||||
@observable details: IReleaseDetails | null = null;
|
||||
@observable values = "";
|
||||
@observable valuesLoading = false;
|
||||
@observable showOnlyUserSuppliedValues = false;
|
||||
@observable showOnlyUserSuppliedValues = true;
|
||||
@observable saving = false;
|
||||
@observable releaseSecret: Secret;
|
||||
@observable error?: string = undefined;
|
||||
|
||||
@ -20,9 +20,8 @@
|
||||
*/
|
||||
import { observer } from "mobx-react";
|
||||
import React from "react";
|
||||
import type { editor } from "monaco-editor";
|
||||
import { UserStore } from "../../../common/user-store";
|
||||
import { Switcher } from "../switch";
|
||||
import { FormSwitch, Switcher } from "../switch";
|
||||
import { Select } from "../select";
|
||||
import { SubTitle } from "../layout/sub-title";
|
||||
import { SubHeader } from "../layout/sub-header";
|
||||
@ -46,17 +45,21 @@ export const Editor = observer(() => {
|
||||
<section>
|
||||
<div className="flex gaps justify-space-between">
|
||||
<div className="flex gaps align-center">
|
||||
<SubHeader compact>Show minimap</SubHeader>
|
||||
<Switcher
|
||||
checked={editorConfiguration.minimap.enabled}
|
||||
onChange={(evt, checked) => editorConfiguration.minimap.enabled = checked}
|
||||
<FormSwitch
|
||||
label={<SubHeader compact>Show minimap</SubHeader>}
|
||||
control={
|
||||
<Switcher
|
||||
checked={editorConfiguration.minimap.enabled}
|
||||
onChange={(evt, checked) => editorConfiguration.minimap.enabled = checked}
|
||||
/>
|
||||
}
|
||||
/>
|
||||
</div>
|
||||
<div className="flex gaps align-center">
|
||||
<SubHeader compact>Position</SubHeader>
|
||||
<Select
|
||||
themeName="lens"
|
||||
options={["left", "right"] as editor.IEditorMinimapOptions["side"][]}
|
||||
options={["left", "right"]}
|
||||
value={editorConfiguration.minimap.side}
|
||||
onChange={({ value }) => editorConfiguration.minimap.side = value}
|
||||
/>
|
||||
|
||||
Loading…
Reference in New Issue
Block a user