hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

fixes / responding to comments -- part 1

Browse Source 
Signed-off-by: Roman <ixrock@gmail.com>
This commit is contained in:
Roman 2021-10-18 15:06:16 +03:00
parent 0c517b14d0
commit 1b680ee5a2
4 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/common/user-store/preferences-helpers.ts
View File

@ -319,5 +319,4 @@ export const DESCRIPTORS = {
export const CONSTANTS = { export const CONSTANTS = {
updateChannels, updateChannels,
defaultEditorConfig,
}; };

4
src/common/user-store/user-store.ts
View File

@ -29,7 +29,7 @@ import { kubeConfigDefaultPath } from "../kube-helpers";
import { appEventBus } from "../event-bus"; import { appEventBus } from "../event-bus";
import path from "path"; import path from "path";
import { ObservableToggleSet, toJS } from "../../renderer/utils"; import { ObservableToggleSet, toJS } from "../../renderer/utils";
import { CONSTANTS, DESCRIPTORS, KubeconfigSyncValue, UserPreferencesModel, EditorConfiguration } from "./preferences-helpers"; import { DESCRIPTORS, EditorConfiguration, KubeconfigSyncValue, UserPreferencesModel } from "./preferences-helpers";
import logger from "../../main/logger"; import logger from "../../main/logger";
import { getPath } from "../utils/getPath"; import { getPath } from "../utils/getPath";
@ -90,7 +90,7 @@ export class UserStore extends BaseStore<UserStoreModel> /* implements UserStore
/** /**
* Monaco editor configs * Monaco editor configs
*/ */
@observable editorConfiguration: EditorConfiguration = CONSTANTS.defaultEditorConfig; @observable editorConfiguration: EditorConfiguration;
/** /**
* The set of file/folder paths to be synced * The set of file/folder paths to be synced

2
src/renderer/components/+apps-releases/release-details.tsx
View File

@ -58,7 +58,7 @@ export class ReleaseDetails extends Component<Props> {
@observable details: IReleaseDetails | null = null; @observable details: IReleaseDetails | null = null;
@observable values = ""; @observable values = "";
@observable valuesLoading = false; @observable valuesLoading = false;
@observable showOnlyUserSuppliedValues = false; @observable showOnlyUserSuppliedValues = true;
@observable saving = false; @observable saving = false;
@observable releaseSecret: Secret; @observable releaseSecret: Secret;
@observable error?: string = undefined; @observable error?: string = undefined;

17
src/renderer/components/+preferences/editor.tsx
View File

@ -20,9 +20,8 @@
*/ */
import { observer } from "mobx-react"; import { observer } from "mobx-react";
import React from "react"; import React from "react";
import type { editor } from "monaco-editor";
import { UserStore } from "../../../common/user-store"; import { UserStore } from "../../../common/user-store";
import { Switcher } from "../switch"; import { FormSwitch, Switcher } from "../switch";
import { Select } from "../select"; import { Select } from "../select";
import { SubTitle } from "../layout/sub-title"; import { SubTitle } from "../layout/sub-title";
import { SubHeader } from "../layout/sub-header"; import { SubHeader } from "../layout/sub-header";
@ -46,17 +45,21 @@ export const Editor = observer(() => {
<section> <section>
<div className="flex gaps justify-space-between"> <div className="flex gaps justify-space-between">
<div className="flex gaps align-center"> <div className="flex gaps align-center">
<SubHeader compact>Show minimap</SubHeader> <FormSwitch
<Switcher label={<SubHeader compact>Show minimap</SubHeader>}
checked={editorConfiguration.minimap.enabled} control={
onChange={(evt, checked) => editorConfiguration.minimap.enabled = checked} <Switcher
checked={editorConfiguration.minimap.enabled}
onChange={(evt, checked) => editorConfiguration.minimap.enabled = checked}
/>
}
/> />
</div> </div>
<div className="flex gaps align-center"> <div className="flex gaps align-center">
<SubHeader compact>Position</SubHeader> <SubHeader compact>Position</SubHeader>
<Select <Select
themeName="lens" themeName="lens"
options={["left", "right"] as editor.IEditorMinimapOptions["side"][]} options={["left", "right"]}
value={editorConfiguration.minimap.side} value={editorConfiguration.minimap.side}
onChange={({ value }) => editorConfiguration.minimap.side = value} onChange={({ value }) => editorConfiguration.minimap.side = value}
/> />