support page fixes

Signed-off-by: Roman <ixrock@gmail.com>

extensions/support-page/main.ts

@@ -12,10 +12,7 @@ export default class SupportPageMainExtension extends LensMainExtension {
         parentId: "help",
         label: "Support",
         click() {
-          windowManager.navigate({
-            channel: "menu:navigate", // fixme: use windowManager.ensureMainWindow from Tray's PR
-            url: supportPageURL(),
-          });
+          windowManager.navigate(supportPageURL());
         }
       })
     )

src/extensions/core-api/index.ts

@@ -12,6 +12,7 @@ import * as Util from "./utils"
 import * as Registry from "../registries"
 import * as ClusterFeature from "./cluster-feature"
 
+// TODO: allow to expose windowManager.navigate() as Navigation.navigate() in runtime
 export let windowManager: WindowManager;
 
 export {

src/main/menu.ts

@@ -50,8 +50,7 @@ export function buildMenu(windowManager: WindowManager) {
 
   async function navigate(url: string) {
     logger.info(`[MENU]: navigating to ${url}`);
-    await windowManager.ensureMainWindow();
-    windowManager.navigate(url);
+    await windowManager.navigate(url);
   }
 
   const macAppMenu: MenuItemConstructorOptions = {

src/main/tray.ts

@@ -43,8 +43,6 @@ export function initTray(windowManager: WindowManager) {
 }
 
 export function buildTray(icon: string | NativeImage, menu: Menu) {
-  logger.info("[TRAY]: build start");
-
   if (!tray) {
     tray = new Tray(icon)
     tray.setToolTip(packageInfo.description)
@@ -76,8 +74,7 @@ export function createTrayMenu(windowManager: WindowManager): Menu {
     },
     {
       label: "Preferences",
-      async click() {
-        await windowManager.ensureMainWindow()
+      click() {
         windowManager.navigate(preferencesURL());
       },
     },
@@ -98,7 +95,6 @@ export function createTrayMenu(windowManager: WindowManager): Menu {
                 async click() {
                   workspaceStore.setActive(workspace);
                   clusterStore.setActive(clusterId);
-                  await windowManager.ensureMainWindow()
                   windowManager.navigate(clusterViewURL({ params: { clusterId } }));
                 }
               }
@@ -110,8 +106,8 @@ export function createTrayMenu(windowManager: WindowManager): Menu {
       label: "Check for updates",
       async click() {
         const result = await AppUpdater.checkForUpdates();
-        const browserWindow = await windowManager.ensureMainWindow();
         if (!result) {
+          const browserWindow = await windowManager.ensureMainWindow();
           dialog.showMessageBoxSync(browserWindow, {
             message: "No updates available",
             type: "info",

src/main/window-manager.ts

@@ -117,7 +117,8 @@ export class WindowManager {
     }
   }
 
-  navigate(url: string, frameId?: number) {
+  async navigate(url: string, frameId?: number) {
+    await this.ensureMainWindow();
     this.sendToView({
       channel: "menu:navigate",
       frameId: frameId,