hendrik/lens
1
0 Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

use more descriptive name for local test mocks

Browse Source 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton committed 2022-05-05 09:27:59 -04:00
1 parent b9ea2098b2
commit 21221d8b37
2 files changed
+10 -10
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/common/__tests__/hotbar-store.test.ts
+6 -6
View File
@@ -42,7 +42,7 @@ describe("HotbarStore", () => {
let testCluster: CatalogEntity;
let minikubeCluster: CatalogEntity;
let awsCluster: CatalogEntity;
let logger: jest.Mocked<Logger>;
let loggerMock: jest.Mocked<Logger>;
beforeEach(async () => {
di = getDiForUnitTesting({ doGeneralOverrides: true });
@@ -91,7 +91,7 @@ describe("HotbarStore", () => {
di.override(hasCategoryForEntityInjectable, () => () => true);
logger = {
loggerMock = {
warn: jest.fn(),
debug: jest.fn(),
error: jest.fn(),
@@ -99,7 +99,7 @@ describe("HotbarStore", () => {
silly: jest.fn(),
};
di.override(loggerInjectable, () => logger);
di.override(loggerInjectable, () => loggerMock);
const catalogEntityRegistry = di.inject(catalogEntityRegistryInjectable);
const catalogCatalogEntity = di.inject(catalogCatalogEntityInjectable);
@@ -219,13 +219,13 @@ describe("HotbarStore", () => {
hotbarStore.setActiveHotbar("hottest");
hotbarStore.addToHotbar(testCluster, -1);
expect(logger.error).toBeCalledWith("[HOTBAR-STORE]: cannot pin entity to hotbar outside of index range", anyObject());
expect(loggerMock.error).toBeCalledWith("[HOTBAR-STORE]: cannot pin entity to hotbar outside of index range", anyObject());
hotbarStore.addToHotbar(testCluster, 12);
expect(logger.error).toBeCalledWith("[HOTBAR-STORE]: cannot pin entity to hotbar outside of index range", anyObject());
expect(loggerMock.error).toBeCalledWith("[HOTBAR-STORE]: cannot pin entity to hotbar outside of index range", anyObject());
hotbarStore.addToHotbar(testCluster, 13);
expect(logger.error).toBeCalledWith("[HOTBAR-STORE]: cannot pin entity to hotbar outside of index range", anyObject());
expect(loggerMock.error).toBeCalledWith("[HOTBAR-STORE]: cannot pin entity to hotbar outside of index range", anyObject());
});
it("throws an error if getId is invalid or returns not a string", () => {
src/main/__test__/kubeconfig-manager.test.ts
+4 -4
View File
@@ -27,14 +27,14 @@ describe("kubeconfig manager tests", () => {
let clusterFake: Cluster;
let createKubeconfigManager: (cluster: Cluster) => KubeconfigManager | undefined;
let di: DiContainer;
let logger: jest.Mocked<Logger>;
let loggerMock: jest.Mocked<Logger>;
beforeEach(async () => {
di = getDiForUnitTesting({ doGeneralOverrides: true });
di.override(directoryForTempInjectable, () => "some-directory-for-temp");
logger = {
loggerMock = {
warn: jest.fn(),
debug: jest.fn(),
error: jest.fn(),
@@ -42,7 +42,7 @@ describe("kubeconfig manager tests", () => {
silly: jest.fn(),
};
di.override(loggerInjectable, () => logger);
di.override(loggerInjectable, () => loggerMock);
mockFs({
"minikube-config.yml": JSON.stringify({
@@ -104,7 +104,7 @@ describe("kubeconfig manager tests", () => {
assert(kubeConfManager, "should actually create one");
expect(logger.error).not.toBeCalled();
expect(loggerMock.error).not.toBeCalled();
expect(await kubeConfManager.getPath()).toBe(`some-directory-for-temp${path.sep}kubeconfig-foo`);
// this causes an intermittent "ENXIO: no such device or address, read" error
// const file = await fse.readFile(await kubeConfManager.getPath());