hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

reinstate integration tests on windows (#6152)

Browse Source
This commit is contained in:
Jim Ehrismann 2022-09-01 09:27:31 -04:00 committed by GitHub
parent 37318cab4e
commit 27871f57b6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
integration/__tests__/app-preferences.tests.ts
View File

@ -11,7 +11,6 @@
*/ */
import type { ElectronApplication, Page } from "playwright"; import type { ElectronApplication, Page } from "playwright";
import * as utils from "../helpers/utils"; import * as utils from "../helpers/utils";
import { isWindows } from "../../src/common/vars";
describe("preferences page tests", () => { describe("preferences page tests", () => {
let window: Page, cleanup: () => Promise<void>; let window: Page, cleanup: () => Promise<void>;
@ -34,8 +33,7 @@ describe("preferences page tests", () => {
await cleanup(); await cleanup();
}, 10*60*1000); }, 10*60*1000);
// skip on windows due to suspected playwright issue with Electron 14 it('shows "preferences" and can navigate through the tabs', async () => {
utils.itIf(!isWindows)('shows "preferences" and can navigate through the tabs', async () => {
const pages = [ const pages = [
{ {
id: "application", id: "application",

4
integration/__tests__/command-palette.tests.ts
View File

@ -5,7 +5,6 @@
import type { ElectronApplication, Page } from "playwright"; import type { ElectronApplication, Page } from "playwright";
import * as utils from "../helpers/utils"; import * as utils from "../helpers/utils";
import { isWindows } from "../../src/common/vars";
describe("Lens command palette", () => { describe("Lens command palette", () => {
let window: Page, cleanup: () => Promise<void>, app: ElectronApplication; let window: Page, cleanup: () => Promise<void>, app: ElectronApplication;
@ -20,8 +19,7 @@ describe("Lens command palette", () => {
}, 10*60*1000); }, 10*60*1000);
describe("menu", () => { describe("menu", () => {
// skip on windows due to suspected playwright issue with Electron 14 it("opens command dialog from menu", async () => {
utils.itIf(!isWindows)("opens command dialog from menu", async () => {
await app.evaluate(async ({ app }) => { await app.evaluate(async ({ app }) => {
await app.applicationMenu await app.applicationMenu
?.getMenuItemById("view") ?.getMenuItemById("view")