hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Fixing role binding details view without subjects (#688)

Browse Source 
Signed-off-by: alexfront <alex.andreev.email@gmail.com>
This commit is contained in:
Alex Andreev 2020-08-14 14:39:28 +03:00 committed by GitHub
parent e249769562
commit 30c14eb6da
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 28 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

53
src/renderer/components/+user-management-roles-bindings/role-binding-details.tsx
View File

@ -64,6 +64,7 @@ export class RoleBindingDetails extends React.Component<Props> {
}
const name = roleBinding.getName();
const { roleRef } = roleBinding;
const subjects = roleBinding.getSubjects();
return (
<div className="RoleBindingDetails">
<KubeObjectMeta object={roleBinding}/>
@ -83,31 +84,33 @@ export class RoleBindingDetails extends React.Component<Props> {
</Table>
<DrawerTitle title={<Trans>Bindings</Trans>}/>
<Table selectable className="bindings box grow">
<TableHead>
<TableCell checkbox/>
<TableCell className="binding"><Trans>Binding</Trans></TableCell>
<TableCell className="type"><Trans>Type</Trans></TableCell>
<TableCell className="type"><Trans>Namespace</Trans></TableCell>
</TableHead>
{
roleBinding.getSubjects().map((subject, i) => {
const { kind, name, namespace } = subject;
const isSelected = selectedSubjects.includes(subject);
return (
<TableRow
key={i} selected={isSelected}
onClick={prevDefault(() => this.selectSubject(subject))}
>
<TableCell checkbox isChecked={isSelected}/>
<TableCell className="binding">{name}</TableCell>
<TableCell className="type">{kind}</TableCell>
<TableCell className="ns">{namespace || "-"}</TableCell>
</TableRow>
)
})
}
</Table>
{subjects.length > 0 && (
<Table selectable className="bindings box grow">
<TableHead>
<TableCell checkbox/>
<TableCell className="binding"><Trans>Binding</Trans></TableCell>
<TableCell className="type"><Trans>Type</Trans></TableCell>
<TableCell className="type"><Trans>Namespace</Trans></TableCell>
</TableHead>
{
subjects.map((subject, i) => {
const { kind, name, namespace } = subject;
const isSelected = selectedSubjects.includes(subject);
return (
<TableRow
key={i} selected={isSelected}
onClick={prevDefault(() => this.selectSubject(subject))}
>
<TableCell checkbox isChecked={isSelected}/>
<TableCell className="binding">{name}</TableCell>
<TableCell className="type">{kind}</TableCell>
<TableCell className="ns">{namespace || "-"}</TableCell>
</TableRow>
)
})
}
</Table>
)}
<KubeEventDetails object={roleBinding}/>