mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
Consolidate naming
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
This commit is contained in:
parent
629d86c5ff
commit
409e39deb8
@ -53,7 +53,7 @@ const registratorForPreferenceItemsInjectable = getInjectable({
|
||||
</PreferencePageComponent>
|
||||
),
|
||||
|
||||
childrenSeparator: () => <hr />,
|
||||
childSeparator: () => <hr />,
|
||||
}),
|
||||
|
||||
injectionToken: preferenceItemInjectionToken,
|
||||
@ -132,7 +132,7 @@ const registratorForPreferenceItemsInjectable = getInjectable({
|
||||
<ExtensionPreferenceItem registration={registration} />
|
||||
),
|
||||
|
||||
childrenSeparator: () => <hr />,
|
||||
childSeparator: () => <hr />,
|
||||
}),
|
||||
|
||||
injectionToken: preferenceItemInjectionToken,
|
||||
|
||||
@ -23,7 +23,7 @@ const applicationPreferencePageInjectable = getInjectable({
|
||||
id: "application-page",
|
||||
parentId: "application-tab",
|
||||
Component: ApplicationPage,
|
||||
childrenSeparator: HorizontalLine,
|
||||
childSeparator: HorizontalLine,
|
||||
}),
|
||||
|
||||
injectionToken: preferenceItemInjectionToken,
|
||||
|
||||
@ -25,7 +25,7 @@ const kubectlGroupPreferenceItemInjectable = getInjectable({
|
||||
parentId: "kubernetes-page",
|
||||
orderNumber: 10,
|
||||
Component: PreferenceItemGroup,
|
||||
childrenSeparator: () => <Gutter size="xl" />,
|
||||
childSeparator: () => <Gutter size="xl" />,
|
||||
}),
|
||||
|
||||
injectionToken: preferenceItemInjectionToken,
|
||||
|
||||
@ -23,7 +23,7 @@ const kubernetesPreferencePageInjectable = getInjectable({
|
||||
id: "kubernetes-page",
|
||||
parentId: "kubernetes-tab",
|
||||
Component: KubernetesPage,
|
||||
childrenSeparator: HorizontalLine,
|
||||
childSeparator: HorizontalLine,
|
||||
}),
|
||||
|
||||
injectionToken: preferenceItemInjectionToken,
|
||||
|
||||
@ -36,7 +36,7 @@ export interface PreferencePage {
|
||||
id: string;
|
||||
parentId: string;
|
||||
isShown?: IComputedValue<boolean> | boolean;
|
||||
childrenSeparator?: () => React.ReactElement;
|
||||
childSeparator?: () => React.ReactElement;
|
||||
Component: PreferenceItemComponent<PreferencePage>;
|
||||
}
|
||||
|
||||
@ -46,7 +46,7 @@ export interface PreferenceItem {
|
||||
parentId: string;
|
||||
orderNumber: number;
|
||||
isShown?: IComputedValue<boolean> | boolean;
|
||||
childrenSeparator?: () => React.ReactElement;
|
||||
childSeparator?: () => React.ReactElement;
|
||||
Component: PreferenceItemComponent<PreferenceItem>;
|
||||
}
|
||||
|
||||
|
||||
@ -11,7 +11,7 @@ export interface PreferenceTabsRoot {
|
||||
id: string;
|
||||
parentId: undefined;
|
||||
isShown: IComputedValue<true>;
|
||||
childrenSeparator: () => React.ReactElement;
|
||||
childSeparator: () => React.ReactElement;
|
||||
}
|
||||
|
||||
export const preferenceTabsRoot: PreferenceTabsRoot = {
|
||||
@ -19,5 +19,5 @@ export const preferenceTabsRoot: PreferenceTabsRoot = {
|
||||
id: "preference-tabs",
|
||||
parentId: undefined,
|
||||
isShown: computed(() => true as const),
|
||||
childrenSeparator: HorizontalLine,
|
||||
childSeparator: HorizontalLine,
|
||||
};
|
||||
|
||||
@ -23,7 +23,7 @@ const proxyPreferencePageInjectable = getInjectable({
|
||||
id: "proxy-page",
|
||||
parentId: "proxy-tab",
|
||||
Component: ProxyPage,
|
||||
childrenSeparator: () => <HorizontalLine small />,
|
||||
childSeparator: () => <HorizontalLine small />,
|
||||
}),
|
||||
|
||||
injectionToken: preferenceItemInjectionToken,
|
||||
|
||||
@ -22,7 +22,7 @@ const telemetryPreferencePageInjectable = getInjectable({
|
||||
id: "telemetry-page",
|
||||
parentId: "telemetry-tab",
|
||||
Component: TelemetryPage,
|
||||
childrenSeparator: () => <hr className="small" />,
|
||||
childSeparator: () => <hr className="small" />,
|
||||
}),
|
||||
|
||||
injectionToken: preferenceItemInjectionToken,
|
||||
|
||||
@ -81,7 +81,7 @@ const toNavigationHierarchy = (composite: Composite<PreferenceTypes | Preference
|
||||
|
||||
case "preference-tabs-root": {
|
||||
return (
|
||||
<Map items={composite.children} getSeparator={value.childrenSeparator}>
|
||||
<Map items={composite.children} getSeparator={value.childSeparator}>
|
||||
{toNavigationHierarchy}
|
||||
</Map>
|
||||
);
|
||||
|
||||
@ -61,7 +61,7 @@ const toPreferenceItemHierarchy = (composite: Composite<PreferenceTypes>) => {
|
||||
<Component item={value}>
|
||||
<Map
|
||||
items={composite.children}
|
||||
getSeparator={value.childrenSeparator}
|
||||
getSeparator={value.childSeparator}
|
||||
>
|
||||
{toPreferenceItemHierarchy}
|
||||
</Map>
|
||||
@ -78,7 +78,7 @@ const toPreferenceItemHierarchy = (composite: Composite<PreferenceTypes>) => {
|
||||
<Component item={value}>
|
||||
<Map
|
||||
items={composite.children}
|
||||
getSeparator={value.childrenSeparator || DefaultSeparator}
|
||||
getSeparator={value.childSeparator || DefaultSeparator}
|
||||
>
|
||||
{toPreferenceItemHierarchy}
|
||||
</Map>
|
||||
|
||||
Loading…
Reference in New Issue
Block a user