1
0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00

Consolidate naming

Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
This commit is contained in:
Janne Savolainen 2022-10-19 11:24:28 +03:00
parent 629d86c5ff
commit 409e39deb8
No known key found for this signature in database
GPG Key ID: 8C6CFB2FFFE8F68A
10 changed files with 14 additions and 14 deletions

View File

@ -53,7 +53,7 @@ const registratorForPreferenceItemsInjectable = getInjectable({
</PreferencePageComponent> </PreferencePageComponent>
), ),
childrenSeparator: () => <hr />, childSeparator: () => <hr />,
}), }),
injectionToken: preferenceItemInjectionToken, injectionToken: preferenceItemInjectionToken,
@ -132,7 +132,7 @@ const registratorForPreferenceItemsInjectable = getInjectable({
<ExtensionPreferenceItem registration={registration} /> <ExtensionPreferenceItem registration={registration} />
), ),
childrenSeparator: () => <hr />, childSeparator: () => <hr />,
}), }),
injectionToken: preferenceItemInjectionToken, injectionToken: preferenceItemInjectionToken,

View File

@ -23,7 +23,7 @@ const applicationPreferencePageInjectable = getInjectable({
id: "application-page", id: "application-page",
parentId: "application-tab", parentId: "application-tab",
Component: ApplicationPage, Component: ApplicationPage,
childrenSeparator: HorizontalLine, childSeparator: HorizontalLine,
}), }),
injectionToken: preferenceItemInjectionToken, injectionToken: preferenceItemInjectionToken,

View File

@ -25,7 +25,7 @@ const kubectlGroupPreferenceItemInjectable = getInjectable({
parentId: "kubernetes-page", parentId: "kubernetes-page",
orderNumber: 10, orderNumber: 10,
Component: PreferenceItemGroup, Component: PreferenceItemGroup,
childrenSeparator: () => <Gutter size="xl" />, childSeparator: () => <Gutter size="xl" />,
}), }),
injectionToken: preferenceItemInjectionToken, injectionToken: preferenceItemInjectionToken,

View File

@ -23,7 +23,7 @@ const kubernetesPreferencePageInjectable = getInjectable({
id: "kubernetes-page", id: "kubernetes-page",
parentId: "kubernetes-tab", parentId: "kubernetes-tab",
Component: KubernetesPage, Component: KubernetesPage,
childrenSeparator: HorizontalLine, childSeparator: HorizontalLine,
}), }),
injectionToken: preferenceItemInjectionToken, injectionToken: preferenceItemInjectionToken,

View File

@ -36,7 +36,7 @@ export interface PreferencePage {
id: string; id: string;
parentId: string; parentId: string;
isShown?: IComputedValue<boolean> | boolean; isShown?: IComputedValue<boolean> | boolean;
childrenSeparator?: () => React.ReactElement; childSeparator?: () => React.ReactElement;
Component: PreferenceItemComponent<PreferencePage>; Component: PreferenceItemComponent<PreferencePage>;
} }
@ -46,7 +46,7 @@ export interface PreferenceItem {
parentId: string; parentId: string;
orderNumber: number; orderNumber: number;
isShown?: IComputedValue<boolean> | boolean; isShown?: IComputedValue<boolean> | boolean;
childrenSeparator?: () => React.ReactElement; childSeparator?: () => React.ReactElement;
Component: PreferenceItemComponent<PreferenceItem>; Component: PreferenceItemComponent<PreferenceItem>;
} }

View File

@ -11,7 +11,7 @@ export interface PreferenceTabsRoot {
id: string; id: string;
parentId: undefined; parentId: undefined;
isShown: IComputedValue<true>; isShown: IComputedValue<true>;
childrenSeparator: () => React.ReactElement; childSeparator: () => React.ReactElement;
} }
export const preferenceTabsRoot: PreferenceTabsRoot = { export const preferenceTabsRoot: PreferenceTabsRoot = {
@ -19,5 +19,5 @@ export const preferenceTabsRoot: PreferenceTabsRoot = {
id: "preference-tabs", id: "preference-tabs",
parentId: undefined, parentId: undefined,
isShown: computed(() => true as const), isShown: computed(() => true as const),
childrenSeparator: HorizontalLine, childSeparator: HorizontalLine,
}; };

View File

@ -23,7 +23,7 @@ const proxyPreferencePageInjectable = getInjectable({
id: "proxy-page", id: "proxy-page",
parentId: "proxy-tab", parentId: "proxy-tab",
Component: ProxyPage, Component: ProxyPage,
childrenSeparator: () => <HorizontalLine small />, childSeparator: () => <HorizontalLine small />,
}), }),
injectionToken: preferenceItemInjectionToken, injectionToken: preferenceItemInjectionToken,

View File

@ -22,7 +22,7 @@ const telemetryPreferencePageInjectable = getInjectable({
id: "telemetry-page", id: "telemetry-page",
parentId: "telemetry-tab", parentId: "telemetry-tab",
Component: TelemetryPage, Component: TelemetryPage,
childrenSeparator: () => <hr className="small" />, childSeparator: () => <hr className="small" />,
}), }),
injectionToken: preferenceItemInjectionToken, injectionToken: preferenceItemInjectionToken,

View File

@ -81,7 +81,7 @@ const toNavigationHierarchy = (composite: Composite<PreferenceTypes | Preference
case "preference-tabs-root": { case "preference-tabs-root": {
return ( return (
<Map items={composite.children} getSeparator={value.childrenSeparator}> <Map items={composite.children} getSeparator={value.childSeparator}>
{toNavigationHierarchy} {toNavigationHierarchy}
</Map> </Map>
); );

View File

@ -61,7 +61,7 @@ const toPreferenceItemHierarchy = (composite: Composite<PreferenceTypes>) => {
<Component item={value}> <Component item={value}>
<Map <Map
items={composite.children} items={composite.children}
getSeparator={value.childrenSeparator} getSeparator={value.childSeparator}
> >
{toPreferenceItemHierarchy} {toPreferenceItemHierarchy}
</Map> </Map>
@ -78,7 +78,7 @@ const toPreferenceItemHierarchy = (composite: Composite<PreferenceTypes>) => {
<Component item={value}> <Component item={value}>
<Map <Map
items={composite.children} items={composite.children}
getSeparator={value.childrenSeparator || DefaultSeparator} getSeparator={value.childSeparator || DefaultSeparator}
> >
{toPreferenceItemHierarchy} {toPreferenceItemHierarchy}
</Map> </Map>