hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Fix Check for updates menu item title capitalisation (#7396)

Browse Source 
* Check for updates -> Check for Updates

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Revert debugging changes

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Adding ellipsis to every Check for Updates items

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

---------

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
This commit is contained in:
Alex Andreev 2023-03-23 11:37:10 +03:00 committed by GitHub
parent 4b1d740d61
commit 4a3f08d798
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/core/src/features/application-update/child-features/application-update-using-application-menu/main/check-for-updates-menu-item.injectable.ts
View File

@ -28,7 +28,7 @@ const checkForUpdatesMenuItemInjectable = getInjectable({
id: "check-for-updates", id: "check-for-updates",
parentId: isMac ? "mac" : "help", parentId: isMac ? "mac" : "help",
orderNumber: isMac ? 20 : 50, orderNumber: isMac ? 20 : 50,
label: "Check for updates", label: "Check for Updates...",
isShown: updatingIsEnabled, isShown: updatingIsEnabled,
onClick: () => { onClick: () => {

8
packages/core/src/features/application-update/child-features/application-update-using-tray/installing-update-using-tray.test.ts
View File

@ -146,7 +146,7 @@ describe("installing update using tray", () => {
it("name of tray item for checking updates indicates that checking is happening", () => { it("name of tray item for checking updates indicates that checking is happening", () => {
expect( expect(
builder.tray.get("check-for-updates")?.label, builder.tray.get("check-for-updates")?.label,
).toBe("Checking for updates..."); ).toBe("Checking for Updates...");
}); });
it("user cannot install update yet", () => { it("user cannot install update yet", () => {
@ -177,7 +177,7 @@ describe("installing update using tray", () => {
it("name of tray item for checking updates no longer indicates that checking is happening", () => { it("name of tray item for checking updates no longer indicates that checking is happening", () => {
expect( expect(
builder.tray.get("check-for-updates")?.label, builder.tray.get("check-for-updates")?.label,
).toBe("Check for updates"); ).toBe("Check for Updates...");
}); });
it("renders", () => { it("renders", () => {
@ -241,7 +241,7 @@ describe("installing update using tray", () => {
it("name of tray item for checking updates no longer indicates that downloading is happening", () => { it("name of tray item for checking updates no longer indicates that downloading is happening", () => {
expect( expect(
builder.tray.get("check-for-updates")?.label, builder.tray.get("check-for-updates")?.label,
).toBe("Check for updates"); ).toBe("Check for Updates...");
}); });
it("renders", () => { it("renders", () => {
@ -269,7 +269,7 @@ describe("installing update using tray", () => {
it("name of tray item for checking updates no longer indicates that downloading is happening", () => { it("name of tray item for checking updates no longer indicates that downloading is happening", () => {
expect( expect(
builder.tray.get("check-for-updates")?.label, builder.tray.get("check-for-updates")?.label,
).toBe("Check for updates"); ).toBe("Check for Updates...");
}); });
it("renders", () => { it("renders", () => {

4
packages/core/src/features/application-update/child-features/application-update-using-tray/main/tray-items/check-for-updates-tray-item.injectable.ts
View File

@ -47,10 +47,10 @@ const checkForUpdatesTrayItemInjectable = getInjectable({
} }
if (checkingForUpdatesState.value.get()) { if (checkingForUpdatesState.value.get()) {
return "Checking for updates..."; return "Checking for Updates...";
} }
return "Check for updates"; return "Check for Updates...";
}), }),
enabled: computed(() => !checkingForUpdatesState.value.get() && !downloadingUpdateState.value.get()), enabled: computed(() => !checkingForUpdatesState.value.get() && !downloadingUpdateState.value.get()),