almost working

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

src/renderer/components/+network-port-forwards/port-forward-menu.tsx

@@ -21,7 +21,7 @@
 
 import React from "react";
 import { boundMethod, cssNames } from "../../utils";
-import { openPortForward, PortForwardItem, removePortForward } from "../../port-forward";
+import { openPortForward, PortForwardItem, removePortForward, startPortForward, stopPortForward } from "../../port-forward";
 import { MenuActions, MenuActionsProps } from "../menu/menu-actions";
 import { MenuItem } from "../menu";
 import { Icon } from "../icon";
@@ -45,6 +45,26 @@ export class PortForwardMenu extends React.Component<Props> {
     }
   }
 
+  renderStartStopMenuItem() {
+    const { portForward, toolbar } = this.props;
+
+    if (portForward.status === "Active") {
+      return (
+        <MenuItem onClick={() => stopPortForward(portForward)}>
+          <Icon material="stop" tooltip="Stop port-forward" interactive={toolbar} />
+          <span className="title">Stop</span>
+        </MenuItem>
+      );
+    }
+
+    return (
+      <MenuItem onClick={() => startPortForward(portForward)}>
+        <Icon material="play_arrow" tooltip="Start port-forward" interactive={toolbar} />
+        <span className="title">Start</span>
+      </MenuItem>
+    );
+  }
+
   renderContent() {
     const { portForward, toolbar } = this.props;
 
@@ -60,6 +80,7 @@ export class PortForwardMenu extends React.Component<Props> {
           <Icon material="edit" tooltip="Change port or protocol" interactive={toolbar} />
           <span className="title">Edit</span>
         </MenuItem>
+        {this.renderStartStopMenuItem()}
       </>
     );
   }

src/renderer/components/+network-services/service-port-component.tsx

@@ -51,7 +51,7 @@ export class ServicePortComponent extends React.Component<Props> {
 
   componentDidMount() {
     disposeOnUnmount(this, [
-      reaction(() => [portForwardStore.portForwards, this.props.service], () => this.checkExistingPortForwarding()),
+      reaction(() => [portForwardStore.portForwards.slice(), this.props.service], () => this.checkExistingPortForwarding()),
     ]);
   }
 

src/renderer/components/+network/network-mixins.scss

@@ -34,6 +34,7 @@ $service-status-color-list: (
 
 $port-forward-status-color-list: (
   active: var(--colorOk),
+  disabled: var(--colorSoftError)
 );
 
 @mixin port-forward-status-colors {

src/renderer/components/+workloads-pods/pod-container-port.tsx

@@ -55,7 +55,7 @@ export class PodContainerPort extends React.Component<Props> {
 
   componentDidMount() {
     disposeOnUnmount(this, [
-      reaction(() => [portForwardStore.portForwards, this.props.pod], () => this.checkExistingPortForwarding()),
+      reaction(() => [portForwardStore.portForwards.slice(), this.props.pod], () => this.checkExistingPortForwarding()),
     ]);
   }
 

src/renderer/port-forward/port-forward-item.ts

@@ -25,7 +25,6 @@ import { autoBind } from "../../common/utils";
 
 export type forwardedPortStatus = "Active" | "Disabled";
 export interface ForwardedPort {
-  clusterId?: string;
   kind: string;
   namespace: string;
   name: string;
@@ -36,7 +35,6 @@ export interface ForwardedPort {
 }
   
 export class PortForwardItem implements ItemObject {
-  clusterId: string;
   kind: string;
   namespace: string;
   name: string;
@@ -46,7 +44,6 @@ export class PortForwardItem implements ItemObject {
   status: forwardedPortStatus;
   
   constructor(pf: ForwardedPort) {
-    this.clusterId = pf.clusterId;
     this.kind = pf.kind;
     this.namespace = pf.namespace;
     this.name = pf.name;

src/renderer/port-forward/port-forward-utils.ts

@@ -35,7 +35,6 @@ export function openPortForward(portForward: ForwardedPort) {
   openExternal(browseTo)
     .catch(error => {
       logger.error(`failed to open in browser: ${error}`, {
-        clusterId: portForward.clusterId,
         port: portForward.port,
         kind: portForward.kind,
         namespace: portForward.namespace,

src/renderer/port-forward/port-forward.store.ts

@@ -53,7 +53,7 @@ export class PortForwardStore extends ItemStore<PortForwardItem> {
 
       for (const result of results) {
         if (result.status === "rejected") {
-          Notifications.info("One or more port-forwards could not be started");
+          Notifications.error("One or more port-forwards could not be started", { timeout: 10_000 });
           
           return;
         }
@@ -105,7 +105,6 @@ interface PortForwardsResult {
 
 function portForwardsEqual(portForward: ForwardedPort) {
   return (pf: ForwardedPort) => (
-    pf.clusterId == portForward.clusterId &&
     pf.kind == portForward.kind &&
     pf.name == portForward.name &&
     pf.namespace == portForward.namespace &&
@@ -118,41 +117,65 @@ function findPortForward(portForward: ForwardedPort) {
 
 }
 
-export async function addPortForward(portForward: ForwardedPort): Promise<number> {
+export async function startPortForward(portForward: ForwardedPort): Promise<number> {
+  const pf = findPortForward(portForward);
+  
+  if (!pf) {
+    const error = new Error("port-forward not found");
+
+    logger.warn("[PORT-FORWARD-STORE] Error starting port-forward:", error, portForward);
+    throw(error);    
+  }
+
   const { port, forwardPort } = portForward;
   let response: PortForwardResult;
 
+  try {
+    const protocol = portForward.protocol ?? "http";
+
+    response = await apiBase.post<PortForwardResult>(`/pods/port-forward/${portForward.namespace}/${portForward.kind}/${portForward.name}`, { query: { port, forwardPort, protocol }});
+
+    // expecting the received port to be the specified port, unless the specified port is 0, which indicates any available port is suitable
+    if (portForward.forwardPort && response?.port && response.port != +portForward.forwardPort) {
+      logger.warn(`[PORT-FORWARD-STORE] specified ${portForward.forwardPort}, got ${response.port}`);
+    }
+
+    pf.forwardPort = response.port;
+    pf.status = "Active";
+  } catch (error) {
+    logger.warn("[PORT-FORWARD-STORE] Error adding port-forward:", error, portForward);
+    pf.status = "Disabled";
+    throw (error);
+  }
+
+  return response?.port;
+}
+
+export async function addPortForward(portForward: ForwardedPort): Promise<number> {
   const pf = findPortForward(portForward);
 
   if (pf) {
     return pf.forwardPort;
   }
 
+  portForwardStore.portForwards.push(new PortForwardItem(portForward));
+
   if (!portForward.status) {
     portForward.status = "Active";
   }
 
   try {
     if (portForward.status === "Active") {
-      const protocol = portForward.protocol ?? "http";
-
-      response = await apiBase.post<PortForwardResult>(`/pods/port-forward/${portForward.namespace}/${portForward.kind}/${portForward.name}`, { query: { port, forwardPort, protocol }});
-
-      // expecting the received port to be the specified port, unless the specified port is 0, which indicates any available port is suitable
-      if (portForward.forwardPort && response?.port && response.port != +portForward.forwardPort) {
-        logger.warn(`[PORT-FORWARD-STORE] specified ${portForward.forwardPort} got ${response.port}`);
-      }
-      portForward.forwardPort = response.port;
+      const port = await startPortForward(portForward);
+      
+      portForward.forwardPort = port;
     }
   } catch (error) {
     logger.warn("[PORT-FORWARD-STORE] Error starting port-forward:", error, portForward);
-    portForward.status = "Disabled";
     throw(error);
-  } finally {
-    portForwardStore.portForwards.push(new PortForwardItem(portForward));
   }
 
-  return response?.port;
+  return portForward.forwardPort;
 }
 
 export async function getActivePortForward(portForward: ForwardedPort): Promise<number> {
@@ -180,12 +203,15 @@ export async function getPortForward(portForward: ForwardedPort): Promise<number
     throw (error);
   }
 
-  let port = pf.port;
+  let port = pf.forwardPort;
 
   try {
     port = await getActivePortForward(portForward);
     pf.status = "Active";
-    pf.forwardPort = port;
+
+    if (port !== pf.forwardPort) {
+      logger.warn(`[PORT-FORWARD-STORE] local port, expected ${pf.forwardPort}, got ${port}`);
+    }
   } catch (error) {
     // port is not active
     pf.status = "Disabled";
@@ -205,7 +231,17 @@ export async function modifyPortForward(portForward: ForwardedPort, desiredPort:
 }
 
 
-export async function removeActivePortForward(portForward: ForwardedPort) {
+export async function stopPortForward(portForward: ForwardedPort) {
+  const pf = findPortForward(portForward);
+  
+  if (!pf) {
+    const error = new Error("port-forward not found");
+
+    logger.warn("[PORT-FORWARD-STORE] Error getting port-forward:", error, portForward);
+    
+    return;
+  }
+
   const { port, forwardPort } = portForward;
 
   try {
@@ -215,27 +251,29 @@ export async function removeActivePortForward(portForward: ForwardedPort) {
     logger.warn("[PORT-FORWARD-STORE] Error removing active port-forward:", error, portForward);
     throw (error);
   }
+
+  pf.status = "Disabled";
 }
 
 export async function removePortForward(portForward: ForwardedPort) {
   const pf = findPortForward(portForward);
-  
+
   if (!pf) {
     const error = new Error("port-forward not found");
 
     logger.warn("[PORT-FORWARD-STORE] Error getting port-forward:", error, portForward);
-    throw (error);
+    
+    return;
   }
 
   try {
-    await removeActivePortForward(portForward);
+    await stopPortForward(portForward);
   } catch (error) {
     if (pf.status === "Active") {
       logger.warn("[PORT-FORWARD-STORE] Error removing port-forward:", error, portForward);
     }
   }
-  portForwardStore.portForwards.filter(item => item !== pf);
-  console.log("portForwards:", portForwardStore.portForwards);
+  portForwardStore.portForwards = portForwardStore.portForwards.filter(item => item !== pf);
 }
 
 export async function getActivePortForwards(clusterId?: string): Promise<ForwardedPort[]> {