hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Clarify retried variable/comment

Browse Source 
Signed-off-by: Panu Horsmalahti <phorsmalahti@mirantis.com>
This commit is contained in:
Panu Horsmalahti 2021-11-24 12:42:35 +02:00
parent 2bef055247
commit 5cbb5101f7
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/common/k8s-api/kube-api.ts
View File

@ -559,8 +559,8 @@ export class KubeApi<T extends KubeObject> {
responsePromise
.then(response => {
// True if the watch was retried
let retried = false;
// True if the current watch request was retried
let requestRetried = false;
if (!response.ok) {
logger.warn(`[KUBE-API] watch (${watchId}) error response ${watchUrl}`, { status: response.status });
@ -573,7 +573,7 @@ export class KubeApi<T extends KubeObject> {
if (timeout) {
setTimeout(() => {
// We only retry if we haven't retried, haven't aborted and haven't received k8s error
if (retried || abortController.signal.aborted || errorReceived) {
if (requestRetried || abortController.signal.aborted || errorReceived) {
return;
}
@ -582,7 +582,7 @@ export class KubeApi<T extends KubeObject> {
logger.info(`[KUBE-API] Watch timeout set, but not retried, retrying now`);
retried = true;
requestRetried = true;
// Clearing out any possible timeout, although we don't expect this to be set
clearTimeout(timedRetry);
@ -595,13 +595,13 @@ export class KubeApi<T extends KubeObject> {
response.body.on(eventName, () => {
// We only retry if we haven't retried, haven't aborted and haven't received k8s error
// kubernetes errors (=errorReceived set) should be handled in a callback
if (retried || abortController.signal.aborted || errorReceived) {
if (requestRetried || abortController.signal.aborted || errorReceived) {
return;
}
logger.info(`[KUBE-API] watch (${watchId}) ${eventName} ${watchUrl}`);
retried = true;
requestRetried = true;
clearTimeout(timedRetry);
timedRetry = setTimeout(() => { // we did not get any kubernetes errors so let's retry