1
0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00

added checkbox for optionally opening browser in the port-forward dialog (#4068)

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
This commit is contained in:
Jim Ehrismann 2021-10-19 11:06:02 -04:00 committed by GitHub
parent 64175b24e0
commit 5ffa1de7e6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -32,6 +32,7 @@ import { cssNames } from "../utils";
import { addPortForward, modifyPortForward } from "./port-forward.store";
import type { ForwardedPort } from "./port-forward-item";
import { openPortForward } from ".";
import { Checkbox } from "../components/checkbox";
interface Props extends Partial<DialogProps> {
}
@ -57,7 +58,7 @@ export class PortForwardDialog extends Component<Props> {
makeObservable(this);
}
static open(portForward: ForwardedPort, options : PortForwardDialogOpenOptions = { openInBrowser: false }) {
static open(portForward: ForwardedPort, options: PortForwardDialogOpenOptions = { openInBrowser: false }) {
dialogState.isOpen = true;
dialogState.data = portForward;
dialogState.openInBrowser = options.openInBrowser;
@ -105,7 +106,7 @@ export class PortForwardDialog extends Component<Props> {
portForward.forwardPort = desiredPort;
port = await addPortForward(portForward);
}
if (dialogState.openInBrowser) {
portForward.forwardPort = port;
openPortForward(portForward);
@ -120,7 +121,7 @@ export class PortForwardDialog extends Component<Props> {
renderContents() {
return (
<>
<div className="flex gaps align-center">
<div className="flex column gaps align-left">
<div className="input-container flex align-center">
<div className="current-port" data-testid="current-port">
Local port to forward from:
@ -134,6 +135,13 @@ export class PortForwardDialog extends Component<Props> {
onChange={this.changePort}
/>
</div>
<Checkbox
data-testid="port-forward-open"
theme="light"
label="Open in Browser"
value={dialogState.openInBrowser}
onChange={value => dialogState.openInBrowser = value}
/>
</div>
</>
);