Make sure all logging has a message, output less errors when prometheus fails

Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton committed 2022-07-18 16:25:03 -04:00
1 parent 3d3b3ffb7f
commit 6615d1bab8
4 files changed
+7 -8

No files matched your search

+1 -1
View File
@@ -78,4 +78,4 @@ export default winston.createLogger({
format.simple(), format.simple(),
), ),
transports, transports,
}); }) as Logger;
+2 -3
View File
@@ -132,8 +132,7 @@ export class Kubectl {
return this.path; return this.path;
} catch (err) { } catch (err) {
logger.error("Failed to ensure kubectl, fallback to the bundled version"); logger.error("Failed to ensure kubectl, fallback to the bundled version", err);
logger.error(err);
return this.getBundledPath(); return this.getBundledPath();
} }
@@ -146,7 +145,7 @@ export class Kubectl {
return this.dirname; return this.dirname;
} catch (err) { } catch (err) {
logger.error(err); logger.error("Failed to get biniary directory", err);
return ""; return "";
} }
@@ -31,11 +31,11 @@ const loadMetricsFor = (getMetrics: GetMetrics) => async (promQueries: string[],
} catch (error) { } catch (error) {
if (isRequestError(error)) { if (isRequestError(error)) {
if (lastAttempt || (error.statusCode && error.statusCode >= 400 && error.statusCode < 500)) { if (lastAttempt || (error.statusCode && error.statusCode >= 400 && error.statusCode < 500)) {
logger.error("[Metrics]: metrics not available", error?.response ? error.response?.body : error); throw new Error("Metrics not available", { cause: error });
throw new Error("Metrics not available");
} }
} else if (error instanceof Error) {
throw new Error("Metrics not available", { cause: error });
} else { } else {
logger.error("[Metrics]: metrics not available", error);
throw new Error("Metrics not available"); throw new Error("Metrics not available");
} }
+1 -1
View File
@@ -121,7 +121,7 @@ export class ThemeStore {
try { try {
this.applyActiveTheme(); this.applyActiveTheme();
} catch (err) { } catch (err) {
logger.error(err); logger.error(`Failed to apply active theme: ${err}`);
this.dependencies.userStore.resetTheme(); this.dependencies.userStore.resetTheme();
} }
}, { }, {