hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Make sure all logging has a message, output less errors when prometheus fails

Browse Source 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2022-07-18 16:25:03 -04:00
parent 3d3b3ffb7f
commit 6615d1bab8
4 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/common/logger.ts
View File

@ -78,4 +78,4 @@ export default winston.createLogger({
format.simple(), format.simple(),
), ),
transports, transports,
}); }) as Logger;

5
src/main/kubectl/kubectl.ts
View File

@ -132,8 +132,7 @@ export class Kubectl {
return this.path; return this.path;
} catch (err) { } catch (err) {
logger.error("Failed to ensure kubectl, fallback to the bundled version"); logger.error("Failed to ensure kubectl, fallback to the bundled version", err);
logger.error(err);
return this.getBundledPath(); return this.getBundledPath();
} }
@ -146,7 +145,7 @@ export class Kubectl {
return this.dirname; return this.dirname;
} catch (err) { } catch (err) {
logger.error(err); logger.error("Failed to get biniary directory", err);
return ""; return "";
} }

6
src/main/routes/metrics/add-metrics-route.injectable.ts
View File

@ -31,11 +31,11 @@ const loadMetricsFor = (getMetrics: GetMetrics) => async (promQueries: string[],
} catch (error) { } catch (error) {
if (isRequestError(error)) { if (isRequestError(error)) {
if (lastAttempt || (error.statusCode && error.statusCode >= 400 && error.statusCode < 500)) { if (lastAttempt || (error.statusCode && error.statusCode >= 400 && error.statusCode < 500)) {
logger.error("[Metrics]: metrics not available", error?.response ? error.response?.body : error); throw new Error("Metrics not available", { cause: error });
throw new Error("Metrics not available");
} }
} else if (error instanceof Error) {
throw new Error("Metrics not available", { cause: error });
} else { } else {
logger.error("[Metrics]: metrics not available", error);
throw new Error("Metrics not available"); throw new Error("Metrics not available");
} }

2
src/renderer/themes/store.ts
View File

@ -121,7 +121,7 @@ export class ThemeStore {
try { try {
this.applyActiveTheme(); this.applyActiveTheme();
} catch (err) { } catch (err) {
logger.error(err); logger.error(`Failed to apply active theme: ${err}`);
this.dependencies.userStore.resetTheme(); this.dependencies.userStore.resetTheme();
} }
}, { }, {