mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
Return extensions that failed to be activated from loadExtensions to match old behavior.
Signed-off-by: Panu Horsmalahti <phorsmalahti@mirantis.com>
This commit is contained in:
parent
199e96a706
commit
66b8a9130c
@ -327,7 +327,6 @@ export class ExtensionLoader {
|
|||||||
installedExtension: extension,
|
installedExtension: extension,
|
||||||
isBundled: extension.isBundled,
|
isBundled: extension.isBundled,
|
||||||
activated: instance.activate(),
|
activated: instance.activate(),
|
||||||
activationError: null,
|
|
||||||
};
|
};
|
||||||
} catch (err) {
|
} catch (err) {
|
||||||
logger.error(`${logModule}: error loading extension`, { ext: extension, err });
|
logger.error(`${logModule}: error loading extension`, { ext: extension, err });
|
||||||
@ -347,7 +346,6 @@ export class ExtensionLoader {
|
|||||||
extensions.map(extension =>
|
extensions.map(extension =>
|
||||||
// If extension activation fails, log error
|
// If extension activation fails, log error
|
||||||
extension.activated.catch((error) => {
|
extension.activated.catch((error) => {
|
||||||
extension.activationError = error;
|
|
||||||
logger.error(`${logModule}: activation extension error`, { ext: extension.installedExtension, error });
|
logger.error(`${logModule}: activation extension error`, { ext: extension.installedExtension, error });
|
||||||
}),
|
}),
|
||||||
),
|
),
|
||||||
@ -355,7 +353,6 @@ export class ExtensionLoader {
|
|||||||
|
|
||||||
// Return ExtensionLoading[]
|
// Return ExtensionLoading[]
|
||||||
return extensions
|
return extensions
|
||||||
.filter(extension =>!extension.activationError)
|
|
||||||
.map(extension => {
|
.map(extension => {
|
||||||
const loaded = extension.instance.enable(register).catch((err) => {
|
const loaded = extension.instance.enable(register).catch((err) => {
|
||||||
logger.error(`${logModule}: failed to enable`, { ext: extension, err });
|
logger.error(`${logModule}: failed to enable`, { ext: extension, err });
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user