hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Simplify legacyRegisterApi when working in behaviour unit tests

Browse Source 
- Don't emit within main environment as there should be no auto
  registering there

Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2022-05-05 09:44:32 -04:00
parent 24a9e8c771
commit 715de4637c
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/common/k8s-api/__tests__/kube-api.test.ts
View File

@ -12,7 +12,7 @@ import { PassThrough } from "stream";
import { ApiManager } from "../api-manager"; import { ApiManager } from "../api-manager";
import type { FetchMock } from "jest-fetch-mock/types"; import type { FetchMock } from "jest-fetch-mock/types";
import { DeploymentApi, Ingress, IngressApi, Pod, PodApi } from "../endpoints"; import { DeploymentApi, Ingress, IngressApi, Pod, PodApi } from "../endpoints";
import { getDiForUnitTesting } from "../../../main/getDiForUnitTesting"; import { getDiForUnitTesting } from "../../../renderer/getDiForUnitTesting";
import apiManagerInjectable from "../api-manager/manager.injectable"; import apiManagerInjectable from "../api-manager/manager.injectable";
import autoRegistrationInjectable from "../api-manager/auto-registration.injectable"; import autoRegistrationInjectable from "../api-manager/auto-registration.injectable";

10
src/common/k8s-api/kube-api.ts
View File

@ -313,14 +313,12 @@ export interface DeleteResourceDescriptor extends ResourceDescriptor {
*/ */
function legacyRegisterApi(api: KubeApi<any, any>): void { function legacyRegisterApi(api: KubeApi<any, any>): void {
// Try both just in case, because we might be in a testing environment // Try both just in case, because we might be in a testing environment
for (const env of [Environments.main, Environments.renderer]) { const di = getEnvironmentSpecificLegacyGlobalDiForExtensionApi(Environments.renderer);
const di = getEnvironmentSpecificLegacyGlobalDiForExtensionApi(env);
if (di) { if (di) {
const autoRegistrationEmitter = di.inject(autoRegistrationEmitterInjectable); const autoRegistrationEmitter = di.inject(autoRegistrationEmitterInjectable);
autoRegistrationEmitter.emit("kubeApi", api); autoRegistrationEmitter.emit("kubeApi", api);
}
} }
} }