hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Resolve PR comments

Browse Source 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2022-10-11 10:00:00 -04:00
parent 0bcd7160b9
commit 72c18e376a
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/common/fetch/timeout-controller.ts
View File

@ -5,7 +5,7 @@
/**
* Creates an AbortController with an associated timeout
* @param timeout The number of miliseconds before this controller will auto abort
* @param timeout The number of milliseconds before this controller will auto abort
*/
export function withTimeout(timeout: number): AbortController {
const controller = new AbortController();

12
src/renderer/components/+extensions/attempt-install-by-info.injectable.tsx
View File

@ -65,13 +65,13 @@ const attemptInstallByInfoInjectable = getInjectable({
const result = await downloadJson(registryUrl);
if (!result.callWasSuccessful) {
showErrorNotification(`Failed to get registry information for that extension: ${result.error}`);
showErrorNotification(`Failed to get registry information for extension: ${result.error}`);
return disposer();
}
if (!isObject(result.response) || Array.isArray(result.response)) {
showErrorNotification("Failed to get registry information for that extension");
showErrorNotification("Failed to get registry information for extension");
return disposer();
}
@ -79,7 +79,7 @@ const attemptInstallByInfoInjectable = getInjectable({
if (result.response.error || !isObject(result.response.versions)) {
const message = result.response.error ? `: ${result.response.error}` : "";
showErrorNotification(`Failed to get registry information for that extension${message}`);
showErrorNotification(`Failed to get registry information for extension${message}`);
return disposer();
}
@ -89,10 +89,10 @@ const attemptInstallByInfoInjectable = getInjectable({
if (error instanceof SyntaxError) {
// assume invalid JSON
logger.warn("Set registry has invalid json", { url: baseUrl }, error);
showErrorNotification("Failed to get valid registry information for that extension. Registry did not return valid JSON");
showErrorNotification("Failed to get valid registry information for extension. Registry did not return valid JSON");
} else {
logger.error("Failed to download registry information", error);
showErrorNotification(`Failed to get valid registry information for that extension. ${error}`);
showErrorNotification(`Failed to get valid registry information for extension. ${error}`);
}
return disposer();
@ -151,7 +151,7 @@ const attemptInstallByInfoInjectable = getInjectable({
}
if (!version) {
logger.error("No versions supplied for that extension", { name });
logger.error("No versions supplied for extension", { name });
showErrorNotification(`No versions found for ${name}`);
return disposer();