hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Revert accidental breaking change in Extension API (#4904)

Browse Source 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
This commit is contained in:
Janne Savolainen 2022-02-23 13:26:14 +02:00 committed by GitHub
parent 12a6bd8512
commit 81819dbbe9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/common/k8s-api/kube-object.store.ts
View File

@ -312,14 +312,14 @@ export abstract class KubeObjectStore<T extends KubeObject> extends ItemStore<T>
return this.api.create(params, data); return this.api.create(params, data);
} }
create = async (params: { name: string; namespace?: string }, data?: Partial<T>): Promise<T> => { async create(params: { name: string; namespace?: string }, data?: Partial<T>): Promise<T> {
const newItem = await this.createItem(params, data); const newItem = await this.createItem(params, data);
const items = this.sortItems([...this.items, newItem]); const items = this.sortItems([...this.items, newItem]);
this.items.replace(items); this.items.replace(items);
return newItem; return newItem;
}; }
private postUpdate(rawItem: KubeJsonApiData): T { private postUpdate(rawItem: KubeJsonApiData): T {
const newItem = new this.api.objectConstructor(rawItem); const newItem = new this.api.objectConstructor(rawItem);

9
src/renderer/components/+namespaces/add-namespace-dialog.tsx
View File

@ -19,6 +19,7 @@ import namespaceStoreInjectable from "./namespace-store/namespace-store.injectab
import type { AddNamespaceDialogModel } from "./add-namespace-dialog-model/add-namespace-dialog-model"; import type { AddNamespaceDialogModel } from "./add-namespace-dialog-model/add-namespace-dialog-model";
import addNamespaceDialogModelInjectable import addNamespaceDialogModelInjectable
from "./add-namespace-dialog-model/add-namespace-dialog-model.injectable"; from "./add-namespace-dialog-model/add-namespace-dialog-model.injectable";
import type { NamespaceStore } from "./namespace-store/namespace.store";
interface Props extends DialogProps { interface Props extends DialogProps {
onSuccess?(ns: Namespace): void; onSuccess?(ns: Namespace): void;
@ -26,7 +27,7 @@ interface Props extends DialogProps {
} }
interface Dependencies { interface Dependencies {
createNamespace: (params: { name: string }) => Promise<Namespace>; namespaceStore: NamespaceStore;
model: AddNamespaceDialogModel; model: AddNamespaceDialogModel;
} }
@ -48,7 +49,7 @@ class NonInjectedAddNamespaceDialog extends React.Component<Props & Dependencies
const { onSuccess, onError } = this.props; const { onSuccess, onError } = this.props;
try { try {
const created = await this.props.createNamespace({ name: namespace }); const created = await this.props.namespaceStore.create({ name: namespace });
onSuccess?.(created); onSuccess?.(created);
this.props.model.close(); this.props.model.close();
@ -59,7 +60,7 @@ class NonInjectedAddNamespaceDialog extends React.Component<Props & Dependencies
}; };
render() { render() {
const { model, createNamespace, ...dialogProps } = this.props; const { model, namespaceStore, ...dialogProps } = this.props;
const { namespace } = this; const { namespace } = this;
const header = <h5>Create Namespace</h5>; const header = <h5>Create Namespace</h5>;
@ -97,7 +98,7 @@ export const AddNamespaceDialog = withInjectables<Dependencies, Props>(
{ {
getProps: (di, props) => ({ getProps: (di, props) => ({
createNamespace: di.inject(namespaceStoreInjectable).create, namespaceStore: di.inject(namespaceStoreInjectable),
model: di.inject(addNamespaceDialogModelInjectable), model: di.inject(addNamespaceDialogModelInjectable),
...props, ...props,