hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Fix crash when finding CRD's preferred version

Browse Source 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2021-11-12 16:55:47 -05:00
parent 085d08cefd
commit 840270622e
3 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/common/k8s-api/endpoints/crd.api.ts
View File

@ -153,11 +153,7 @@ export class CustomResourceDefinition extends KubeObject {
// Prefer the modern `versions` over the legacy `version`
if (this.spec.versions) {
for (const version of this.spec.versions) {
/**
* If the version is not served then 404 errors will occur
* We should also prefer the storage version
*/
if (version.served && version.storage) {
if (version.storage) {
return version;
}
}

9
src/renderer/components/+custom-resources/crd-resources.tsx
View File

@ -129,6 +129,15 @@ export class CrdResources extends React.Component<Props> {
}),
crdInstance.getAge(),
]}
renderFailedToLoadDetails={() => {
if (!crd.getPreferedVersion().served) {
return (
<p>Prefered version is not served.</p>
);
}
return undefined;
}}
/>
);
}

3
src/renderer/components/item-object-list/item-list-layout.tsx
View File

@ -97,6 +97,7 @@ export interface ItemListLayoutProps<I extends ItemObject> {
// other
customizeRemoveDialog?: (selectedItems: I[]) => Partial<ConfirmDialogParams>;
renderFooter?: (parent: ItemListLayout<I>) => React.ReactNode;
renderFailedToLoadDetails?: () => React.ReactNode;
filterCallbacks?: ItemsFilters<I>;
}
@ -322,7 +323,7 @@ export class ItemListLayout<I extends ItemObject> extends React.Component<ItemLi
renderNoItems() {
if (this.failedToLoad) {
return <NoItems>Failed to load items.</NoItems>;
return <NoItems>Failed to load items.{this.props.renderFailedToLoadDetails?.()}</NoItems>;
}
if (!this.isReady) {