hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Fix pr comments. Cleanup function. Simplify reaction

Browse Source 
Signed-off-by: DmitriyNoa <dmytro.zharkov@gmail.com>
This commit is contained in:
DmitriyNoa 2022-01-28 16:28:17 +01:00
parent 948b278360
commit 8674f3ecf1
2 changed files with 7 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/renderer/components/dock/dock-store/dock.store.ts
View File

@ -233,15 +233,6 @@ export class DockStore implements DockStorageState {
}), reactionOpts);
}
onTabsNumberChange(callback: (evt: DockTabsNumberEvent) => void) {
return reaction(() => this.tabsNumber, ((currentTabsNumber, previousTabsNumber) => {
callback({
currentTabsNumber,
previousTabsNumber,
});
}));
}
hasTabs() {
return this.tabs.length > 0;
}

10
src/renderer/components/dock/dock-tabs.tsx
View File

@ -4,6 +4,7 @@
*/
import React, { Fragment, useRef, useEffect, useState, UIEvent } from "react";
import { reaction } from "mobx";
import { Icon } from "../icon";
import { Tabs } from "../tabs/tabs";
import { DockTab } from "./dock-tab";
@ -109,9 +110,12 @@ export const DockTabs = ({ tabs, autoFocus, selectedTab, onChangeTab, dockStore
window.addEventListener("resize", onWindowResize);
// update scroll state if tabs numbers has changed
dockStore.onTabsNumberChange(() => {
updateStateValues();
});
reaction(() => dockStore.tabsNumber, updateStateValues);
return () => {
window.removeEventListener("resize", onWindowResize);
elem.current.removeEventListener("scroll", updateScrollPosition);
};
}, []);
return (