hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

add support for grabbing tagged npm versions

Browse Source 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2020-12-10 10:59:13 -05:00
parent caa1d31e09
commit 9202db5c20
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/extensions/extension-loader.ts
View File

@ -307,6 +307,8 @@ export class ExtensionLoader {
const [, extension ] = instanceEntry; const [, extension ] = instanceEntry;
if (extension.manifest.name === name) { if (extension.manifest.name === name) {
console.log(`found extension ${name}: isEnabled => ${extension.isEnabled}`);
return extension.isEnabled; return extension.isEnabled;
} }
} }
@ -319,9 +321,9 @@ export class ExtensionLoader {
* Get url to the tarball of the extension package. Assumes package is found from npm regisry. * Get url to the tarball of the extension package. Assumes package is found from npm regisry.
* @param packageName e.g. "@mirantis/lens-extension-cc" * @param packageName e.g. "@mirantis/lens-extension-cc"
*/ */
getNpmPackageTarballUrl(packageName: string): Promise<string> { getNpmPackageTarballUrl(packageName: string, tag = ""): Promise<string> {
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
const command = [extensionInstaller.npmPath, "view", packageName, "dist.tarball", "--silent"]; const command = [extensionInstaller.npmPath, "view", `${packageName}${tag}`, "dist.tarball", "--silent"];
exec(command.join(" "), { exec(command.join(" "), {
encoding: "utf8" encoding: "utf8"

2
src/renderer/components/+extensions/extensions.tsx
View File

@ -358,7 +358,7 @@ async function installFromSelectFileDialog() {
* @param packageName e.g. "@publisher/extension-name" * @param packageName e.g. "@publisher/extension-name"
*/ */
export async function installFromNpm(packageName: string) { export async function installFromNpm(packageName: string) {
const tarballUrl = await extensionLoader.getNpmPackageTarballUrl(packageName); const tarballUrl = await extensionLoader.getNpmPackageTarballUrl(packageName, "@hackweek");
Notifications.info(`Installing ${packageName}`); Notifications.info(`Installing ${packageName}`);