hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

toggleDetails -> toggleKubeDetailsPane is more specific

Browse Source 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2022-05-06 09:27:49 -04:00
parent 5dee0db95e
commit 93d59d6dfe
3 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/renderer/components/+cluster/cluster-issues.tsx
View File

@ -25,9 +25,9 @@ import apiManagerInjectable from "../../../common/k8s-api/api-manager/manager.in
import eventStoreInjectable from "../+events/store.injectable";
import nodeStoreInjectable from "../+nodes/store.injectable";
import type { PageParam } from "../../navigation";
import type { ToggleDetails } from "../kube-detail-params/toggle-details.injectable";
import type { ToggleKubeDetailsPane } from "../kube-detail-params/toggle-details.injectable";
import kubeSelectedUrlParamInjectable from "../kube-detail-params/kube-selected-url.injectable";
import toggleDetailsInjectable from "../kube-detail-params/toggle-details.injectable";
import toggleKubeDetailsPaneInjectable from "../kube-detail-params/toggle-details.injectable";
export interface ClusterIssuesProps {
className?: string;
@ -53,7 +53,7 @@ interface Dependencies {
eventStore: EventStore;
apiManager: ApiManager;
kubeSelectedUrlParam: PageParam<string>;
toggleDetails: ToggleDetails;
toggleKubeDetailsPane: ToggleKubeDetailsPane;
}
@observer
@ -91,7 +91,7 @@ class NonInjectedClusterIssues extends React.Component<ClusterIssuesProps & Depe
getTableRow = (uid: string) => {
const { warnings } = this;
const { kubeSelectedUrlParam, toggleDetails } = this.props;
const { kubeSelectedUrlParam, toggleKubeDetailsPane: toggleDetails } = this.props;
const warning = warnings.find(warn => warn.getId() == uid);
if (!warning) {
@ -196,6 +196,6 @@ export const ClusterIssues = withInjectables<Dependencies, ClusterIssuesProps>(N
eventStore: di.inject(eventStoreInjectable),
nodeStore: di.inject(nodeStoreInjectable),
kubeSelectedUrlParam: di.inject(kubeSelectedUrlParamInjectable),
toggleDetails: di.inject(toggleDetailsInjectable),
toggleKubeDetailsPane: di.inject(toggleKubeDetailsPaneInjectable),
}),
});

10
src/renderer/components/kube-detail-params/toggle-details.injectable.ts
View File

@ -7,7 +7,7 @@ import hideDetailsInjectable from "./hide-details.injectable";
import kubeSelectedUrlParamInjectable from "./kube-selected-url.injectable";
import showDetailsInjectable from "./show-details.injectable";
export interface ToggleDetails {
export interface ToggleKubeDetailsPane {
/**
* @param selfLink The selfLink of the kube object to toggle the details panal of
* @param resetSelected If true then the selected kube object (for the current list view) will be reset
@ -20,9 +20,9 @@ export interface ToggleDetails {
(selfLink: string | undefined, resetSelected?: boolean): void;
}
const toggleDetailsInjectable = getInjectable({
id: "toggle-details",
instantiate: (di): ToggleDetails => {
const toggleKubeDetailsPaneInjectable = getInjectable({
id: "toggle-kube-details-pane",
instantiate: (di): ToggleKubeDetailsPane => {
const showDetails = di.inject(showDetailsInjectable);
const hideDetails = di.inject(hideDetailsInjectable);
const kubeSelectedUrlParam = di.inject(kubeSelectedUrlParamInjectable);
@ -39,4 +39,4 @@ const toggleDetailsInjectable = getInjectable({
},
});
export default toggleDetailsInjectable;
export default toggleKubeDetailsPaneInjectable;

10
src/renderer/components/kube-object-list-layout/kube-object-list-layout.tsx
View File

@ -26,9 +26,9 @@ import type { SubscribableStore, SubscribeStores } from "../../kube-watch-api/ku
import type { KubeApi } from "../../../common/k8s-api/kube-api";
import subscribeStoresInjectable from "../../kube-watch-api/subscribe-stores.injectable";
import type { PageParam } from "../../navigation";
import type { ToggleDetails } from "../kube-detail-params/toggle-details.injectable";
import type { ToggleKubeDetailsPane } from "../kube-detail-params/toggle-details.injectable";
import kubeSelectedUrlParamInjectable from "../kube-detail-params/kube-selected-url.injectable";
import toggleDetailsInjectable from "../kube-detail-params/toggle-details.injectable";
import toggleKubeDetailsPaneInjectable from "../kube-detail-params/toggle-details.injectable";
export interface KubeObjectListLayoutProps<
K extends KubeObject,
@ -46,7 +46,7 @@ interface Dependencies {
clusterFrameContext: ClusterFrameContext;
subscribeToStores: SubscribeStores;
kubeSelectedUrlParam: PageParam<string>;
toggleDetails: ToggleDetails;
toggleKubeDetailsPane: ToggleKubeDetailsPane;
}
@observer
@ -114,7 +114,7 @@ class NonInjectedKubeObjectListLayout<
store,
items,
dependentStores,
toggleDetails,
toggleKubeDetailsPane: toggleDetails,
onDetails,
...layoutProps
} = this.props;
@ -166,7 +166,7 @@ export const KubeObjectListLayout = withInjectables<
clusterFrameContext: di.inject(clusterFrameContextInjectable),
subscribeToStores: di.inject(subscribeStoresInjectable),
kubeSelectedUrlParam: di.inject(kubeSelectedUrlParamInjectable),
toggleDetails: di.inject(toggleDetailsInjectable),
toggleKubeDetailsPane: di.inject(toggleKubeDetailsPaneInjectable),
}),
}) as <
K extends KubeObject,