hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Extract being maybe Showable as explicit composable responsibility

Browse Source 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
This commit is contained in:
Iku-turso 2022-10-24 14:19:35 +03:00
parent fc2cf4f457
commit 95cba7a061
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/common/utils/composable-responsibilities/showable/showable.ts
View File

@ -10,6 +10,8 @@ export interface Showable {
isShown: IComputedValue<boolean> | boolean;
}
export type MaybeShowable = Partial<Showable>;
export const isShown = (showable: Showable | {}) => {
if (!("isShown" in showable)) {
return true;

4
src/features/application-menu/main/menu-items/application-menu-item-injection-token.ts
View File

@ -6,7 +6,7 @@ import { getInjectionToken } from "@ogre-tools/injectable";
import type { BrowserWindow, KeyboardEvent, MenuItemConstructorOptions, MenuItem as ElectronMenuItem } from "electron";
import type { SetOptional } from "type-fest";
import type { ChildOfParentComposite, ParentOfChildComposite } from "../../../../common/utils/composite/interfaces";
import type { Showable } from "../../../../common/utils/composable-responsibilities/showable/showable";
import type { MaybeShowable } from "../../../../common/utils/composable-responsibilities/showable/showable";
import type { Discriminable } from "../../../../common/utils/composable-responsibilities/discriminable/discriminable";
import type { Orderable } from "../../../../common/utils/composable-responsibilities/orderable/orderable";
@ -31,7 +31,7 @@ type ApplicationMenuItemType<T extends string> =
& Discriminable<T>
& ParentOfChildComposite
& ChildOfParentComposite
& Showable
& MaybeShowable
& Orderable;
export type TopLevelMenu =