hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Resolve PR comments

Browse Source 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2022-06-13 09:09:42 -04:00
parent 38d28b64cf
commit 9a4e9f8ec7
3 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/main/protocol-handler/__test__/router.test.ts
View File

@ -54,12 +54,12 @@ describe("protocol router tests", () => {
lpr.rendererLoaded = true; lpr.rendererLoaded = true;
}); });
it("should throw on non-lens URLS", async () => { it("should broadcast invalid protocol on non-lens URLs", async () => {
await lpr.route("https://google.ca"); await lpr.route("https://google.ca");
expect(broadcastMessage).toBeCalledWith(ProtocolHandlerInvalid, "invalid protocol", "https://google.ca"); expect(broadcastMessage).toBeCalledWith(ProtocolHandlerInvalid, "invalid protocol", "https://google.ca");
}); });
it("should throw when host not internal or extension", async () => { it("should broadcast invalid host on non internal or non extension URLs", async () => {
await lpr.route("lens://foobar"); await lpr.route("lens://foobar");
expect(broadcastMessage).toBeCalledWith(ProtocolHandlerInvalid, "invalid host", "lens://foobar"); expect(broadcastMessage).toBeCalledWith(ProtocolHandlerInvalid, "invalid host", "lens://foobar");
}); });

1
src/renderer/components/layout/top-bar/start-state-sync.injectable.ts
View File

@ -28,6 +28,7 @@ const startTopbarStateSyncInjectable = getInjectable({
}; };
}, },
injectionToken: beforeFrameStartsInjectionToken, injectionToken: beforeFrameStartsInjectionToken,
causesSideEffects: true,
}); });
export default startTopbarStateSyncInjectable; export default startTopbarStateSyncInjectable;

4
src/renderer/getDiForUnitTesting.tsx
View File

@ -50,6 +50,7 @@ import getRandomIdInjectable from "../common/utils/get-random-id.injectable";
import getFilePathsInjectable from "./components/+preferences/kubernetes/helm-charts/adding-of-custom-helm-repository/helm-file-input/get-file-paths.injectable"; import getFilePathsInjectable from "./components/+preferences/kubernetes/helm-charts/adding-of-custom-helm-repository/helm-file-input/get-file-paths.injectable";
import callForPublicHelmRepositoriesInjectable from "./components/+preferences/kubernetes/helm-charts/adding-of-public-helm-repository/public-helm-repositories/call-for-public-helm-repositories.injectable"; import callForPublicHelmRepositoriesInjectable from "./components/+preferences/kubernetes/helm-charts/adding-of-public-helm-repository/public-helm-repositories/call-for-public-helm-repositories.injectable";
import platformInjectable from "../common/vars/platform.injectable"; import platformInjectable from "../common/vars/platform.injectable";
import startTopbarStateSyncInjectable from "./components/layout/top-bar/start-state-sync.injectable";
export const getDiForUnitTesting = (opts: { doGeneralOverrides?: boolean } = {}) => { export const getDiForUnitTesting = (opts: { doGeneralOverrides?: boolean } = {}) => {
const { const {
@ -74,6 +75,9 @@ export const getDiForUnitTesting = (opts: { doGeneralOverrides?: boolean } = {})
if (doGeneralOverrides) { if (doGeneralOverrides) {
di.override(getRandomIdInjectable, () => () => "some-irrelevant-random-id"); di.override(getRandomIdInjectable, () => () => "some-irrelevant-random-id");
di.override(platformInjectable, () => "darwin"); di.override(platformInjectable, () => "darwin");
di.override(startTopbarStateSyncInjectable, () => ({
run: () => {},
}));
di.override(terminalSpawningPoolInjectable, () => document.createElement("div")); di.override(terminalSpawningPoolInjectable, () => document.createElement("div"));
di.override(hostedClusterIdInjectable, () => undefined); di.override(hostedClusterIdInjectable, () => undefined);