hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Remove unneccessary causesSideEffects

Browse Source 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2023-01-10 11:35:15 -05:00
parent c658a0b0da
commit 9b7e77dc15
2 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/features/test-utils/application-builder.tsx
View File

@ -83,7 +83,6 @@ import { object } from "../../common/utils";
import catalogEntityRegistryInjectable from "../../renderer/api/catalog/entity/registry.injectable"; import catalogEntityRegistryInjectable from "../../renderer/api/catalog/entity/registry.injectable";
import createVersionDetectorInjectable from "../../main/cluster-detectors/create-version-detector.injectable"; import createVersionDetectorInjectable from "../../main/cluster-detectors/create-version-detector.injectable";
import type { VersionDetector } from "../../main/cluster-detectors/version-detector"; import type { VersionDetector } from "../../main/cluster-detectors/version-detector";
import getElementByIdInjectable from "../../renderer/utils/get-element-by-id.injectable";
import { testUsingFakeTime } from "../../common/test-utils/use-fake-time"; import { testUsingFakeTime } from "../../common/test-utils/use-fake-time";
type Callback = (di: DiContainer) => void | Promise<void>; type Callback = (di: DiContainer) => void | Promise<void>;
@ -259,16 +258,6 @@ export const setupInitializingApplicationBuilder = (init: (builder: ApplicationB
return computed(() => [...rendererExtensionState.values()]); return computed(() => [...rendererExtensionState.values()]);
}); });
windowDi.override(getElementByIdInjectable, () => (id) => {
const elem = rendered?.container.querySelector(`#${id}`);
if (!elem) {
throw new Error(`Missing #${id} in DOM`);
}
return elem;
});
windowHelpers.set(windowId, { di: windowDi, getRendered: () => rendered }); windowHelpers.set(windowId, { di: windowDi, getRendered: () => rendered });
return { return {

1
src/renderer/utils/get-element-by-id.injectable.ts
View File

@ -15,7 +15,6 @@ const getElementByIdInjectable = getInjectable({
return elem; return elem;
}, },
causesSideEffects: true,
}); });
export default getElementByIdInjectable; export default getElementByIdInjectable;