Remove unneccessary causesSideEffects

Signed-off-by: Sebastian Malton <sebastian@malton.name>

src/features/test-utils/application-builder.tsx

@@ -83,7 +83,6 @@ import { object } from "../../common/utils";
 import catalogEntityRegistryInjectable from "../../renderer/api/catalog/entity/registry.injectable";
 import createVersionDetectorInjectable from "../../main/cluster-detectors/create-version-detector.injectable";
 import type { VersionDetector } from "../../main/cluster-detectors/version-detector";
-import getElementByIdInjectable from "../../renderer/utils/get-element-by-id.injectable";
 import { testUsingFakeTime } from "../../common/test-utils/use-fake-time";
 
 type Callback = (di: DiContainer) => void | Promise<void>;
@@ -259,16 +258,6 @@ export const setupInitializingApplicationBuilder = (init: (builder: ApplicationB
         return computed(() => [...rendererExtensionState.values()]);
       });
 
-      windowDi.override(getElementByIdInjectable, () => (id) => {
-        const elem = rendered?.container.querySelector(`#${id}`);
-
-        if (!elem) {
-          throw new Error(`Missing #${id} in DOM`);
-        }
-
-        return elem;
-      });
-
       windowHelpers.set(windowId, { di: windowDi, getRendered: () => rendered });
 
       return {

src/renderer/utils/get-element-by-id.injectable.ts

@@ -15,7 +15,6 @@ const getElementByIdInjectable = getInjectable({
 
     return elem;
   },
-  causesSideEffects: true,
 });
 
 export default getElementByIdInjectable;