mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
Revert removing rising edge save of selection state
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
parent
ea11a7d7be
commit
a57bd0cb50
@ -60,6 +60,10 @@ export class NamespaceSelectFilter extends React.Component<SelectProps> {
|
|||||||
static isMultiSelection = observable.box(false);
|
static isMultiSelection = observable.box(false);
|
||||||
static isMenuOpen = observable.box(false);
|
static isMenuOpen = observable.box(false);
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Only updated on every open
|
||||||
|
*/
|
||||||
|
private selected = observable.set<string>();
|
||||||
private didToggle = false;
|
private didToggle = false;
|
||||||
|
|
||||||
constructor(props: SelectProps) {
|
constructor(props: SelectProps) {
|
||||||
@ -87,6 +91,7 @@ export class NamespaceSelectFilter extends React.Component<SelectProps> {
|
|||||||
disposeOnUnmount(this, [
|
disposeOnUnmount(this, [
|
||||||
reaction(() => this.isMenuOpen, newVal => {
|
reaction(() => this.isMenuOpen, newVal => {
|
||||||
if (newVal) { // rising edge of selection
|
if (newVal) { // rising edge of selection
|
||||||
|
this.selected.replace(namespaceStore.selectedNames);
|
||||||
this.didToggle = false;
|
this.didToggle = false;
|
||||||
}
|
}
|
||||||
}),
|
}),
|
||||||
@ -179,7 +184,7 @@ export class NamespaceSelectFilter extends React.Component<SelectProps> {
|
|||||||
formatOptionLabel={this.formatOptionLabel}
|
formatOptionLabel={this.formatOptionLabel}
|
||||||
className="NamespaceSelectFilter"
|
className="NamespaceSelectFilter"
|
||||||
menuClass="NamespaceSelectFilterMenu"
|
menuClass="NamespaceSelectFilterMenu"
|
||||||
sort={(left, right) => +namespaceStore.selectedNames.has(right.value) - +namespaceStore.selectedNames.has(left.value)}
|
sort={(left, right) => +this.selected.has(right.value) - +this.selected.has(left.value)}
|
||||||
/>
|
/>
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user