migration additions -- part 4 (isolate mobx for app & extensions)

Signed-off-by: Roman <ixrock@gmail.com>

src/common/libs-config.ts

@@ -5,10 +5,10 @@ import { enableMapSet, setAutoFreeze } from "immer";
 
 // Mobx
 configure({
-  isolateGlobalState: true, // might allow to use different versions of mobx in extensions
+  isolateGlobalState: true, // allow to use different versions of mobx in app & extensions
   enforceActions: "never", // skip usage of @action for class methods
 });
 
 // Immer
 setAutoFreeze(false); // allow to merge observables
-enableMapSet(); // allow merging maps and sets
+enableMapSet(); // allow to merge Map() and Set()

src/extensions/registries/page-menu-registry.ts

@@ -2,7 +2,6 @@
 import type { IconProps } from "../../renderer/components/icon";
 import type React from "react";
 import type { PageTarget, RegisteredPage } from "./page-registry";
-import { action, makeObservable } from "mobx";
 import { BaseRegistry } from "./base-registry";
 import { LensExtension } from "../lens-extension";
 
@@ -22,12 +21,6 @@ export interface PageMenuComponents {
 }
 
 export class PageMenuRegistry<T extends PageMenuRegistration> extends BaseRegistry<T> {
-  constructor() {
-    super();
-
-    makeObservable(this);
-  }
-
   add(items: T[], ext: LensExtension) {
     const normalizedItems = items.map(menuItem => {
       menuItem.target = {

src/main/index.ts

@@ -3,7 +3,6 @@
 import "../common/system-ca";
 import "../common/libs-config";
 import "../common/prometheus-providers";
-import * as Mobx from "mobx";
 import * as LensExtensions from "../extensions/core-api";
 import { app, autoUpdater, ipcMain, dialog, powerMonitor } from "electron";
 import { appName, isMac } from "../common/vars";
@@ -254,6 +253,5 @@ export const LensExtensionsApi = {
 };
 
 export {
-  Mobx,
   LensExtensionsApi as LensExtensions,
 };

src/main/router.ts

@@ -139,7 +139,7 @@ export class Router {
       res.end();
     } catch (err) {
       if (retryCount > 5) {
-        logger.error("handleStaticFile:", err.toString());
+        logger.error("handleStaticFile:", err);
         res.statusCode = 404;
         res.end();
 

src/renderer/bootstrap.tsx

@@ -1,16 +1,14 @@
 import "./components/app.scss";
 import "../common/libs-config";
-import React from "react";
-import * as Mobx from "mobx";
-import * as MobxReact from "mobx-react";
+import * as React from "react";
 import * as ReactRouter from "react-router";
 import * as ReactRouterDom from "react-router-dom";
+import * as LensExtensions from "../extensions/extension-api";
 import { render, unmountComponentAtNode } from "react-dom";
 import { clusterStore } from "../common/cluster-store";
 import { userStore } from "../common/user-store";
 import { delay } from "../common/utils";
-import { isMac, isDevelopment } from "../common/vars";
-import * as LensExtensions from "../extensions/extension-api";
+import { isDevelopment, isMac } from "../common/vars";
 import { extensionDiscovery } from "../extensions/extension-discovery";
 import { extensionLoader } from "../extensions/extension-loader";
 import { extensionsStore } from "../extensions/extensions-store";
@@ -39,8 +37,6 @@ export {
   React,
   ReactRouter,
   ReactRouterDom,
-  Mobx,
-  MobxReact,
   LensExtensions
 };
 
@@ -79,8 +75,8 @@ export async function bootstrap(App: AppComponent) {
     }
   });
   render(<>
-    {isMac && <div id="draggable-top" />}
-    <App />
+    {isMac && <div id="draggable-top"/>}
+    <App/>
   </>, rootElem);
 }