mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
address review comments
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
This commit is contained in:
parent
ae2430a95b
commit
b07d5446f2
@ -32,7 +32,7 @@ const statusBarItemRegistratorInjectable = getInjectable({
|
||||
export default statusBarItemRegistratorInjectable;
|
||||
|
||||
const toItemInjectableFor = (extension: LensRendererExtension, getRandomId: () => string) => {
|
||||
const _toItemInjectable = () => (registration: StatusBarRegistration): Injectable<StatusBarItem, StatusBarItem, void>[] => {
|
||||
return (registration: StatusBarRegistration): Injectable<StatusBarItem, StatusBarItem, void>[] => {
|
||||
const id = `${getRandomId()}-status-bar-item-for-extension-${extension.sanitizedExtensionId}`;
|
||||
let component: React.ComponentType;
|
||||
let position: "left" | "right";
|
||||
@ -40,7 +40,6 @@ const toItemInjectableFor = (extension: LensRendererExtension, getRandomId: () =
|
||||
if (registration?.item) {
|
||||
const { item } = registration;
|
||||
|
||||
// default for old API is "right"
|
||||
position = "right";
|
||||
component =
|
||||
() => (
|
||||
@ -78,10 +77,7 @@ const toItemInjectableFor = (extension: LensRendererExtension, getRandomId: () =
|
||||
|
||||
injectionToken: statusBarItemInjectionToken,
|
||||
})];
|
||||
|
||||
};
|
||||
|
||||
return _toItemInjectable();
|
||||
};
|
||||
|
||||
|
||||
|
||||
Loading…
Reference in New Issue
Block a user