hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Remove last usages of legacy global showDetails

Browse Source 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2023-01-03 11:26:10 -05:00
parent b7b1e97a7b
commit b15c6a4dfc
3 changed files with 10 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/renderer/components/+storage-volumes/volume-details-list.tsx
View File

@ -10,7 +10,6 @@ import { observer } from "mobx-react";
import type { PersistentVolume } from "../../../common/k8s-api/endpoints/persistent-volume.api";
import { TableRow } from "../table/table-row";
import { cssNames, prevDefault } from "../../utils";
import { showDetails } from "../kube-detail-params";
import { TableCell } from "../table/table-cell";
import { Spinner } from "../spinner/spinner";
import { DrawerTitle } from "../drawer/drawer-title";
@ -20,6 +19,8 @@ import kebabCase from "lodash/kebabCase";
import type { PersistentVolumeStore } from "./store";
import { withInjectables } from "@ogre-tools/injectable-react";
import persistentVolumeStoreInjectable from "./store.injectable";
import type { ShowDetails } from "../kube-detail-params/show-details.injectable";
import showDetailsInjectable from "../kube-detail-params/show-details.injectable";
export interface VolumeDetailsListProps {
persistentVolumes: PersistentVolume[];
@ -33,6 +34,7 @@ enum sortBy {
interface Dependencies {
persistentVolumeStore: PersistentVolumeStore;
showDetails: ShowDetails;
}
@observer
@ -44,7 +46,7 @@ class NonInjectedVolumeDetailsList extends React.Component<VolumeDetailsListProp
};
getTableRow = (uid: string) => {
const { persistentVolumes } = this.props;
const { persistentVolumes, showDetails } = this.props;
const volume = persistentVolumes.find(volume => volume.getId() === uid);
if (!volume) {
@ -105,5 +107,6 @@ export const VolumeDetailsList = withInjectables<Dependencies, VolumeDetailsList
getProps: (di, props) => ({
...props,
persistentVolumeStore: di.inject(persistentVolumeStoreInjectable),
showDetails: di.inject(showDetailsInjectable),
}),
});

7
src/renderer/components/+workloads-pods/pod-details-list.tsx
View File

@ -17,10 +17,11 @@ import { Table, TableCell, TableHead, TableRow } from "../table";
import { Spinner } from "../spinner";
import { DrawerTitle } from "../drawer";
import { KubeObjectStatusIcon } from "../kube-object-status-icon";
import { showDetails } from "../kube-detail-params";
import type { PodStore } from "./store";
import { withInjectables } from "@ogre-tools/injectable-react";
import podStoreInjectable from "./store.injectable";
import type { ShowDetails } from "../kube-detail-params/show-details.injectable";
import showDetailsInjectable from "../kube-detail-params/show-details.injectable";
enum sortBy {
name = "name",
@ -39,6 +40,7 @@ export interface PodDetailsListProps {
interface Dependencies {
podStore: PodStore;
showDetails: ShowDetails;
}
@observer
@ -113,7 +115,7 @@ class NonInjectedPodDetailsList extends React.Component<PodDetailsListProps & De
}
getTableRow(uid: string) {
const { pods, podStore } = this.props;
const { pods, podStore, showDetails } = this.props;
const pod = pods.find(pod => pod.getId() == uid);
if (!pod) {
@ -208,5 +210,6 @@ export const PodDetailsList = withInjectables<Dependencies, PodDetailsListProps>
getProps: (di, props) => ({
...props,
podStore: di.inject(podStoreInjectable),
showDetails: di.inject(showDetailsInjectable),
}),
});

12
src/renderer/components/kube-detail-params/index.ts
View File

@ -1,12 +0,0 @@
/**
* Copyright (c) OpenLens Authors. All rights reserved.
* Licensed under MIT License. See LICENSE in root directory for more information.
*/
import { asLegacyGlobalFunctionForExtensionApi } from "../../../extensions/as-legacy-globals-for-extension-api/as-legacy-global-function-for-extension-api";
import showDetailsInjectable from "./show-details.injectable";
/**
* @deprecated use `di.inject(showDetailsInjectable)` instead
*/
export const showDetails = asLegacyGlobalFunctionForExtensionApi(showDetailsInjectable);