hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Fix chart upgrade screen by coercing the chart version to semver

Browse Source 
Without that fix, I'm seeing such an errors when upgrading a chart:
```
semver.js:41 Uncaught (in promise) TypeError: Invalid Version: 1.9-dev
    at new A (semver.js:41)
    at Object.e.exports [as compare] (compare.js:3)
    at helm-chart.store.ts:37
    at Array.sort (<anonymous>)
    at QR.sortVersions (helm-chart.store.ts:36)
    at async QR.getVersions (helm-chart.store.ts:64)
    at async XD.loadVersions (upgrade-chart.tsx:57)
```

Signed-off-by: Marc Bachmann <marc.brookman@gmail.com>
This commit is contained in:
Marc Bachmann 2021-04-21 14:51:46 +02:00
parent 57a1612545
commit b9450fe1bd
No known key found for this signature in database
GPG Key ID: 001884E1441067E1
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/renderer/components/+apps-helm-charts/helm-chart.store.ts
View File

@ -34,7 +34,10 @@ export class HelmChartStore extends ItemStore<HelmChart> {
protected sortVersions = (versions: IChartVersion[]) => { protected sortVersions = (versions: IChartVersion[]) => {
return versions.sort((first, second) => { return versions.sort((first, second) => {
return semver.compare(second.version, first.version); const firstVersion = semver.coerce(first.version || 0);
const secondVersion = semver.coerce(second.version || 0);
return semver.compare(secondVersion, firstVersion);
}); });
}; };