mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
Cleanup add namespace dialog (#2261)
- Remove mixing of async and promises - Remove unnecessary instance close method - Use condition call syntax Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
parent
25a7403f3c
commit
bcaef79386
@ -33,20 +33,18 @@ export class AddNamespaceDialog extends React.Component<Props> {
|
|||||||
this.namespace = "";
|
this.namespace = "";
|
||||||
};
|
};
|
||||||
|
|
||||||
close = () => {
|
|
||||||
AddNamespaceDialog.close();
|
|
||||||
};
|
|
||||||
|
|
||||||
addNamespace = async () => {
|
addNamespace = async () => {
|
||||||
const { namespace } = this;
|
const { namespace } = this;
|
||||||
const { onSuccess, onError } = this.props;
|
const { onSuccess, onError } = this.props;
|
||||||
|
|
||||||
try {
|
try {
|
||||||
await namespaceStore.create({ name: namespace }).then(onSuccess);
|
const created = await namespaceStore.create({ name: namespace });
|
||||||
this.close();
|
|
||||||
|
onSuccess?.(created);
|
||||||
|
AddNamespaceDialog.close();
|
||||||
} catch (err) {
|
} catch (err) {
|
||||||
Notifications.error(err);
|
Notifications.error(err);
|
||||||
onError && onError(err);
|
onError?.(err);
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
@ -61,9 +59,9 @@ export class AddNamespaceDialog extends React.Component<Props> {
|
|||||||
className="AddNamespaceDialog"
|
className="AddNamespaceDialog"
|
||||||
isOpen={AddNamespaceDialog.isOpen}
|
isOpen={AddNamespaceDialog.isOpen}
|
||||||
onOpen={this.reset}
|
onOpen={this.reset}
|
||||||
close={this.close}
|
close={AddNamespaceDialog.close}
|
||||||
>
|
>
|
||||||
<Wizard header={header} done={this.close}>
|
<Wizard header={header} done={AddNamespaceDialog.close}>
|
||||||
<WizardStep
|
<WizardStep
|
||||||
contentClass="flex gaps column"
|
contentClass="flex gaps column"
|
||||||
nextLabel="Create"
|
nextLabel="Create"
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user