hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Make sense in horizontal lines

Browse Source 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
This commit is contained in:
Janne Savolainen 2022-10-19 11:38:44 +03:00
parent 409e39deb8
commit c04adf3eff
No known key found for this signature in database
GPG Key ID: 8C6CFB2FFFE8F68A
12 changed files with 172 additions and 57 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/features/preferences/__snapshots__/closing-preferences.test.tsx.snap
View File

@ -166,8 +166,12 @@ exports[`preferences - closing-preferences given accessing preferences directly
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
</div> </div>
</div> </div>
</nav> </nav>
@ -870,8 +874,12 @@ exports[`preferences - closing-preferences given accessing preferences directly
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
</div> </div>
</div> </div>
</nav> </nav>
@ -1438,8 +1446,12 @@ exports[`preferences - closing-preferences given already in a page and then navi
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
</div> </div>
</div> </div>
</nav> </nav>
@ -2142,8 +2154,12 @@ exports[`preferences - closing-preferences given already in a page and then navi
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
</div> </div>
</div> </div>
</nav> </nav>

8
src/features/preferences/__snapshots__/extension-adding-preference-tabs.test.tsx.snap
View File

@ -179,8 +179,12 @@ exports[`preferences: extension adding preference tabs given in preferences, whe
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
</div> </div>
</div> </div>
</nav> </nav>

48
src/features/preferences/__snapshots__/hiding-of-empty-branches.test.tsx.snap
View File

@ -154,11 +154,19 @@ exports[`preferences - hiding-of-empty-branches, given in preferences page given
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
</div> </div>
</div> </div>
</nav> </nav>
@ -848,8 +856,12 @@ exports[`preferences - hiding-of-empty-branches, given in preferences page given
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
<div <div
data-preference-tab-group-test="some-tab-group" data-preference-tab-group-test="some-tab-group"
> >
@ -872,8 +884,12 @@ exports[`preferences - hiding-of-empty-branches, given in preferences page given
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
</div> </div>
</div> </div>
</nav> </nav>
@ -1563,8 +1579,12 @@ exports[`preferences - hiding-of-empty-branches, given in preferences page given
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
<div <div
data-preference-tab-group-test="some-tab-group" data-preference-tab-group-test="some-tab-group"
> >
@ -1599,8 +1619,12 @@ exports[`preferences - hiding-of-empty-branches, given in preferences page given
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
</div> </div>
</div> </div>
</nav> </nav>

24
src/features/preferences/__snapshots__/navigation-to-application-preferences.test.ts.snap
View File

@ -154,8 +154,12 @@ exports[`preferences - navigation to application preferences given in some child
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
</div> </div>
</div> </div>
</nav> </nav>
@ -498,8 +502,12 @@ exports[`preferences - navigation to application preferences given in some child
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
</div> </div>
</div> </div>
</nav> </nav>
@ -1191,8 +1199,12 @@ exports[`preferences - navigation to application preferences given in some child
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
</div> </div>
</div> </div>
</nav> </nav>

16
src/features/preferences/__snapshots__/navigation-to-editor-preferences.test.ts.snap
View File

@ -154,8 +154,12 @@ exports[`preferences - navigation to editor preferences given in preferences, wh
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
</div> </div>
</div> </div>
</nav> </nav>
@ -846,8 +850,12 @@ exports[`preferences - navigation to editor preferences given in preferences, wh
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
</div> </div>
</div> </div>
</nav> </nav>

16
src/features/preferences/__snapshots__/navigation-to-proxy-preferences.test.ts.snap
View File

@ -154,8 +154,12 @@ exports[`preferences - navigation to proxy preferences given in preferences, whe
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
</div> </div>
</div> </div>
</nav> </nav>
@ -846,8 +850,12 @@ exports[`preferences - navigation to proxy preferences given in preferences, whe
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
</div> </div>
</div> </div>
</nav> </nav>

40
src/features/preferences/__snapshots__/navigation-to-telemetry-preferences.test.tsx.snap
View File

@ -166,8 +166,12 @@ exports[`preferences - navigation to telemetry preferences given URL for Sentry
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
</div> </div>
</div> </div>
</nav> </nav>
@ -481,8 +485,12 @@ exports[`preferences - navigation to telemetry preferences given in preferences,
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
</div> </div>
</div> </div>
</nav> </nav>
@ -1185,8 +1193,12 @@ exports[`preferences - navigation to telemetry preferences given in preferences,
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
</div> </div>
</div> </div>
</nav> </nav>
@ -1889,8 +1901,12 @@ exports[`preferences - navigation to telemetry preferences given in preferences,
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
</div> </div>
</div> </div>
</nav> </nav>
@ -2194,8 +2210,12 @@ exports[`preferences - navigation to telemetry preferences given no URL for Sent
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
</div> </div>
</div> </div>
</nav> </nav>

16
src/features/preferences/__snapshots__/navigation-to-terminal-preferences.test.ts.snap
View File

@ -154,8 +154,12 @@ exports[`preferences - navigation to terminal preferences given in preferences,
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
</div> </div>
</div> </div>
</nav> </nav>
@ -846,8 +850,12 @@ exports[`preferences - navigation to terminal preferences given in preferences,
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
</div> </div>
</div> </div>
</nav> </nav>

8
src/features/preferences/__snapshots__/navigation-using-application-menu.test.ts.snap
View File

@ -372,8 +372,12 @@ exports[`preferences - navigation using application menu when navigating to pref
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
</div> </div>
</div> </div>
</nav> </nav>

8
src/features/preferences/__snapshots__/navigation-using-tray.test.ts.snap
View File

@ -375,8 +375,12 @@ exports[`show-about-using-tray when navigating using tray renders 1`] = `
</div> </div>
</div> </div>
<div <div
class="HorizontalLine" style="padding: 0px 10px;"
/> >
<div
class="HorizontalLine Small"
/>
</div>
</div> </div>
</div> </div>
</nav> </nav>

5
src/features/preferences/renderer/compliance-for-legacy-extension-api/registrator-for-preference-items.injectable.tsx
View File

@ -10,6 +10,7 @@ import { extensionRegistratorInjectionToken } from "../../../../extensions/exten
import { PreferencePageComponent } from "../preference-page-component"; import { PreferencePageComponent } from "../preference-page-component";
import { ExtensionPreferenceItem } from "./extension-preference-item"; import { ExtensionPreferenceItem } from "./extension-preference-item";
import { computed } from "mobx"; import { computed } from "mobx";
import { HorizontalLine } from "../horizontal-line/horizontal-line";
const registratorForPreferenceItemsInjectable = getInjectable({ const registratorForPreferenceItemsInjectable = getInjectable({
id: "registrator-for-preference-items", id: "registrator-for-preference-items",
@ -53,7 +54,7 @@ const registratorForPreferenceItemsInjectable = getInjectable({
</PreferencePageComponent> </PreferencePageComponent>
), ),
childSeparator: () => <hr />, childSeparator: HorizontalLine,
}), }),
injectionToken: preferenceItemInjectionToken, injectionToken: preferenceItemInjectionToken,
@ -132,7 +133,7 @@ const registratorForPreferenceItemsInjectable = getInjectable({
<ExtensionPreferenceItem registration={registration} /> <ExtensionPreferenceItem registration={registration} />
), ),
childSeparator: () => <hr />, childSeparator: HorizontalLine,
}), }),
injectionToken: preferenceItemInjectionToken, injectionToken: preferenceItemInjectionToken,

8
src/features/preferences/renderer/preference-items/preference-tab-root.tsx
View File

@ -4,6 +4,7 @@
*/ */
import type { IComputedValue } from "mobx"; import type { IComputedValue } from "mobx";
import { computed } from "mobx"; import { computed } from "mobx";
import React from "react";
import { HorizontalLine } from "../horizontal-line/horizontal-line"; import { HorizontalLine } from "../horizontal-line/horizontal-line";
export interface PreferenceTabsRoot { export interface PreferenceTabsRoot {
@ -19,5 +20,10 @@ export const preferenceTabsRoot: PreferenceTabsRoot = {
id: "preference-tabs", id: "preference-tabs",
parentId: undefined, parentId: undefined,
isShown: computed(() => true as const), isShown: computed(() => true as const),
childSeparator: HorizontalLine,
childSeparator: () => (
<div style={{ padding: "0 10px" }}>
<HorizontalLine small />
</div>
),
}; };