Merge pull request #4557 from lensapp/remove-weird-whitespace

Remove all 'NonBreakingSpace' characters from the repo

.eslintrc.js

@@ -118,6 +118,7 @@ module.exports = {
         sourceType: "module",
       },
       rules: {
+        "no-irregular-whitespace": "error",
         "header/header": [2, "./license-header"],
         "no-invalid-this": "off",
         "@typescript-eslint/no-invalid-this": ["error"],
@@ -199,6 +200,7 @@ module.exports = {
         jsx: true,
       },
       rules: {
+        "no-irregular-whitespace": "error",
         "header/header": [2, "./license-header"],
         "no-invalid-this": "off",
         "@typescript-eslint/no-invalid-this": ["error"],

extensions/metrics-cluster-feature/src/metrics-settings.tsx

@@ -187,7 +187,7 @@ export class MetricsSettings extends React.Component<Props> {
     this.changed = true;
   }
 
-  @computed get buttonLabel() {
+  @computed get buttonLabel() {
     const allDisabled = !this.featureStates.kubeStateMetrics && !this.featureStates.nodeExporter && !this.featureStates.prometheus;
 
     if (this.inProgress && this.canUpgrade) return "Upgrading ...";

src/common/ipc/ipc.ts

@@ -26,7 +26,7 @@
 import { ipcMain, ipcRenderer, webContents } from "electron";
 import { toJS } from "../utils/toJS";
 import logger from "../../main/logger";
-import { ClusterFrameInfo, clusterFrameMap } from "../cluster-frames";
+import { ClusterFrameInfo, clusterFrameMap } from "../cluster-frames";
 import type { Disposer } from "../utils";
 import type remote from "@electron/remote";
 

src/common/utils/readableStream.ts

@@ -44,7 +44,7 @@ export class ReadableWebToNodeStream<T extends TypedArray> extends Readable {
 
   /**
    *
-   * @param stream Readable​Stream: https://developer.mozilla.org/en-US/docs/Web/API/ReadableStream
+   * @param stream ReadableStream: https://developer.mozilla.org/en-US/docs/Web/API/ReadableStream
    */
   constructor(stream: ReadableStream<T>) {
     super();
@@ -85,7 +85,7 @@ export class ReadableWebToNodeStream<T extends TypedArray> extends Readable {
   }
 
   /**
-   * If there is no unresolved read call to Web-API Readable​Stream immediately returns;
+   * If there is no unresolved read call to Web-API ReadableStream immediately returns;
    * otherwise will wait until the read is resolved.
    */
   public async waitForReadToComplete() {

src/main/lens-binary.ts

@@ -84,7 +84,7 @@ export class LensBinary {
     }
   }
 
-  public setLogger(logger: Console | winston.Logger) {
+  public setLogger(logger: Console | winston.Logger) {
     this.logger = logger;
   }
 

src/main/window-manager.ts

@@ -118,7 +118,7 @@ export class WindowManager extends Singleton {
           appEventBus.emit({ name: "app", action: "dom-ready" });
         })
         .on("did-fail-load", (_event, code, desc) => {
-          logger.error(`[WINDOW-MANAGER]: Failed to load Main window`, { code, desc });
+          logger.error(`[WINDOW-MANAGER]: Failed to load Main window`, { code, desc });
         })
         .on("did-finish-load", () => {
           logger.info("[WINDOW-MANAGER]: Main window loaded");
@@ -160,7 +160,7 @@ export class WindowManager extends Singleton {
 
     try {
       if (showSplash) await this.showSplash();
-      logger.info(`[WINDOW-MANAGER]: Loading Main window from url: ${this.mainUrl} ...`);
+      logger.info(`[WINDOW-MANAGER]: Loading Main window from url: ${this.mainUrl} ...`);
       await this.mainWindow.loadURL(this.mainUrl);
     } catch (error) {
       logger.error("Loading main window failed", { error });

src/migrations/hotbar-store/5.0.0-beta.10.ts

@@ -127,7 +127,7 @@ export default {
        * Finally, make sure that the catalog entity hotbar item is in place.
        * Just in case something else removed it.
        *
-       * if every hotbar has elements that all not the `catalog-entity` item
+       * if every hotbar has elements that all not the `catalog-entity` item
        */
       if (hotbars.every(hotbar => hotbar.items.every(item => item?.entity?.uid !== "catalog-entity"))) {
         // note, we will add a new whole hotbar here called "default" if that was previously removed

src/renderer/api/catalog-entity-registry.ts

@@ -199,7 +199,7 @@ export class CatalogEntityRegistry {
     const runEvent = new CatalogRunEvent({ target: entity });
 
     for (const onBeforeRun of this.onBeforeRunHooks) {
-      try { 
+      try {
         await onBeforeRun(runEvent);
       } catch (error) {
         logger.warn(`[CATALOG-ENTITY-REGISTRY]: entity ${entity.getId()} onBeforeRun threw an error`, error);

src/renderer/components/+catalog/catalog-add-button.tsx

@@ -21,7 +21,7 @@
 
 import "./catalog-add-button.scss";
 import React from "react";
-import { SpeedDial, SpeedDialAction } from "@material-ui/lab";
+import { SpeedDial, SpeedDialAction } from "@material-ui/lab";
 import { Icon } from "../icon";
 import { observer } from "mobx-react";
 import { observable, makeObservable, action } from "mobx";
@@ -97,7 +97,7 @@ export class CatalogAddButton extends React.Component<CatalogAddButtonProps> {
   }
 
   @boundMethod
-  onClose() {
+  onClose() {
     this.isOpen = false;
   }
 

src/renderer/components/+events/events.tsx

@@ -37,7 +37,7 @@ import { cssNames, IClassName, stopPropagation } from "../../utils";
 import { Icon } from "../icon";
 import { eventsURL } from "../../../common/routes";
 import { getDetailsUrl } from "../kube-detail-params";
-import { apiManager } from "../../../common/k8s-api/api-manager";
+import { apiManager } from "../../../common/k8s-api/api-manager";
 
 enum columnId {
   message = "message",

src/renderer/components/+preferences/application.tsx

@@ -42,7 +42,7 @@ const updateChannelOptions: SelectOption<string>[] = Array.from(
 
 export const Application = observer(() => {
   const defaultShell = process.env.SHELL
-    || process.env.PTYSHELL
+    || process.env.PTYSHELL
     || (
       isWindows
         ? "powershell.exe"

src/renderer/components/dock/terminal.ts

@@ -30,7 +30,7 @@ import { boundMethod, disposer } from "../../utils";
 import { isMac } from "../../../common/vars";
 import { camelCase, once } from "lodash";
 import { UserStore } from "../../../common/user-store";
-import { clipboard } from "electron";
+import { clipboard } from "electron";
 import logger from "../../../common/logger";
 
 export class Terminal {