1
0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00

Make element discovery able to discover without value for attribute

Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
This commit is contained in:
Iku-turso 2022-10-18 13:52:05 +03:00 committed by Janne Savolainen
parent 18a3325977
commit c581713ca1
No known key found for this signature in database
GPG Key ID: 8C6CFB2FFFE8F68A

View File

@ -7,13 +7,13 @@ import type { RenderResult } from "@testing-library/react";
type DiscoverySourceTypes = RenderResult | Element;
export const querySingleElement =
(attributeName: string, attributeValue: string) =>
(attributeName: string, attributeValue?: string) =>
(source: DiscoverySourceTypes) => {
const dataAttribute = `data-${attributeName}-test`;
return getBaseElement(source).querySelector(
`[${dataAttribute}="${attributeValue}"]`,
);
const selector = attributeValue ? `[${dataAttribute}="${attributeValue}"]` : `[${dataAttribute}]` ;
return getBaseElement(source).querySelector(selector);
};
export const queryAllElements =
@ -34,7 +34,7 @@ export const queryAllElements =
};
export const getSingleElement =
(attributeName: string, attributeValue: string) =>
(attributeName: string, attributeValue?: string) =>
(source: DiscoverySourceTypes) => {
const dataAttribute = `data-${attributeName}-test`;
@ -44,11 +44,15 @@ export const getSingleElement =
const validValues =
queryAllElements(attributeName)(source).attributeValues;
throw new Error(
`Couldn't find HTML element with attribute "${dataAttribute}" with value "${attributeValue}". Valid values are:\n\n"${validValues.join(
'",\n"',
)}"`,
);
if(attributeValue) {
throw new Error(
`Couldn't find HTML-element with attribute "${dataAttribute}" with value "${attributeValue}". Present values are:\n\n"${validValues.join(
'",\n"',
)}"`,
);
}
throw new Error(`Couldn't find HTML-element with attribute "${dataAttribute}"`);
}
return element;